From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 630E4C61DA4 for ; Thu, 23 Feb 2023 19:08:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD8776B0071; Thu, 23 Feb 2023 14:08:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D87D46B0072; Thu, 23 Feb 2023 14:08:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDBFB6B0073; Thu, 23 Feb 2023 14:08:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A94A26B0071 for ; Thu, 23 Feb 2023 14:08:15 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 71E02A97BB for ; Thu, 23 Feb 2023 19:08:15 +0000 (UTC) X-FDA: 80499492150.11.77C3558 Received: from CY4PR02CU008-vft-obe.outbound.protection.outlook.com (mail-westcentralusazon11012002.outbound.protection.outlook.com [40.93.200.2]) by imf02.hostedemail.com (Postfix) with ESMTP id 4905F8000D for ; Thu, 23 Feb 2023 19:08:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=vmware.com header.s=selector2 header.b=staJalvG; spf=pass (imf02.hostedemail.com: domain of namit@vmware.com designates 40.93.200.2 as permitted sender) smtp.mailfrom=namit@vmware.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=vmware.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677179292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=En8jOnnzwMNikiRE6zJoRo+SMuZZjCngqxSHvs3RS2I=; b=WUzSEC7cCh7Ve0Fs+kW6e7BEhW5PvQGBZbc2MzRYheR0eSmfaL5xxfaYzyb5YX6Eqysgyb c69t/WkrwQWwCXPubCd+mLKqdeTInarAJLCJLCjaSpUmufE6uthgM8WtScHHrXBIRk941F 5ECVzycQU88i2bZ38fesxG3i+ieBmmc= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=vmware.com header.s=selector2 header.b=staJalvG; spf=pass (imf02.hostedemail.com: domain of namit@vmware.com designates 40.93.200.2 as permitted sender) smtp.mailfrom=namit@vmware.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=vmware.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677179292; a=rsa-sha256; cv=pass; b=2+uxDqk/Ahltxnp9A/UPfX9MN4ONXKtwG05YRFWR3UQg5mR6Q/QhVNw9VkhRYmSQf7ClKV nUi/JjMCDLUri0/NYOBpym225n6BbkJXkjdopC7WS62r+2UiwfZFSbbPjK6lF4XcyZLkzN zodfMri/fXZZS8zNUvXN+gyrZy3b6I8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eTDgPiuNtt30HBf066E67NlCYu4E/uCG4cd5ZmU+UWRyJZXU/YB5BmLtnGAxMj/26FGNYp5VJ/LwLhbXnMkF8LsZYlYsWR+vsOxIOzoCVyihxioGN6zuWvvMHMHw9haGNvjJA24Y67I9UIbnPE87GScvxgvDHIQ9T219wTAjoJvD4yo/qZrEch1uRnzKDsbuc3XniLAB9hUyc7++cQPSyZqcwjusCitKYgysPmqPqFd1cA5Kx8zarvrY96qYsectEgsMnodFU4OJ0bcxws7h8486MaIyOja/c8UuYdrwzvJN2thDmUT0zZrJIPPu07uDCDvWzl6LR0HOvxGXrUDQTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=En8jOnnzwMNikiRE6zJoRo+SMuZZjCngqxSHvs3RS2I=; b=WTuO7oVIUHWDS6oDCpCFPF/sS38m7RH72p3se7Dts+EnYrgER3K107dXSptvy51K8OAVYssDPZrNyVKyGN/3BZ/XFkWoUhYuvkm5qoUN36YJLSf5viwMch7uGQYXS1Bx4EYDfnK39Uq0SOgXyDHOFkPSM7tFAvtPk8iLASvCrNFTWieQDydl1bJkBitT1P6byYDXmfUmyqYPNUMn00BOYUZk2Od3V1l0RZoNzuHZWe3LcTgHFK0DaHgUG4McK3CQT57+uVKrmgpszsKk42VpCwjxzOyzKFpINwmtFFTz7shSZfmOKoNyKA/4yPQaJBSq74ozufy+7juJ4BsZcpOQ6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=En8jOnnzwMNikiRE6zJoRo+SMuZZjCngqxSHvs3RS2I=; b=staJalvG3yfzzUE/7/NaZh2LzFVwjxtAJmXMUjxbaO6vr28mNhktlqCfZOI7496+tK1lcGjF0Vty9xKuIEx6/UEmtDd5N6Z3UuVEi5P3LmpCLN98R/8GDw2wFimpVpqE+Ah8w/R/UkNl/HauoqrjgCBThyNx/mGvGNT/u3/+PpM= Received: from BY3PR05MB8531.namprd05.prod.outlook.com (2603:10b6:a03:3ce::6) by IA1PR05MB9244.namprd05.prod.outlook.com (2603:10b6:208:3a3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Thu, 23 Feb 2023 19:08:08 +0000 Received: from BY3PR05MB8531.namprd05.prod.outlook.com ([fe80::e9bd:ef2f:b71:8084]) by BY3PR05MB8531.namprd05.prod.outlook.com ([fe80::e9bd:ef2f:b71:8084%9]) with mapi id 15.20.6134.021; Thu, 23 Feb 2023 19:08:08 +0000 From: Nadav Amit To: Axel Rasmussen CC: Alexander Viro , Andrew Morton , Hugh Dickins , Jan Kara , "Liam R. Howlett" , Matthew Wilcox , Mike Kravetz , Mike Rapoport , Muchun Song , Peter Xu , Shuah Khan , James Houghton , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" Subject: Re: [PATCH v2 3/5] mm: userfaultfd: combine 'mode' and 'wp_copy' arguments Thread-Topic: [PATCH v2 3/5] mm: userfaultfd: combine 'mode' and 'wp_copy' arguments Thread-Index: AQHZRyHq5XmoYIOsjkuDkcqzrjwGLa7c4ToAgAADrACAAAEeAA== Date: Thu, 23 Feb 2023 19:08:08 +0000 Message-ID: References: <20230223005754.2700663-1-axelrasmussen@google.com> <20230223005754.2700663-4-axelrasmussen@google.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR05MB8531:EE_|IA1PR05MB9244:EE_ x-ms-office365-filtering-correlation-id: b51d8383-bb8d-4c68-af30-08db15d14cf7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DV2+pDOMdVq6pbXGRXrfHS2NtPW3VYO0tYtOqGw6t1djbHKIvsd9DgrLW/2S8RERHBeWrAEj2sWYUCSsfVyUQF1Nz06XGllTGpvXnrVzmlS11WI396GxY+4g4jUMVjp60Znb6P4kKOuYrfIl5AsWCamom7/aI5rhshW+ODdO9QpZg4epMH5kcp+9yZ0VHeBx3hYDqPjRHHOq33+0LBUI0m/wK4+V5JmPYGtujRSorALUDXSsLfDAUwnaRgFGBoNZ+jxO7f/luP2opcMw80cga+Eg6EUdREDD3x/6OCnpY2NvJUrQwYALDLzjXq+PSC3CN1oQByF5g+xe5rOFDN0hmpKhnVlt55QS26SqU2MWZj/gpUMkXEJ3It0SxTb7lWX0gxSaOalwvXsFxaSJBLZ1dbE7ccIvXiinizsI4kwVR4lu+lgr6JbyUH3Ls18esvxNGTWu2ueb4e/hI8OY1HSSa0KAFLhh74dX/Si8ZAhzCDCrIuoUcode+lJ2yDzVPKlBnue5ghUDVR5BY00W+ukz1BSs+J32PijHaDWhFuKMQalmCrCNAMH6hm0tQ7s2AeiZffELjE39dfwezPYCnkZ3txfNNEHSlH1cptWilVuKFLFTYteu6Biks2snv5pnstF4xHTomkek3BH1fUw1nM4SAsyuVbV3Cj8w24PH+YY3avQIjA6ljJmeVH1wE4/szzatHWK9LWPQutwq46dwTC1lDuCXFP9NF01IPUU/KV6UF6M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY3PR05MB8531.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(451199018)(38070700005)(33656002)(86362001)(36756003)(316002)(83380400001)(71200400001)(478600001)(6512007)(186003)(26005)(2616005)(6486002)(53546011)(6506007)(8936002)(7416002)(5660300002)(4744005)(54906003)(4326008)(66556008)(66476007)(76116006)(66946007)(66446008)(64756008)(8676002)(2906002)(6916009)(122000001)(41300700001)(38100700002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?siNcr1AqVGnf5adIra/vDiGmeaZDX+3tqcMiIEqX7Wg6cgTZc2MBUKfQkdZw?= =?us-ascii?Q?JHNGxR+0qSF3lqzSa6h3JY2MYEP27SqRvvJi90A62nTuHlKwOHLHlrKdhlix?= =?us-ascii?Q?V2zXXcX2ssYZoN9b7sQx4B/IREpax1J9g+DhF4q9VGPoCgMSpkeWW4QMK8OM?= =?us-ascii?Q?6JnZAjfSbBkJ2b/iUfjc/1ztQ9JD3o2ae2MuBi58hW9Vs3+yAGJEDhBpk79h?= =?us-ascii?Q?d4ru9Zdt5nQmWsLr/qvefZnW4f5kiGwRqryGfIalZt6WGLkTpsZ601f3PNa0?= =?us-ascii?Q?nOr6YkD+rZwvHLU3NUWEgwzHP+h8+LTlwmK0o9qJMnhe92K3PAIuO47efWek?= =?us-ascii?Q?VgTZthqixkiYD8F6s935rxZoCo8dPJwqpMH5DpZ9Tq676vUddcWTFJSPWeIv?= =?us-ascii?Q?5LXkgYnWrfodaWUK/nM2wl8LlCpcidMRT30KDJhTQbnkmAos93hj7DcMkuhK?= =?us-ascii?Q?A1wOl71q6r5Mz21rKk4le2nv86duYccrA93gS7MjItGlSYcrPwt6nTG9JKYt?= =?us-ascii?Q?00fVCT7VNww2eq4EorMWfJ9qBG2ZHD8rMbEpobBVAlQLT3ykaLxC7VAA9XFf?= =?us-ascii?Q?zQSuvz5H4YaOPl9kWlIHHtPsz+LhUXG9MXLhttu+cG0wLSLvSnvrSkLLcXAf?= =?us-ascii?Q?SZMJCA4Mhtxd8/h9h/5n1p1zRZV2HFAVAWHkj4pyJ5FdITN23TQx209mi1gQ?= =?us-ascii?Q?dKUTE1YIIZvMfswmHhLRPUZ5hZ6f2+UHZcL6GwdqlJPI12h0ul4t+oQ2BcP7?= =?us-ascii?Q?9Df0Ol4/PBcdTv9PSkt7d4uI3Vzw5jf8NdGJRpCWgzSd/RCZu15j1Y5Tvdn/?= =?us-ascii?Q?3AhWL4KqBR7+KAztixUF+htE1FjgbMm2OXRi00Nsm9ChbV50BzG4c/T5XKID?= =?us-ascii?Q?s1O8D4RZ0hPHSj68MgroMCQspDPWDDXHfcfj2nowuiLqoRexcNyuaBzXqFjB?= =?us-ascii?Q?hpIskwGhNA0H1uxwKQ/fz6yuBn49qsMLQOw+CKEAakMXOOqiLCUNt8RHE3l0?= =?us-ascii?Q?0iYnuaRdlC7+uYnYG9K2dq+BH4CvTq9gSYngJhCvetauonqvMB7kZ7ms+ygy?= =?us-ascii?Q?Gx7aLgwyqvbMlwm93A/jD7PZXwepADNdNA9btQ2yJnZYJL6cz/sR3zrtb81s?= =?us-ascii?Q?3Y+wJKIylSbZ44+t8ypNIWXmuAQwYj1R0ZOKniaK3rXMhri7uBlWsKZnRC2x?= =?us-ascii?Q?SoYJrNSsUfbNSv3BKqWThxzOYwAjMK5aNLO3/gB5AWupoE4yfpD0JudzHe8P?= =?us-ascii?Q?z7Z31dmO55zc5X3/oKWHugaKvBGShHpm3QrYM+6Eprk4jdjjnwX8c5F/vgXT?= =?us-ascii?Q?+r3eteg/Hzd85zytfjG+gN244+YSjo89Zmcvt9iha+NTlXQ6QSGM8hrFKqOL?= =?us-ascii?Q?QTZkT71JQiwg11s5T/WS4UVadBXRD/upQnCH4qDF01DHLthRUwGxMIMYO92Q?= =?us-ascii?Q?9YUvsiCdsNkqOeAR1O048SLYOdoe+16k4obcTDzjQNstRqdW1UV6QFqc/WPH?= =?us-ascii?Q?hlluuSdYqWwjJkTDGEBdG/9jwhbTRx7QTFq2r7mNf72XIEnFzuHAkQ/CrJgS?= =?us-ascii?Q?fkR0nReMkIxDJ3Jkt/B/acRRtKfSzeN2+4wahtg9?= Content-Type: text/plain; charset="us-ascii" Content-ID: <33BAE4DB7E1E424EB2CEB6FAC1B06AB6@namprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b51d8383-bb8d-4c68-af30-08db15d14cf7 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2023 19:08:08.6237 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cUHpt7J99kmn4uvysI+yPH1Q2rT/8E3NsAiWRrUdZQU5+OgUw7XWf4AGad9vInAvP/IICqu1YOpDvCfHkUzpsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR05MB9244 X-Stat-Signature: wdii9adewsqnqriiscnz39s7z16a8ok5 X-Rspam-User: X-Rspamd-Queue-Id: 4905F8000D X-Rspamd-Server: rspam06 X-HE-Tag: 1677179292-770952 X-HE-Meta: U2FsdGVkX18PjfVW0GHYXBKD5atZiY7jlOU3wxk9+sT6NXMfqDSgp3w+wpyr84j56qxBXWqcXF6AiSzWGtrzeuo0ZJJNz8Kq1dKvL48LunpvZMYM2DYyN+2GoSQizpnqA9LcIo9LzcbnSxm6BT3Deyu9DkHPKEBv1MQuY5KWYh2ad18cD8Wf6nsKeI2qU3560cXnSYVFrFaU1OtDljJJrflTDXFOjtmBbQ7uJg6l06LGExv2urOP4Kw7EfW2hB8Ka7dn36ZNa0IcGTKefiVUrecw9eZSidJ6VY5oO0bSXKNX1DjnDvZzc+ZjdLxxs7yAwT/YIPsF8pBGheH+fie/VOaaxlj5/aTJZf3qsPAMUFzZoZXZAWW0c9c/agHK+7K28Yzl/85AC3L0u1vxcFUsMoWjbJvBs/K3WaLrjgWevHx3+wyBL5Wp5CGeToCpYd4h/rVwc+3mnIa5Md8MdNRmXBYzHONdmKCPZ8gHCS6iWw/oNnOQ9Q/CuXyRhoerKJx0li+h2CDmzuYE4/ySsX3lyxfHw3xYCUTTZOT/psNXvC6V/4IH66R4VeP1YNRWAf0pYFLJHulqI/QdSt59+8eSRiZCuD5CujjkF2KlXG9CV/ubJAwG8vQ/dtgL1tc4f9zPfCGTYqRjpn8F2duCl2MPZ1Ll2+ImyznRnLpXeZKi6CEJiyjrUqVyTYm1cvOOLLLDMJOmEvkOKCo1Z4Xt/CAYJY4FQQu16Bn1fZhCHZgBcw29/kcnc079wx8RsxpD9W7PaW9OdZgwTPmHBhLICocxa0f4Zlto7Z8IZFRxisT1H6lpcA7c4v455ZNq66gj6LKpgku3BqkuYfogs6rb4Ac3rl+tpP1XSTCxphREtcyl2pyDVuxEvN2pmGX+/1fKtA/YIeAM77K6cPII0fH/WKCLYDyBJgpSYxTAkbJ1EyZYBNz0f/7vyKRop8G3uPcAuwtFnsb35Xzr4aJN95MIvL+ Nddg+Hpb 5D84m2MuYS9ykumZySnxLqQvChA0LXp9K+eeXSeGQgzTFfTIwKxs5tcMQxfUUcfzsBtntVlxl6s2rWzkyhmGrtYWrGwqdPZTgPdUxjM7PpaltxRccE50SFKMpzOSi1f4/4Jg+yeZlEKdXOzNyHS7yUxzZ8ASVwMCfHq+ydlsstaziBRMLNuHpExIomt/a22SgK9sTb88N4ywfOhl7J6sVypQH2n7UHSJ3ee9iKUay10D7Xb21fO7uBHhivRbzwXdqlb1ONxlLedAN9P9ZWtEsliqFpIH8sxDvq/BpCWvA87Abz7GYKrBOx8IkGaLxb+HkfiJFB6LdTK4LPEXpIkMZI9xqOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Feb 23, 2023, at 11:03 AM, Axel Rasmussen w= rote: >=20 > Oh! I must have missed it, or just forgot. I'll take a look and see > about making some improvements. I'll also be sure to credit you in the > commit message. It was not about credit. I just wanted to refer you to what I had in mind, and David did spend some time on reviewing my patch... ;-)