From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 437F4CD13CF for ; Mon, 2 Sep 2024 15:34:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD1C38D00F2; Mon, 2 Sep 2024 11:34:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B838B8D00EF; Mon, 2 Sep 2024 11:34:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E9AC8D00F2; Mon, 2 Sep 2024 11:34:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 69C958D00EF for ; Mon, 2 Sep 2024 11:34:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2FA1CA1E20 for ; Mon, 2 Sep 2024 15:34:31 +0000 (UTC) X-FDA: 82520195142.16.A2DA4C6 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2042.outbound.protection.outlook.com [40.107.220.42]) by imf19.hostedemail.com (Postfix) with ESMTP id 55FFB1A0014 for ; Mon, 2 Sep 2024 15:34:27 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=USb95rMP; spf=pass (imf19.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.42 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725291245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lo3VVlobYAnsEgqqy3OYDpCkrRcbecSZAYfT22JTwic=; b=q/yUn5zNHqvSJ3ydqiur1pvUnaXs+zoMi76ggO584jVmjHr0m2YH9VpMz7tOOAZt8Se5dZ WfbGDL5ASi/9Q4FBm0+xi82WhhwBM9q1E7YXfYgzjtkO4HoGZlW9Y80zV8aIgcIO5PPTZ+ u/P0PsScHuJs8HaXKb8fC+9SETernrY= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=USb95rMP; spf=pass (imf19.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.42 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725291245; a=rsa-sha256; cv=pass; b=yTtTsg4IsPlBtlCKPNU3eUdnYDJwbwBL2oqsLKmTANUe/xPHHi1Qkog2lfYPdSKMLLbilJ Wp6dHJSeKYtyMbivFt/9a6nl1aKpghXK4Pt8Glv6Lfi8InkHa40EeDhQ+hLudFHyFtECOb 5ywL/2nZaKmrDUVk9Zv9LDolx4ola2U= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ay8INMKp11vCq2Isadwz1ZME0nSF8lXhkEcquIwwWA3aUuFwMuS6N2+WZ+M9X/t1evk92LZ4Y2GzO9HwbH8qTZkA6obXFsPzfmwOYy7cgGCM/f09n2zY6c3ELUz40bBMFSO0DIJMfeDo2YvJNBi1KHrhC7WQ4ggxAgni65rRqO0Gaad5c5hHVUGf8M7ZSgE9czfv8c5pgDOsj2jV4J4qj4O6F+P99D3S09+H6hN1cUJ0IzyJ8OGA8OziuMhV11tQC5adlPZPk8GT8OXJbNjenVY0aqidVlEaI8xydmxbz8rlvfKpkrKIhKzjbfv445lpe488WpRYEful0gTxUCSsWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lo3VVlobYAnsEgqqy3OYDpCkrRcbecSZAYfT22JTwic=; b=w3VP2I7BGVR5MDkL+RAQo2/R92Niih81Hc9GrYzo22udn0coOuqqCpeZ6wyYWYcu3QpF/KSiL5CmKXP2IKYZVTN+K2BSVX/0IErPO1uUhzWZw7Nj2hy8XznGmtu55lPdh0LZ5D8CKAydSqsTZMecM/rYlSDldWvTxvo0+lJO+Do7A6ZWzHxyEg7AMLY97v6X1abl5fN3MHEP1ZVN0+GZmpkMjWsI2uMurH+GAXWoasjiL+JaFpdeTGilYVInDCVvnc5HgVcWHa4S/EdNifG5AKf1SIg6nww1dTQAiB5c5ExUEuUxZIN+/E9vNyiqpieCDS0KML+L1djm/EPUZ7ww9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lo3VVlobYAnsEgqqy3OYDpCkrRcbecSZAYfT22JTwic=; b=USb95rMPwNIwRKQd9HbI5DkelMlO9Wt0I4d9Q1OO+0ffAiUjeq3yKUQbM1RYlPOHzJGqeNUEMnWSKX+o2MZEpRq/2/dilxqO2qy6RRssk4YlyGVk5O1gtxpn5+GiA23SsZdtVi9CTchRenex910jM5kEHiN5cP7ghGQIenXZKSUze3TOQ3CaPgScrxSVDkis+0v/dIfpwHAswFC0zRUaxQ7JHc9YeqL5buDASZF9duqBV03wfKHy9CiK/r2F0gr+CEn1AnZ930XAwmxSdBa/6Hp8ZBheV21Q/4dxTK8oYFIWsit6OyAKkFIskm9FdZlxEvWk7zLdc9+IQSkXdrLeJg== Received: from CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) by IA1PR12MB8288.namprd12.prod.outlook.com (2603:10b6:208:3fe::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.25; Mon, 2 Sep 2024 15:34:24 +0000 Received: from CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f]) by CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f%5]) with mapi id 15.20.7918.024; Mon, 2 Sep 2024 15:34:24 +0000 From: Zi Yan To: David Hildenbrand Cc: linux-mm@kvack.org, Oscar Salvador , Vlastimil Babka , Johannes Weiner , Baolin Wang , "Kirill A. Shutemov" , Mel Gorman , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/4] mm/page_isolation: remove migratetype parameter from more functions. Date: Mon, 02 Sep 2024 11:34:22 -0400 X-Mailer: MailMate (1.14r6064) Message-ID: In-Reply-To: References: <20240828202240.2809740-1-ziy@nvidia.com> <20240828202240.2809740-5-ziy@nvidia.com> Content-Type: multipart/signed; boundary="=_MailMate_0345FC7D-70E7-40F1-8EBB-0DC6E361E0C6_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: BLAP220CA0001.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::6) To CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CYXPR12MB9320:EE_|IA1PR12MB8288:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a036a3f-b8ec-4c47-61a3-08dccb64b941 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LWbWVIYjtUqTeTwBE7ms+AK10HqFWwa8pxN2BiJvbF/pKkjB3AvuIvWy2j9w?= =?us-ascii?Q?3VJIX+zJuLmqtLRZrgmBr69AFNO4FXf8M5vDZlvOBJknza6cVCnfetANwbuA?= =?us-ascii?Q?KeJX6Jpux/rWpj0+4lPBSixIEaAv//BrPh5x1/cDVrcgTDfm50bPHJ5E+WEV?= =?us-ascii?Q?AMUA4y/VQ+oEfjwMr9ju3F5dgEm+eBG3c8uRaFI8KFG0RG3x0Qxy6bFIJK9U?= =?us-ascii?Q?qMLv3A9f1dpburlX9/Z26Xe3BfDs5m+M3196A1D+ebr2D5Yw6jsVaG10jZBW?= =?us-ascii?Q?K6gcNaBKmeEsYj0bR44NdS00nI2d2e1k4SKEuF+xo+8UDqsLjo4zkZ7TPDAM?= =?us-ascii?Q?cMTZyWt93vIrZAzGHnetZBuHWYjQ/EmARUV48ilxYYpuOp8+sfYrP0bjobMF?= =?us-ascii?Q?XSb8lSs2/5J8yLOWEsCqI+vavA3l81RdpMmn5PnQRb/OqLJRsGNcFSIz9YQY?= =?us-ascii?Q?1ppYor1Hl5YLjEfjIhgWPP6J2z3HMF//Nfc7T6z3zYbFP/6KRP3HBKos+Cfd?= =?us-ascii?Q?tB2jmd5y/W8b1SJ9z6/jmevTfvXEBriVb0BO4d5TCVOdCL7v4t9wDIa9x9aC?= =?us-ascii?Q?HmyNDNNfYKUs8l7FAMtAvJIw2iKmBsmM/oi9e2h0keVx+aqTdIxsF7JOcqc1?= =?us-ascii?Q?Hy7yjHRW/xlSOxRkjmoIvw8rgvu2QrqOxJHxJDIEzzzsyx7iMiH0X4ipFAv5?= =?us-ascii?Q?7IQKubDmDmqrMfBysgoxwV1BjsbsIPjtBB/tDxh4GfkyFhKZWlnNcVT93Vk7?= =?us-ascii?Q?jrku91tj8Py7QCPyB8H2OdKXNPZBv1uLQk34Q6YoueT2IZuPQZCP9W/Jxnhm?= =?us-ascii?Q?hUJ+qODSsFzswhdDSC/U51OwRIr17UNdwxsT+s5I8oDu8kTVsvPrkoA7JuXz?= =?us-ascii?Q?2Ob/T1UedsRlrKFM4td0ghfS+cwUk5oJ0cHN8oRZ5IUpCkJjbMY9qjBvPOmR?= =?us-ascii?Q?SpDTI2Rk/yiGBrysnSAd+TgkkKTx/n4jsObMtMcmCAjB539VZiFQgaOMGFL4?= =?us-ascii?Q?tvxt+qicphusEyW7+b/0SSlu2zYtYrPiXXhvEBdO66IABRhw3Egbe3uC9++S?= =?us-ascii?Q?cpdlagyEpxnzsI8SXrFTuEDw2j0hrxsKyIFgJXu3X0p7Ez3+kMY6jolTg9pG?= =?us-ascii?Q?2b1frGA1VuqZvuExwpK61/ZNff5ahu8sCg/NOzlu7vN+XU6Oevv0e4xAMsu7?= =?us-ascii?Q?TaDsmb2SQG59sXpSu9/ubKZdgzlOladmDUIzDG3oqmNxkPmBOb9Q8/dzoUBo?= =?us-ascii?Q?i1VSqwJ49Dz7F3qnPPdw5eVW0XHRDUHdc+IGUMD3e/RjsxE/lMDdKmZ6ccLg?= =?us-ascii?Q?aFGTRRz51Cnrz04Wf3uCwBYXpJRhv/wwgculCECF67LGGg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYXPR12MB9320.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n2f9f2WERdZiFoSoAPTLtSlZXfY7hIak74JP5KdNB2p92EauSZ/+obui0FwI?= =?us-ascii?Q?hRYLp/HWB59fw4g9+1a7NZtMC4x0y1CEM1yh6438tK1blfiRwXy0CqYcTHgI?= =?us-ascii?Q?cGhqcPEKwNbV7/3cyfbWVWe37hetrQgeZPgvquJffSuxobkEurwekVdtfymm?= =?us-ascii?Q?wNGZGZIUqnUTMLiOi+7hIViJQWh42f0ZXOzUw6AVEVgEw0uIZKszrr/bfdEB?= =?us-ascii?Q?Axdq6PCKUocAng6XoRcHMnYHAEca9cx9sLvlace8eZKHqlgkf/Qb5hDWaoU9?= =?us-ascii?Q?tGt3joVJh/a+XNnHw1SWMdBjXX9Eb+4SFbUBvexhJEPPb7Gwb362kEe9RJF2?= =?us-ascii?Q?jW+lRaA9tWsp7lTVrGeYbAJ6pe2F0oC5O+XqCoLjl37b4V+xe87hxXPuxLPN?= =?us-ascii?Q?twOc7gHyVwWz0s0fkXouKHeSulGF6ZDe3tS9APT0vPOZOq9Amy/nPhpBPz1l?= =?us-ascii?Q?ciDBZ5q+wexoheLai6RGnzT0hlSn/gD4rrsAK2ZCpfDOpYHFazchOE9du94z?= =?us-ascii?Q?2QQ9nhaMDUR/IHIu2v6L7kD4bJik6hRo/uMvw2a3bq3M9PmpqtAmpQhfVbXa?= =?us-ascii?Q?xjQU/uAM5ebgsdvY1sKJ0fjMx5kPGq9rpG1ecSNtvM86t8M+ZqMPXg97KtTS?= =?us-ascii?Q?tsEq86XW00mCb0zHHiVzfeG5b2z99tQ5WpgRzW7itLJ+A22VQmw06kvZOlgY?= =?us-ascii?Q?YUSHTOZCCbJHKb81yBsqCYrFY2kMse5KdaS8KaSf6Wv00Ee9vf03leO+dtRV?= =?us-ascii?Q?s0Xq0KPa7MmmZ/sux7D38EEOM7GDYqSKnl75v48++56uvM2HiApKFr8W5jW3?= =?us-ascii?Q?qgiOJX2XoTNw5qXe+hHg3Z5kjufmJtTakpOrnConv1Dbch39BC79Z+bga2vY?= =?us-ascii?Q?nKHow0qP4z8b0kGR5qR/rxykjkEdg7FS0bJ7gjUgleqj9D1TpBN4FAj8+WMz?= =?us-ascii?Q?/UWe+BafFtpeMWNwkldohlvzcITt62jbOLW/mdSSNZE5+obvVHbUFuMcO11W?= =?us-ascii?Q?2XV/hEtWcxMEMVswBkG8im0dxAm8u1eSI9VcI0VrMiP07TxJAJyVkNWXUvXA?= =?us-ascii?Q?esybPfPtJwpQuTKpLvh2MWVCdD58TT2hVeGUHtROMvUz8nHOjfwloBYSP96x?= =?us-ascii?Q?2yOLwX7cRBU0Ujm92EeYDq264ppSIoJNdUKhlksbR7Xi2xbyMohCMxy6dBTz?= =?us-ascii?Q?3+X3bZQefc8cZSEGV7qUoOIn7t6NtFwfQUC8YCFJtXq5vKIz7AIrrwWZzI/X?= =?us-ascii?Q?GWrZXOGyd7XD7g3mXAjV/bX4neUtON3uC6X+RQKuahxwTKxslcORZ46LxJ6D?= =?us-ascii?Q?93ZTp37sbPPoe9Q4Pt1Dx8YBX1TwS7FnibS1O8UrRQQFT7aFs2Ma+ptTK7Fw?= =?us-ascii?Q?nuurnseZdREZmk7Hg6owVqvClUBIBcyC83SBlnSYqAAmTMMp3nM6RULvn4Bg?= =?us-ascii?Q?o/3kX9m+Bmzr9p0j2Z1IIOrW55IMCxEMiKPU4k6UQ6azf1uvCsTW2mxJVj+S?= =?us-ascii?Q?9DevDI0xontCh/JRBj384KQ4a+RXmhNgGzdwWCNSeGmZQtjaepAO68gSH4gw?= =?us-ascii?Q?/SPLTwdLw2t0ziTMPE/ePnKtgBDo0lZX1yLy+1Gl?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a036a3f-b8ec-4c47-61a3-08dccb64b941 X-MS-Exchange-CrossTenant-AuthSource: CYXPR12MB9320.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2024 15:34:24.6311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oJ/a59SvvGqz/bCsmyJegIxo4Q1M8yJjdomCy9mlvzELO+pyo5P1mhHnuQjQdtFe X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8288 X-Rspam-User: X-Stat-Signature: 7zb6jbt9ugi76fo7nsor8x3676ik3i9h X-Rspamd-Queue-Id: 55FFB1A0014 X-Rspamd-Server: rspam11 X-HE-Tag: 1725291267-520317 X-HE-Meta: U2FsdGVkX18hMDz5/ppGRwUrCOS4cT0MfPKOgVj/oGPDOK+IZ2JlvEeyf+yeC5MNFvkCGcNhqQA7KOUh/q1U9pwKrE0OBe6JrFRqXW3AKMMVEv4udtqs4RhYNEKYV8CZ1ASz2Q/s/hxq6ExwuZea1wGBGzJVyzqFl5zFcuKioyR7ED18yH2rlUnxcKWbiJhR6yOdrprofICRcfEZXtQSGXi4Bv3oz1EsrsWkTOUfxGZjuymwer6/ltavvT//iKK4TQD52UZBNBdR7QWemDV0VE+bvrZauq6VWJ7CxYpoSuyP2RjtTnx1KgUbKadwsAHqyGjATEbY/rdwFYRwJpydfn3hBtP38PPRkL56FoTdJi/D0VSLRoL8DGdT9B6OC0b6gSxogqGqJxZNQCGFGgWCsQj1ZxEAHoPzUfwx2kOVI7TO582kxNr8BaGMYolSGD0vSDwVAuif4v9VpxljDGPNrbQTp2SzhpTiFeidcO73mAGEhjqHPzUBgh3YvW2/GsBxBqbLAe+MHVCKBoXGmH1JTasQzCu2u1Qr2/5b4nEwlRd+kbzvHncWfh/yTs3jy4xV55M/iovxS9ya4QchYGVoxwy55RLggHYncuggXJCXKacXfwHJsgjuXSaHJgT34zm4VvkJ6UqDhjkRXN1qweHWC5hIZRPDowppDLJAux7OICB8B9Nz7eMGWKxgd2sQG385Vgkw+Tkm/vunHaYMcKQsgzPPwcRTu1SZOtH66RgmhhQ1FR69dxqL04fwXgzqQx7yeXnjKVbg+fBBJLzPl1VYlr2stSqCv4Es5TEXvP4BKnFoLuJGvVVWY9TXd57UfPRNeMRLeoTi3K/LevVCs3t4WOrRP4kZZ09Uw53YFqac1vmuMLV/6ak36YJQRNRsCR4AbWjZMWKU28e9n1u8YLNKNEjeObgktxgPoap7CEVLOLJ3Jszbt8uIGuXwbX3ewALf9JuVF7OIPgmCnealJlW VHtb2Ubt krLL1D/Bb8RQBg7rNOwlj5/nxUeyJ6p8mJtBfCSkBnm4owJyG6FjF9YlyS8aw2cttJu3dhC+PAtweCOd/3W+FJETzMVqYLzmhTCPkaxI96VvsvQNPKBVTxCtL0AbqzaPzav3+MA8KDHR8TzujVjNVhIJ1mWLAFksjqiFxsHmH/tlYNJcAmB9BWP8pQJ4TVvxyAT4LBt1SUuNIs5yW4zbAvi9gMLPeaaoaTxfniucndF1gdmkDhcbPBrHtHQVXQFw4e/X6tIxrm8odn0nm5xk+clGC9UW3aEHkeNEFJBwAOqN51hpeMmP6l01Fv8IpV5vhWyR9DBWeZutrtlRJDFxilyn+SN+6/cwX3Y2xsiwpH3w9MSiMIxr+s1MJFWGxwGYXylEe7qSvUFKsq5xqM49WdpLMFAJBmVPCPl4ysfc9k3uA3MTD4TPUKmHdb4y1EWQibt/KJg0EoKlQklIQ/W5U7sbaktSxl7FXcvv0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_0345FC7D-70E7-40F1-8EBB-0DC6E361E0C6_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2 Sep 2024, at 5:06, David Hildenbrand wrote: > On 28.08.24 22:22, Zi Yan wrote: >> migratetype is no longer overwritten during pageblock isolation, >> start_isolate_page_range(), has_unmovable_pages(), and >> set_migratetype_isolate() no longer need which migratetype to restore >> during isolation failure. For has_unmoable_pages(), it needs to know i= f >> the isolation is for CMA allocation, so adding CMA_ALLOCATION to isola= tion >> flags to provide the information. >> >> Signed-off-by: Zi Yan >> --- >> include/linux/page-isolation.h | 3 ++- >> mm/memory_hotplug.c | 1 - >> mm/page_alloc.c | 4 +++- >> mm/page_isolation.c | 27 +++++++++++---------------- >> 4 files changed, 16 insertions(+), 19 deletions(-) >> >> diff --git a/include/linux/page-isolation.h b/include/linux/page-isola= tion.h >> index c2a1bd621561..e94117101b6c 100644 >> --- a/include/linux/page-isolation.h >> +++ b/include/linux/page-isolation.h >> @@ -32,13 +32,14 @@ static inline bool is_migrate_isolate(int migratet= ype) >> #define MEMORY_OFFLINE 0x1 >> #define REPORT_FAILURE 0x2 >> +#define CMA_ALLOCATION 0x4 >> void set_pageblock_migratetype(struct page *page, int migratetype);= >> bool move_freepages_block_isolate(struct zone *zone, struct page *p= age); >> int start_isolate_page_range(unsigned long start_pfn, unsigned long= end_pfn, >> - int migratetype, int flags, gfp_t gfp_flags); >> + int flags, gfp_t gfp_flags); >> void undo_isolate_page_range(unsigned long start_pfn, unsigned long= end_pfn); >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 4265272faf4c..fe0b71e0f307 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1993,7 +1993,6 @@ int offline_pages(unsigned long start_pfn, unsig= ned long nr_pages, >> /* set above range as isolated */ >> ret =3D start_isolate_page_range(start_pfn, end_pfn, >> - MIGRATE_MOVABLE, >> MEMORY_OFFLINE | REPORT_FAILURE, >> GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL); >> if (ret) { >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 4d06932ba69a..c60bb95d7e65 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -6607,7 +6607,9 @@ int alloc_contig_range_noprof(unsigned long star= t, unsigned long end, >> * put back to page allocator so that buddy can use them. >> */ >> - ret =3D start_isolate_page_range(start, end, migratetype, 0, gfp_ma= sk); >> + ret =3D start_isolate_page_range(start, end, >> + migratetype =3D=3D MIGRATE_CMA ? CMA_ALLOCATION : 0, > > Can we have flags for alloc_contig_range() instead of passing in a (wei= rd) migratetype? > > Then, we should make sure that we warn if we try a CMA allocation on an= y pageblock that is not of type CMA. Sure. I will expose the existing isolation flags (MEMORY_OFFLINE, REPORT_= FAILURE, and CMA_ALLOCATION) as alloc_contig_range() parameter to replace migratet= ype one. > > I'm trying to remember what happens if we try offlining a memory region= that is of type MIGRATE_CMA right now ... I remember that we fail it. We= should make sure that is still the case, otherwise we could seriously br= eak something. Yes, that fails. That is why I added CMA_ALLOCATION, which is used in has_unmovable_pages() for this situation. -- Best Regards, Yan, Zi --=_MailMate_0345FC7D-70E7-40F1-8EBB-0DC6E361E0C6_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmbV2v4PHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhUFGwP/3FjAEde+wl8QXit+oSkk7U2tbktuiMmeSKi ytcuFK9hWhVb4aTyRSP4tBuwsjIK7ZnhSEgrdPQqVa9GNVe9Ggdx/KSbFsLtfAvn 2ozTfGWE/vXQi9sjyst4DrkwT/0f1XuXndyVqfOAjZyXEMML6RTuXvx9fXjC8CpM VbvNX4Ba4vFYHrLA0FJvRi2j+9gQlpvIT3watZe3htMMu8HsLhEG0svK14uFoKBJ kcOAYf8FBhgz/tOjSmgcTyTm3gHF0AKMR458M0Z+GPxUE+1OwcFqmfxHIgb321De JlKr3TJ/zCponL03fZ4YBZy6Cdnd7MjW2tM2u+PFccAT6g+Fhoq1zturZvPnn+SZ BmQEBO74CyUsHqV6ys9WE82FLPvFh+DKD27BX8uN+q66K+FeDBWtAe9bwX6kGOCv JcCBz2+1o6pEOMZTdqN20KO8Uwz1vye2qWJob0b70tNeaA6cNTiPXX48rDmvHep3 Oh5BLfpQJwWNjqZZHP+6fIkgpbCHnyXD1NHDNswJGw4vUz1iJ7hRlfvLidXT8V1G zz3+EAn2W/xIgUWSgdV1AR9/maBFsD4mVjxmggyLwEDmYrBMzusxkGudSn6w1Mx3 jgyVrOLLNQx592KiyFoTxgcb1ABg1u/iKLPNPU/kulbqVALyF1CePbUCCfAek00Y QEN/xCqh =8G/V -----END PGP SIGNATURE----- --=_MailMate_0345FC7D-70E7-40F1-8EBB-0DC6E361E0C6_=--