From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744C6C61CE8 for ; Mon, 9 Jun 2025 19:31:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE0706B008A; Mon, 9 Jun 2025 15:31:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E90926B008C; Mon, 9 Jun 2025 15:31:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA7A86B0092; Mon, 9 Jun 2025 15:31:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BA5F96B008A for ; Mon, 9 Jun 2025 15:31:49 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 68F6E5D982 for ; Mon, 9 Jun 2025 19:31:49 +0000 (UTC) X-FDA: 83536857138.26.49585D4 Received: from relay.hostedemail.com (unirelay08 [10.200.18.71]) by imf05.hostedemail.com (Postfix) with ESMTP id B1ABC10000B for ; Mon, 9 Jun 2025 19:31:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749497507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Y8bkcAq5McLJfNA/dpEXN9x+C35nA7W0LC1z+syPSk=; b=XqWV1RF9UplS5vV8VNU4/5Uijw71EqyaeabVwPJREwRZsuX50g6WPW6mZFI4ohLv+ac92o suSEX+HGzAmCpdus63cjkg5btz8wHqTxtUF1QJzscHq/bfREC9SHWILozAEqAQp465u6W/ NihX/3TCRA1vdw41BO/dxW5OjpLWeaA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749497507; a=rsa-sha256; cv=none; b=kzWg2qt8WWlEhuYbsy4fUVU3Ay79oE7Df3KoJP/ShatnFF4NhP6NvmYnicW0eGIx/WJcJ1 JSwYBi7mXlEu54n+PEn42jL1jZel7JZdlNvpEkiZZP9ph9128h2sQH97EXDGwKbvK18KBN tqrMqnO9qio98w6sQQRc2+EipRV+77I= Received: from omf08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 40A8C140DE8; Mon, 9 Jun 2025 19:31:45 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf08.hostedemail.com (Postfix) with ESMTPA id 8FFCB20026; Mon, 9 Jun 2025 19:31:41 +0000 (UTC) Date: Mon, 09 Jun 2025 15:31:40 -0400 From: Steven Rostedt To: Matthew Wilcox , Shivank Garg CC: mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, david@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org Subject: =?US-ASCII?Q?Re=3A_=5BRFC=5D_mm=3A_use_folio=5Fexpected=5Fref=5F?= =?US-ASCII?Q?count=28=29_helper_for_reference_counting?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20250609170806.447302-2-shivankg@amd.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19HlEqgydZliZ8V0YNuMnhWSh7O6b/U0aA= X-HE-Meta: U2FsdGVkX1/wC+xwbUOOM6hNfAHr04ILxemjqYQqRFOaP9s3RuV+XeQnii1TH9EoSlsiV0eE2XaJWkXaCx04RgCHotQSITVJmr8E2Tvn22KyKM+TkcDvfswfx6T4mqxJ8DidG61rKzGIK9mX+f2cdvL3F/VP1ZgohuJOa+v4TnOigXaWYy6qC/A7aagwVcBpABZfr/Hca8GFu/r9NMkuVNANzreAeV40rL/A60osAim8y9w1LeIB0T4w+qp4ECBGwr65EakSsMVojpFBiaNXy08N9vYv+/bPWbn7kn3BvRqDOcskCb6hKQ6NA+qSROImAEI2RG6zI2P/yo/ANJBPiBLIkhGbs7OVW4JRPrAF0DAQQsuIjCuQeBnBIUY37/zdYXGWGHTkGDM+wSfduXXBY7klRD4PzWh5z/7oAKkTc6o= X-HE-Tag-Orig: 1749497501-489981 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B1ABC10000B X-Stat-Signature: k9yoy8kk4pct4cgbm3pm7m16jbrdwpgr X-Rspam-User: X-HE-Tag: 1749497507-188462 X-HE-Meta: U2FsdGVkX1/c9EYS0LPItR9+AMTyuBK7bDLh1JbemxQGl2E2ZZWhEMCw+anGuxII31HuTghYqYkf/sQaU9RCMQlIfXWfU8JHp1uM+vF2X1AdoDrkn/1izaD5zHXLpwY4w2HP4l5nliWDGwbqbIk7YYP2+AtXmaFdZR5iuvfDG+K08qTcClb7DpAY+tYAmlKnq/Ht5lROToVpDwpHzf5Vg5VxP2eCBn4hKJT8wCgVLUtQD5c50clZNe/z2oV10QcQmaTu4kIm/6GS78y9ZDkIbVDEi3LXJJ9E/Z++6Pz2CQpUgRgDcw7EbJY62j0a67JPREhCj+vf9gtpaG3pBQQIkKNzA/F4zVqXdhXcwiJM21oWo7ptb6Y65Uc5MgNgk37kXQD6nFjfIplmKjT0AGBT/SCkDb7ERkIDcNGlQxZI3oax2prB6iWXyBajd5tlkz450A4hME3oNi38UWPhGNJO9AIWkwanOtVTqLjoZnXX8hmk5TYFGON8NNDoZwokZXsCzGcE+H6A17QYGfRsADK/pQyG7yRLzIO7Sdmp5S7BIHiCKvvix3BrhvPvCvUsx0gIN/I52r1z/HEBP/JjwPERnmc1Zp6S+Qgm6jgL+e7KjcnnwRTwzd5o4znkbVbJu36DCX9ttVwGiFmZlrpHc7qbAC3t84CsldU5z64EkrzmvNHlYRRiuAzB9bXf3V/mvfYwC7Jh70t+/G3upBO3zutnDvEcbncEJ5WYIMybZtq2FaemeGuR3DIEJJqpuBUzqC8u1widtwdLUgOiK2B4LmApXCHUGdeVlQ81DISQwuA3PluHaErE/MLEGtMyHh1wZhCMvSArTzy86IvYuP1Lzs4heBtWtbW7B/3usF/1AH1spw5AqKSe4fybU2HOH2c8PC9RfmvgvvCHYCixMfPMPGnis2X0Y4bh66H35zN9VOeSUqL9TJwdNlgb7K00nGjpuHvFC3sYnKO7nrC68Es+8K7 U2GHD8/0 MsCrJ38Zmjv79nghAazwo0iCy++Vzz++WoWJjCh6nOJFsTY/YifRlYrt2IHgcSYR7dV8XYShrF6gWVdptJFeMEokd5oVuBcpmhkSgC2ZovDSsfJmfdtWeSjlLSBOFoKbFqJKq1KeS9IoJICQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On June 9, 2025 3:21:20 PM EDT, Matthew Wilcox wro= te: >On Mon, Jun 09, 2025 at 05:08:07PM +0000, Shivank Garg wrote: >> Replace open-coded folio reference count calculations with the >> folio_expected_ref_count() helper to improve code maintainability >> and reduce duplication=2E > >If it needs this much additional commentary, perhaps it's not actually >clearer? I don't know=2E I tend to over explain as I rather make it totally obvious= what is happening=2E I wouldn't say excessive commentary is necessarily a = sign that it's not clearer=2E Not knowing the code, the explanation makes sense to me=2E -- Steve=20