From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361CCD729E7 for ; Fri, 29 Nov 2024 16:15:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9C746B0083; Fri, 29 Nov 2024 11:15:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B265E6B0085; Fri, 29 Nov 2024 11:15:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 977AC6B0088; Fri, 29 Nov 2024 11:15:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7607B6B0083 for ; Fri, 29 Nov 2024 11:15:00 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 250031613AB for ; Fri, 29 Nov 2024 16:15:00 +0000 (UTC) X-FDA: 82839631476.14.7B62FDD Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60]) by imf26.hostedemail.com (Postfix) with ESMTP id E7B35140019 for ; Fri, 29 Nov 2024 16:14:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=r56W6ef+; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf26.hostedemail.com: domain of ziy@nvidia.com designates 40.107.223.60 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732896893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wAroAiL2OUtwa4zQofnrVJYgOeaBrET4WYvBEr26XAo=; b=VJoQLM6dlGtBdUuUfakZ5tckalnIaWkgSVIgjdb+IW8qKwRF4M9LApV+lCyadP478x/rNE lDLO1LScBhMwM9MtG9ARiNqZk29r3hUdXcIL69JMHbkay2WMmHuLCWukGL+4saRNDJv9bo HoVg2YeohY1ljdRx1zZCpi6n37C9JjQ= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1732896893; a=rsa-sha256; cv=pass; b=IOJyV7d2UIMnMTkU3E5viq9JoIHu/NJ0/rrzLwOf77kjqXBb9BG6QYBimq9/Mndz/w/VAe cXmbLxycW6c0zt842PX0iyDy2pWD4PMu/TBvTRJX3KF7AaPyB0uGTYgbrvK73mf95KMzaZ YpznQ+9bw8BeOXQjGNm9lES2Wl/L508= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=r56W6ef+; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf26.hostedemail.com: domain of ziy@nvidia.com designates 40.107.223.60 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zPvZ66GQ4zFaivbOdA3PwNNPZDYYAE75OrlSlBJXqdcG1jgdFa8R98rQqmera1BjoSnkMqNUaWYc/AKiMvJjxqw2N0x3ENlhem9OQKOmtK1ABDlTIBwP19UftKZszPW9v0iYgVcd4knyaU7bHf+Vhw6DTg7vwcacaK8Cr8z2GLK8d7+zJtgiI4PSGz6dmEzUDc36yzgtjLH8zYP+6IZR5F2dNGzf2spcMFmllWh+4Rvm9IIZH4m3AEgcykXLZIXo+dcYLeVvScPLr3hce72DHX9aCnDCOkpuZixTbjKzTxKkxdtdLOwgg1QJUg29Y1yxMPN2ByzdgCLpcZ1Z1KaYrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wAroAiL2OUtwa4zQofnrVJYgOeaBrET4WYvBEr26XAo=; b=wV/vCRTHSpYbSdPogfdHMrFWaPnJUkjAK5GaZYBp6n5iCMbwB3qnUScJ24SIZFwa1cGMcbxrvHidyvPFzJyT8FOHFqgmvIcZDAXVxf1iBFOg3i5oo5MtS9p2EOQZ5Rv7cHtoyR+jRQFAehsxBlAW87vaZ+xRT6FRM2IdKB+PxbJhbnhM2VVbTerRu16lMQAm8CqtV9RDVsNkMfS3Z4xDZ0K+6KVuJtj+917L2RiDihhK3nG+TrnCrDJcdbAuphrfkCj7f9TnTSh5BVpC15yWKAKSWvKauz/d8sCpxTKAXNl9GirdLQxxsk/YZEDvxt6BFjpkRVq17nClb7wWw4lC/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wAroAiL2OUtwa4zQofnrVJYgOeaBrET4WYvBEr26XAo=; b=r56W6ef+NmwGycoIR04+lKmKylfM5szo2ydIWbxlIqc+flsU1VCB4xmamwvqT9aCTddzngNav0vn/7NYb++TpI9ovBJrMIwjrZSA2XCDxFvv1lxS39pGWUzqhgYKiIRp52O+zHn5VPp1unUNsUXwbi+WzoOuUpWkb2EC0jMnK194GRL7M6PO7RihAyhGS2qQrY2BhpPOX1URnxMTfHhrMJNRPKD8CBhFEd4pGDHscZiJ0y9imy21yBLDAWvkKdfICZ7x2aNC9G/lRhYEPzSIrZ6hHTqJ1XKU4M0EUncpTvYJDMf9Y9KkJrAjW4UpAZ8b2DZowBEg4mXv4A4Zh5wzOA== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by PH7PR12MB6977.namprd12.prod.outlook.com (2603:10b6:510:1b7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.14; Fri, 29 Nov 2024 16:14:53 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%7]) with mapi id 15.20.8207.010; Fri, 29 Nov 2024 16:14:52 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, David Hildenbrand Subject: Re: [PATCH v3 12/15] mm/page_alloc: Move set_page_refcounted() to end of __alloc_pages() Date: Fri, 29 Nov 2024 11:14:50 -0500 X-Mailer: MailMate (1.14r6065) Message-ID: In-Reply-To: <20241125210149.2976098-13-willy@infradead.org> References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-13-willy@infradead.org> Content-Type: text/plain X-ClientProxiedBy: BLAP220CA0019.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::24) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|PH7PR12MB6977:EE_ X-MS-Office365-Filtering-Correlation-Id: f9714691-a7f1-4eb0-9aad-08dd1090f47d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?b7esRgiVYgAM/LWT0CRE5drHymC6rF4M/OPiloZlE7yHVddv/5Y09eWR8joA?= =?us-ascii?Q?jgxZmtN/qFA6cdralnS9plS9rGHG/Z9OqKEwz8jK3FbAGwRpBdmfIOEFahpc?= =?us-ascii?Q?DQMzAc3dMMlV6WyLsXyUnJ870Co7vBOYPHbnU2XTpYzE+lWN9vbGLoVF+cff?= =?us-ascii?Q?lfZVWGx5UKBUj2L/2mb90v0pt707UQWSgZ2fkn+P9/ihoSAzDhESgbBNx+T8?= =?us-ascii?Q?9toRFYUtksiRRWbfOBqCdek+yfLDz/A0WFNaof29MpBKRQ+V4+idCweblWNy?= =?us-ascii?Q?Ed93SUyR9KlxTyb6eTqs35Rzxc2uQ35OfpmZ1xuETSCzyZo+BMrvQVzLaKGi?= =?us-ascii?Q?ycSGWh0foL3VJjcaE2O4CUa2QbWjDgyqB8QsM7LSXe5/AydrPtpxFvro6wl6?= =?us-ascii?Q?C1R1MDDpx+H3gwSvJfYg5yAbWgILTbCnNUsEZsovRubU5foHQlSg55kPezhW?= =?us-ascii?Q?iWVwgnLq4iSc8rPo+ecigayeTqW3K+PzE6cVzQFztZ3ub2vxA/uYh+sIG9Z1?= =?us-ascii?Q?0HSk5HKLRkS3SVzgxOF99pJNsZvZ+FTvou+jkiiM8UpLJMwA2dheZC/2MAqQ?= =?us-ascii?Q?XVyYWZq6Y0WsH8+o2gsXZFLSPE/VxOfj1pJmn3uXRvMLNbjhQecRzdPEVThE?= =?us-ascii?Q?MddhiTpa/q5CUPJQFFKthtgBOvT+nBt0eh/duc/Ujlaa6yxNslZ/l8AAkHXs?= =?us-ascii?Q?hDk2Q5+IMEsvHWY9h21371DiGr6Sqqy61T7xFTPN2eCcHN454mUhPjTSWBb0?= =?us-ascii?Q?VjU6ZkiePy+7bHclDVi3ir/+HgLEpWylV/Wf1a7uTPnpek0kWdsr9Mf5EKbU?= =?us-ascii?Q?WzFWQn83nUmqLDg7UM3qTBJ8CxPdkraQ7vaDNvgo7d911A+XvkwvAZD+ODMt?= =?us-ascii?Q?xTLEFJiUzgMxqk36t42u3bDG1vJoyIjF+FupB0InxLzNa+KHO8n8B22SHA34?= =?us-ascii?Q?QOeE/XTgeuxkp6PjfcjMg0vkKa7ur0PdUn0NsZEaKmeRX/PF86XEVDTufcZm?= =?us-ascii?Q?uw2cvzLRDstCEf8LTcPQ6dJXMjgg+vtkHfV8YmJyawtIF6RMC6ZF2EcEuQXS?= =?us-ascii?Q?rSenKVDVmizzhC2YnhO9DyHgvT7vHmsod8jt+kuzc1DyTmnPGiverGh6qkJF?= =?us-ascii?Q?1SGDHTNhxWk6Bice1CkAjeVKor1HiiX29TMQEN4uZ0Y+KH8HgOuwtzw/2im2?= =?us-ascii?Q?lZlMTY691fq398fBHTfvhYIG7v8QbJ6gv1z6q6a6IEPkj6bcQDlds590515q?= =?us-ascii?Q?AXegTvG6pcOYqEcuJfa20j+aJlZm373KLMArQXJS/U1Z7nIxWc5rz86ow0gp?= =?us-ascii?Q?ShbNGiUAElIoerQMau+MmP1oQUh1MI7JXN+l7OFdzG7bWQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yuh96K6AKnw2X0e1U5RCVjI6QB9pXEYXHbb99+SPLYacPOtXre4d6C2PQyqL?= =?us-ascii?Q?VeuZF8ux8nUz4a2XiXhOJjC2wVKTkPeAUEHbucTEXEhe1VJEmVIBQZsvdQjo?= =?us-ascii?Q?ClZ7CS20y/H2gPMsYEzbTVaC2jrDCkjH+Didn4tpy0iBXGRGwPGLEZQqQfNf?= =?us-ascii?Q?jpOG+5dxiuG9J561VhP8n5UVaJdptvsRqiyzXBaXvKR+FzrlyVv3/FldSRw4?= =?us-ascii?Q?LEUyO+0QtZyYoXsolfU3zobSeF0ihmDO9uqRSsBxt4GNM7rFkMmz4H4Vqoxl?= =?us-ascii?Q?i0lghKbxrtcdWkXSppFWwa6vJD5+LKOtVF57cVUr1G/hn+WGuDSuEOCVOeOi?= =?us-ascii?Q?1eVMIrmLvj7ysHJrTKBEmv9CbWrJgjXcajVvkogk/XjTVrB/Zqn/au7BsoK5?= =?us-ascii?Q?uko6s1cS/se49UWfqrnan8Z8U/wWr2BcrxQx+ylORqGYl6ha/6GI94UJd//g?= =?us-ascii?Q?dac6AuDr0wHnCEZRuUbma+90t1US0o7FLHpRbsIFlTcGObtic/3hZuCMNq3V?= =?us-ascii?Q?P9Ppywy+KGQUVV78HbW5dDvBSXvUrnVoqUj0qmzcemBqF9/P4S/Zx3o3RYez?= =?us-ascii?Q?8fiQ+3ErjyJQClB1V7gkhqCCpTE6te0f1ZQHK/kqnPrGFK1DQWFOsN5BflOe?= =?us-ascii?Q?qgFVcLpnxyMlX53rtWRCQe4KeqiCea5qwO881OwV1Wr9PicNmswTEcPipykB?= =?us-ascii?Q?Rn2gRicMgkQO9yNrdTkUv9C6Rgt/kQtMLkOaLlZOH9CLrjHArxFSe0bdR5d0?= =?us-ascii?Q?n97G8Q2g1glMp6Ay3/BY9Ja3gAXIhauFnwamWrK4pTtBUZHpGVqwHPW3oBIZ?= =?us-ascii?Q?oNHJ1rYqugj2uGgRpJ9bjjcYWkZU7qVTnmaMiPcEYFJdeTqLbBIoeNCX09hK?= =?us-ascii?Q?/2WCI4RJjYfHtxQBP0d7Hr1rLTNY3vg1fg+trSMy2JdCYXEqMowmAHgaxuoe?= =?us-ascii?Q?FP4+F7nErBS5Q191SXKCkm52fpkjR1bOdINkyNazTg056THzrzNYDQUY5/Pb?= =?us-ascii?Q?MSbOwvzMpVVSnQbHbz03+5gHvPMT4/VhSkqiFiW0fmrcLaLHGlt5Xz89khuw?= =?us-ascii?Q?gJuL2kUMQD21hvkPJ43/VObeZJs6oo/wjMTV/pFoeWdkAcs1OdBhF5jCCo0/?= =?us-ascii?Q?2aRlPKXD+odc3wa3fceuOIB3BuIn/uIRFHTM/VRQHM0+YLadVKufEdgN7qpQ?= =?us-ascii?Q?TCgKj0fljgHEoCB1CUY5quib3OaDYIr6V3xA5CVXw+tYfMYz+WXSrL7pNjYV?= =?us-ascii?Q?4/Am5rJPktHVBGO90DT4KcHJOndXIHz+DmHPhYRpNnr04zN8Em1vv6y+fcmU?= =?us-ascii?Q?aODP+g2mEeaaoq4YuOsAB8j1+wBulkpeUiq2BeqwJsqRjssZd+3fgIQN7ghv?= =?us-ascii?Q?YFZzDdOd26pDV/jJnli8toAf5+gGPuElTxpXmxJ5okhr3cqcA8jfvLgBy8m5?= =?us-ascii?Q?c1eywmDFj8box7MRXajMEx3Ci7FZz9cZeeEmZtQbiPI0rV0rBSGVHS8D1TJT?= =?us-ascii?Q?VuQgGDhUztPFH0S0RgHvwoQDHMktoUpMzKBwqkJ4D4y7B1VoHNtoSJSgEIkT?= =?us-ascii?Q?th3g0hRVeJkeEOhJWMalBs0QK6sxNBL1fmAjmV2g?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9714691-a7f1-4eb0-9aad-08dd1090f47d X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2024 16:14:52.0715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hUWknQ56Qo3o4EeAxIIWWyDXfUoVluyUet/PjyzXF38irU2M09i84e/SckL5nWTO X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6977 X-Stat-Signature: ns1dpqcr9khqjrt1nthxyqhe7y95yw1e X-Rspamd-Queue-Id: E7B35140019 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1732896890-934353 X-HE-Meta: U2FsdGVkX18JG4QvsLlctUs/9ZXo+mNOtAzYba2vRPH+8mOYiBT+pQ9hi+1n+lpthjazmC1kiXIGHugAf8Zq208pSaadzEg2niUK1qpSyeaQdHqyYgDIzKx9/+xnpe5Cc/Cwk6LyaIwysJepY4wztApg7Jq5UTt4aJwVvLnOA9Ke9zBbJIpAwyjuO6lj80/coI9BxX/3kwANmUUqwMG5jwGXDMcn2uMlKF3lPwwhDN4uzJ+rEgTK54ChpaR0b5NEA3R3LSsaOowr89qgSllJ2ggDcg/a/05Pc5B9o8fRJPcAa38sN6+ybUx5jc0pj9+t01W0VPHEOtpNpfdK9wrm3wYe8IrIk97hT3gPo6Ro+CblO+el2Pt5XzpApCtIb/Mgn4xUILMDGu0czAF4fcjCghM2QU0NepmBZjrW6OoAgWlIdvJ2QoSZg9Pom04ELPnh62MV+0zAa6W1DX6DbyCVYgW+i2/KyKB3TV7LD6Ndwhdjk8XUXKbeTeNIrP4an3jxSHn0Fm9l8gqz2selJ5joaoC7QxWAXl1eTScSn67/gvjGYuotU5TuoBIhJ039p3F/WloZEOYu2G2BPC5MD89/HOHgx87ME+bIt5jgvuY45MOnkfMr/dsZY75U+LV/sxbeBmVRuV4nCKhiJF2sr8rS2S7hStT5vMCWpEhEpjyaTc4SnWTi66nuvFB21iWHc0k86WErUVUC37kmwMX7DbAopZdDN6Q0w6SQb0gXePQtF9t3RDe7/Lc6iWBMJifKTQ5rUaz4rQY/f5JFmNClPnVrAVW1RgAYtaDDxtSbq81v6kO1wFn3OZKa3hneqku4w7hZWsLUCr4xo39js4eHy6MSa7uP6CcZfoUuMGLNa9mGMkxjXYbGU16pKlOCyEy98iJCb93Wvz1EReHKZTCV/DYWvyzstUBNCD+6YuBhXwyx6a8Jxdd/guhOjPYspAUsyEdMqX/S7VjAfjPV1zhsedJ b3ISsgZY 93z8f0j/YwvFAuK8iuub33kLb6f6CAhFUsLvD03EyilF4eYsM8+CVIGTXnKpepErsBWCK/mAbDfRRGLb5UOUlNfS1B3LgAKX8i1kTZtDEmmZLgrmYYj9tmHlN+TJgLhGOm9yEbYKDaO9+945FfQ6jmBqFOIVo7aK49hKP7/LqZHh3c86QMp6LLFCa1S7zdUvpFXnK1K1/+nxfRLE10vUm0/c97Ezj60jLuHxyevievrC7cni4NfPxM1npC9x3/dTnjibcwGcwQctBMLNKDhmpbpaCg+lyjSss+4RpLijWdJkToWaPfNtYyqyZ9saSdhcL3ARoPVoAIMs0NxVgolU0FQasVShStVl7Y8Cb6C3nkjpPvQ5d+DH+469aXRZGV706JR2JmrODTZe9R8C+Y2TXVU9NyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25 Nov 2024, at 16:01, Matthew Wilcox (Oracle) wrote: > Remove some code duplication by calling set_page_refcounted() at the > end of __alloc_pages() instead of after each call that can allocate > a page. That means that we free a frozen page if we've exceeded the > allowed memcg memory. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/page_alloc.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > Reviewed-by: Zi Yan -- Best Regards, Yan, Zi