From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B651E6C5F7 for ; Tue, 3 Dec 2024 03:40:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49A5E6B007B; Mon, 2 Dec 2024 22:40:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44A476B0083; Mon, 2 Dec 2024 22:40:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 311DC6B0085; Mon, 2 Dec 2024 22:40:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 145076B007B for ; Mon, 2 Dec 2024 22:40:47 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BE4A580588 for ; Tue, 3 Dec 2024 03:40:46 +0000 (UTC) X-FDA: 82852245588.13.DDE8F9D Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf30.hostedemail.com (Postfix) with ESMTP id BBC868000A for ; Tue, 3 Dec 2024 03:40:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DgrsME63; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733197231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pB9N0oTEw/DnxiAWtntc/2kC5CGpi8RLUNimhvYmgPE=; b=NB60OLhnFK+viEH/pLoz5lGUNllJ65HAOODrSeon+0VORDGLWvl9CLUFRBwAT9GULgLiW6 he7Z/P3Jt1dDRLJjIAJdThQxPLfE4khGMURBeDg9CS66CPAHR9uRyha0uP3l+0ZLoV58Sx bAZuO2PXtBkcGIvWsP8ccpitLtQl1RI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DgrsME63; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733197231; a=rsa-sha256; cv=none; b=b8FEXhhjsBWnYQo4CU82V1tL/eBJtr0KBUu2sbCLQsjAUgAf6Yx2tyvmYts1PTh++/pNRk aK8lx/zp9TezWmtRkJ8hGZ99fwVHz6TnIT2sNrCZr7oR+LTfCHArTosnj2n1bhNNJMBP8v 05Gvf3jGCpBwzmt1+UibfvU81rojSnM= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733197242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pB9N0oTEw/DnxiAWtntc/2kC5CGpi8RLUNimhvYmgPE=; b=DgrsME63hX8GcbOf0vPYiRsr6pIvtwNfAJ9uXv2jfBkPzXNOmVvxOHgk65PhIMPNT9nfPc e3mtSF52/kxs+kCvc3cxJ9B59o7AY6d2UDL2RHa0rmGbFy2GH0Vezen4klxTEk+kxuGosz qWoTTHDZtSdb5DCHF25hEmXxNnX/9js= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [PATCH v2] list_lru: expand list_lru_add() docs with info about sublists X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20241129-list_lru_memcg_docs-v2-1-e285ff1c481b@google.com> Date: Tue, 3 Dec 2024 11:40:19 +0800 Cc: Dave Chinner , Andrew Morton , Matthew Wilcox , Johannes Weiner , Nhat Pham , Qi Zheng , Roman Gushchin , Michal Hocko , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Chinner Content-Transfer-Encoding: 7bit Message-Id: References: <20241129-list_lru_memcg_docs-v2-1-e285ff1c481b@google.com> To: Alice Ryhl X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BBC868000A X-Rspam-User: X-Stat-Signature: xz7zjkptqke3msipfbmu96swc71fq3yh X-HE-Tag: 1733197220-82094 X-HE-Meta: U2FsdGVkX1++BjLjF/V3FYNZ3PGZMrVxnzmLNWBtg9qnpUyqCpxEm6XO7oeMXBiZv0nv05onkI+I6oKSSW2NrSrncxf6Vut6firo6RBAUk5f7SfkffhxE5/OPGMUKVdnG0O6ar+rO2QM0/I5tvdSIZfJ4fLkT9TYJRFyma0NUR2m6IGzbrVKyJQc1WdYeTQuD3Za4zmU8GZI4qnm9DVgX3ozSOEeObBunqLDA6w0AnrlvKp2DISXv2F1AKu2Cb/LbBUO3NfAuVuUA6cn7nYCc9XScUEshIq9DiAtvfX1/3+UdcJoTjuuaMpF9sze4OXqL90LUFYteYZ2UBlXit5qs2hwtfQ5suvl1/TqU8tkqWpLZbUTZEJ8MhWOd/lvlxWFC1xnQwsF2y033f013jtpAt1FMnJwkQ/a6FZSuDo4pfWJNGiRDRE4BND7qS4nvQb3OptWXgRLCBt40oiv50KdHEhjEQV4RWapYwe3kxfxig8WTCrnVXJDjkWPlQw3fnbdD4k3nTjGt8XAWZYFJoTKWCco/Ii+HJrB7BRZkgysCmqwqRgH6Q0jNjJ+bydyHqgzur1kz78qqdFQqdYE2DlOJhUOLxV+U/RukUo5Znba7SUJTn9qAYwgj0yVVQYUL9MUNz6g/PsAR6vKr3SyXBaQE/FKJ2AWEY1J8rvgnlbLNfCcawH5xjXOMj6K5YCINM55Uvgjo7gOBMSfHrTCto6Mo6ts+cdAV/B3dLBGuKrqmphQarjU49+5/4X5ZgM7gHKTmDzrueSzOXC9MaO/dkfsPESTOMeaZJ8QUDBCT0nYbvaOTiBbEx7N2VfWEwWWpIgi7Y/j9SI8thBufpBbilRGKaicRiG3XGxjkOLmMG/oZTVzSAy7SBDKCNIUNvJDW+/byDTcBcFabMfXkfMF0iiES1PjL3XT1PfRut7YumTbzlW76QUfcLior9fbPk1nl+A+OykGwkwAqJ5yN8fbt4v Kl7gXdt9 wo3YIOjIc4w6/0SUGJ2J9Rl5dQxY3K0QobnU9AVhqH9HbrZkGW6t1582rkqfyQodeQH5hDaw0b18LlwT1LparQOHRKoYp3lcHYAOFH+gmoc5EsfAuAkvRt72y48vgvnom6+hByfmMAtHO3OBFvjJI0+1s8uUnTnlOBMavqgNkEbnQJcHBRoEtqNhDth6sdV+5QUd5Ubpj0YdWakvzq/WBGUFbI8WmU65UnoUPcSYrObkrjv1QoyWGsbI1zMwTVXGOu1sd47n6LsigvhE3yHRSvG+cXd6iEvUUH+0b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Nov 29, 2024, at 22:58, Alice Ryhl wrote: > > The documentation for list_lru_add() and list_lru_del() has not been > updated since lru lists were originally introduced by commit > a38e40824844 ("list: add a new LRU list type"). Back then, list_lru > stored all of the items in a single list, but the implementation has > since been expanded to use many sublists internally. > > Thus, update the docs to mention that the requirements about not using > the item with several lists at the same time also applies not using > different sublists. Also mention that list_lru items are reparented when > the memcg is deleted as discussed on the LKML [1]. > > Also fix incorrect use of 'Return value:' which should be 'Return:'. > > Link: https://lore.kernel.org/all/Z0eXrllVhRI9Ag5b@dread.disaster.area/ [1] > Reviewed-by: Dave Chinner > Signed-off-by: Alice Ryhl Acked-by: Muchun Song Thanks.