linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: npiggin@suse.de
Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, jack@suse.cz,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [rfc][patch 2/3] fs: make use of new helper functions
Date: Mon, 06 Jul 2009 20:05:07 +0200	[thread overview]
Message-ID: <E1MNsYt-0002N5-KE@pomaz-ex.szeredi.hu> (raw)
In-Reply-To: <20090706165522.GR2714@wotan.suse.de> (message from Nick Piggin on Mon, 6 Jul 2009 18:55:22 +0200)

On Mon, 6 Jul 2009, Nick Piggin wrote:
> Update some fs code to make use of new helper functions introduced
> in the previous patch. Should be no significant change in behaviour
> (except CIFS now calls send_sig under i_lock, via inode_truncate_ok).

ACK for the fuse parts.

I think even the "if (newsize < oldsize)" conditionals could be
removed before calling truncate_pagecache() as that check is performed
inside truncate_pagecache().

Thanks,
Miklos

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-07-06 17:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06 16:54 [rfc][patch 1/3] fs: new truncate sequence Nick Piggin
2009-07-06 16:55 ` [rfc][patch 2/3] fs: make use of new helper functions Nick Piggin
2009-07-06 17:23   ` Christoph Hellwig
2009-07-06 17:47     ` Nick Piggin
2009-07-06 18:05   ` Miklos Szeredi [this message]
2009-07-06 16:56 ` [rfc][patch 3/3] fs: convert ext2,tmpfs to new truncate Nick Piggin
2009-07-06 17:28   ` Christoph Hellwig
2009-07-06 17:59     ` Nick Piggin
2009-07-07  9:17     ` Nick Piggin
2009-07-07 11:45   ` Boaz Harrosh
2009-07-07 13:30     ` Nick Piggin
2009-07-06 17:22 ` [rfc][patch 1/3] fs: new truncate sequence Christoph Hellwig
2009-07-06 17:47   ` Nick Piggin
2009-07-07  7:29     ` Peter Zijlstra
2009-07-07  8:48       ` Nick Piggin
2009-07-06 18:00 ` Miklos Szeredi
2009-07-06 18:10   ` Nick Piggin
2009-07-07 11:45 ` Boaz Harrosh
2009-08-15 14:51 ` Christoph Hellwig
2009-08-15 15:14   ` Nick Piggin
2009-08-15 15:18     ` Christoph Hellwig
2009-08-15 15:36       ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1MNsYt-0002N5-KE@pomaz-ex.szeredi.hu \
    --to=miklos@szeredi.hu \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox