From: Miklos Szeredi <miklos@szeredi.hu>
To: linux-mm@kvack.org
Cc: cl@linux-foundation.org, penberg@cs.helsinki.fi,
david@fromorbit.com, peterz@infradead.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH] slab: __GFP_NOWARN not being propagated from mempool_alloc()
Date: Mon, 24 Nov 2008 22:53:19 +0100 [thread overview]
Message-ID: <E1L4jMt-0006OW-5J@pomaz-ex.szeredi.hu> (raw)
We see page allocation failure warnings on the mempool_alloc() path.
See this lkml posting for example:
http://lkml.org/lkml/2008/10/27/100
The cause is that on NUMA, alloc_slabmgmt() clears __GFP_NOWARN,
together with __GFP_THISNODE and __GFP_NORETRY. But AFAICS it really
only wants to clear __GFP_THISNODE.
Does this patch looks good?
Warning: it's completely untested.
Miklos
---
mm/slab.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6/mm/slab.c
===================================================================
--- linux-2.6.orig/mm/slab.c 2008-10-24 12:40:34.000000000 +0200
+++ linux-2.6/mm/slab.c 2008-11-24 22:17:04.000000000 +0100
@@ -2609,7 +2609,8 @@ static struct slab *alloc_slabmgmt(struc
if (OFF_SLAB(cachep)) {
/* Slab management obj is off-slab. */
slabp = kmem_cache_alloc_node(cachep->slabp_cache,
- local_flags & ~GFP_THISNODE, nodeid);
+ local_flags & ~__GFP_THISNODE,
+ nodeid);
if (!slabp)
return NULL;
} else {
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2008-11-24 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 21:53 Miklos Szeredi [this message]
2008-11-24 22:47 ` Pekka J Enberg
2008-11-25 18:58 ` Christoph Lameter
2008-11-26 8:10 ` Pekka Enberg
2008-11-26 9:50 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1L4jMt-0006OW-5J@pomaz-ex.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=cl@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox