From mboxrd@z Thu Jan 1 00:00:00 1970 In-reply-to: (message from Linus Torvalds on Wed, 30 Jul 2008 13:51:36 -0700 (PDT)) Subject: Re: [patch v3] splice: fix race with page invalidation References: <20080730175406.GN20055@kernel.dk> <20080730194516.GO20055@kernel.dk> Message-Id: From: Miklos Szeredi Date: Wed, 30 Jul 2008 23:16:16 +0200 Sender: owner-linux-mm@kvack.org Return-Path: To: torvalds@linux-foundation.org Cc: miklos@szeredi.hu, jens.axboe@oracle.com, akpm@linux-foundation.org, nickpiggin@yahoo.com.au, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: > On Wed, 30 Jul 2008, Miklos Szeredi wrote: > > > > It _is_ a bug fix. > > No it's not. > > It's still papering over a totally unrelated bug. It's not a "fix", it's a > "paper-over". It doesn't matter if _behaviour_ changes. > > Can you really not see the difference? > > Afaik, everybody pretty much agreed what the real fix should be (don't > mark the page not up-to-date, just remove it from the radix tree) Huh? I did exactly that, and that patch got NAK'ed by you and Nick: http://lkml.org/lkml/2008/6/25/230 http://lkml.org/lkml/2008/7/7/21 Confused. > I'm not seeing why you continue to push the patch that ALREADY GOT > NAK'ed. And later ACK'ed by Nick. There's everything here but agreement about a solution :) Miklos -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org