From mboxrd@z Thu Jan 1 00:00:00 1970 In-reply-to: <200807071638.32955.nickpiggin@yahoo.com.au> (message from Nick Piggin on Mon, 7 Jul 2008 16:38:31 +1000) Subject: Re: [patch 1/2] mm: dont clear PG_uptodate in invalidate_complete_page2() References: <20080625124038.103406301@szeredi.hu> <20080625173837.GA10005@shareable.org> <200807071638.32955.nickpiggin@yahoo.com.au> Message-Id: From: Miklos Szeredi Date: Mon, 07 Jul 2008 11:21:34 +0200 Sender: owner-linux-mm@kvack.org Return-Path: To: nickpiggin@yahoo.com.au Cc: miklos@szeredi.hu, jamie@shareable.org, torvalds@linux-foundation.org, jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hugh@veritas.com List-ID: On Mon, 7 Jul 2008, Nick Piggin wrote: > I don't know what became of this thread, but I agree with everyone else > you should not skip clearing PG_uptodate here. If nothing else, it > weakens some important assertions in the VM. But I agree that splice > should really try harder to work with it and we should be a little > careful about just changing things like this. Sure, that's why I rfc'ed. But I'd still like to know, what *are* those assumptions in the VM that would be weakened by this? Thanks, Miklos -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org