Re: [patch 1/2] mm: dont clear PG_uptodate in invalidate_complete_page2()

[Miklos Szeredi <miklos@szeredi.hu>]

> > > > > Like __block_prepare_write()?
> > > > 
> > > > That's called with the page locked and page->mapping verified.
> > > 
> > > Only when called via standard codepath.
> > 
> > It would be a grave error to call it without the page lock.
> 
> Page is locked of course, but invalidated, removed from all trees and
> caches, i.e. grab, lock, check, unlock... invalidate, write into that
> page should fail, but it will not, since page is uptodate and
> prepare_write does not check mapping at all.

But callers do check after having locked the page.

> > > Instead of returning error when reading from invalid page, now you
> > > return old content of it?
> > 
> > No, instead of returning a short count, it is now returning old
> > content.
> 
> Or instead of returning error or zero and relookup page eventually,
> which can already contain new data, we get old data.

Umm, it doesn't make any sense to try to always get fresh data.  If
you do read() on a file, the data may become old and invalid a
millisecond after the read finished.  We can't and needn't do anything
about this.

Miklos

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>