From: Miklos Szeredi <miklos@szeredi.hu>
To: torvalds@linux-foundation.org
Cc: miklos@szeredi.hu, jens.axboe@oracle.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [rfc patch 3/4] splice: remove confirm from pipe_buf_operations
Date: Tue, 24 Jun 2008 21:32:20 +0200 [thread overview]
Message-ID: <E1KBEFY-0002fh-5m@pomaz-ex.szeredi.hu> (raw)
In-Reply-To: <E1KBEA8-0002ey-II@pomaz-ex.szeredi.hu> (message from Miklos Szeredi on Tue, 24 Jun 2008 21:26:44 +0200)
> > > >
> > > > Let's start with page_cache_pipe_buf_confirm(). How should we deal
> > > > with finding an invalidated page (!PageUptodate(page) &&
> > > > !page->mapping)?
> > >
> > > I suspect we just have to use it. After all, it was valid when the read
> > > was done. The fact that it got invalidated later is kind of immaterial.
> >
> > Right. But what if it's invalidated *before* becoming uptodate (if
> > you'd read my mail further, I discussed this).
>
> Please ignore, this can't happen of course due to page locking...
Or it can only happen if there was an I/O error on reading the page.
So it's an issue after all...
Miklos
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-24 19:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-21 15:46 [rfc patch 0/4] splice: cleanups and fixes Miklos Szeredi
2008-06-21 15:46 ` [rfc patch 1/4] splice: fix comment Miklos Szeredi, Miklos Szeredi
2008-06-21 15:46 ` [rfc patch 2/4] splice: remove steal from pipe_buf_operations Miklos Szeredi, Miklos Szeredi
2008-06-24 8:01 ` Jens Axboe
2008-06-24 8:50 ` Miklos Szeredi
2008-06-24 12:21 ` Nick Piggin
2008-06-21 15:46 ` [rfc patch 3/4] splice: remove confirm " Miklos Szeredi, Miklos Szeredi
2008-06-24 8:04 ` Jens Axboe
2008-06-24 8:54 ` Miklos Szeredi
2008-06-24 11:19 ` Jens Axboe
2008-06-24 11:36 ` Miklos Szeredi
2008-06-24 11:46 ` Evgeniy Polyakov
2008-06-24 12:02 ` Miklos Szeredi
2008-06-24 12:15 ` Evgeniy Polyakov
2008-06-24 12:16 ` Nick Piggin
2008-06-24 12:22 ` Jens Axboe
2008-06-24 13:00 ` Miklos Szeredi
2008-06-24 17:30 ` Linus Torvalds
2008-06-24 18:24 ` Miklos Szeredi
2008-06-24 18:31 ` Linus Torvalds
2008-06-24 19:05 ` Miklos Szeredi
2008-06-24 19:17 ` Linus Torvalds
2008-06-24 19:24 ` Miklos Szeredi
2008-06-24 19:26 ` Miklos Szeredi
2008-06-24 19:32 ` Miklos Szeredi [this message]
2008-06-24 19:47 ` Linus Torvalds
2008-06-24 20:06 ` Miklos Szeredi
2008-06-24 19:45 ` Linus Torvalds
2008-06-21 15:46 ` [rfc patch 4/4] splice: use do_generic_file_read() Miklos Szeredi, Miklos Szeredi
2008-06-24 8:05 ` Jens Axboe
2008-06-24 11:11 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KBEFY-0002fh-5m@pomaz-ex.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox