From mboxrd@z Thu Jan 1 00:00:00 1970 In-reply-to: <1204040629.6242.326.camel@lappy> (message from Peter Zijlstra on Tue, 26 Feb 2008 16:43:49 +0100) Subject: Re: [PATCH 00/28] Swap over NFS -v16 References: <20080220144610.548202000@chello.nl> <20080223000620.7fee8ff8.akpm@linux-foundation.org> <18371.43950.150842.429997@notabene.brown> <1204023042.6242.271.camel@lappy> <1204040629.6242.326.camel@lappy> Message-Id: From: Miklos Szeredi Date: Tue, 26 Feb 2008 16:47:34 +0100 Sender: owner-linux-mm@kvack.org Return-Path: To: a.p.zijlstra@chello.nl Cc: miklos@szeredi.hu, neilb@suse.de, akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, trond.myklebust@fys.uio.no List-ID: > > > > mm-page_file_methods.patch > > > > > > > > This makes page_offset and others more expensive by adding a > > > > conditional jump to a function call that is not usually made. > > > > > > > > Why do swap pages have a different index to everyone else? > > > > > > Because the page->index of an anonymous page is related to its (anon)vma > > > so that it satisfies the constraints for vm_normal_page(). > > > > > > The index in the swap file it totally unrelated and quite random. Hence > > > the swap-cache uses page->private to store it in. > > > > Yeah, and putting the condition into page_offset() will confuse code > > which uses it for finding the offset in the VMA or in a tmpfs file. > > > > So why not just have a separate page_swap_offset() function, used > > exclusively by swap_in/out()? > > Ah, we can do the page_file_offset() to match page_file_index() and > page_file_mapping(). And convert NFS to use page_file_offset() where > appropriate, as I already did for these others. > > That would sort out the mess, right? Yes, that sounds perfect. Miklos -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org