From: Miklos Szeredi <miklos@szeredi.hu>
To: peterz@infradead.org
Cc: jdike@addtoit.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk
Subject: Re: per-bdi-throttling: synchronous writepage doesn't work correctly
Date: Thu, 01 Nov 2007 20:19:45 +0100 [thread overview]
Message-ID: <E1InfZx-0004Eu-00@dorka.pomaz.szeredi.hu> (raw)
In-Reply-To: <1193942132.27652.331.camel@twins> (message from Peter Zijlstra on Thu, 01 Nov 2007 19:35:32 +0100)
> >
> > See the file "Locking" for more details.
> >
> >
> > The "should set PG_Writeback" bit threw me off I guess.
>
> Hmm, set_page_writeback() is also the one clearing the radix tree dirty
> tag. So if that is not called, we get in a bit of a mess, no?
>
> Which makes me think hostfs is buggy.
Yes, looks like that sort of usage is not valid. But not clearing the
dirty tag won't cause any malfunction, it'll just waste some CPU when
looking for dirty pages to write back. This is probably why this
wasn't noticed earlier.
Miklos
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-01 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 16:49 Miklos Szeredi
2007-11-01 16:51 ` Peter Zijlstra
2007-11-01 17:00 ` Miklos Szeredi
2007-11-01 17:09 ` Peter Zijlstra
2007-11-01 17:16 ` Peter Zijlstra
2007-11-01 18:35 ` Peter Zijlstra
2007-11-01 19:19 ` Miklos Szeredi [this message]
2007-11-01 19:55 ` Peter Zijlstra
2007-11-01 17:28 ` Miklos Szeredi
2007-11-01 17:39 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1InfZx-0004Eu-00@dorka.pomaz.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox