From: Miklos Szeredi <miklos@szeredi.hu>
To: trond.myklebust@fys.uio.no
Cc: akpm@linux-foundation.org, staubach@redhat.com, hugh@veritas.com,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update ctime and mtime for mmaped write
Date: Wed, 21 Feb 2007 19:28:39 +0100 [thread overview]
Message-ID: <E1HJwCl-0003V6-00@dorka.pomaz.szeredi.hu> (raw)
In-Reply-To: <1172081562.9108.1.camel@heimdal.trondhjem.org> (message from Trond Myklebust on Wed, 21 Feb 2007 13:12:42 -0500)
> > This flag is checked in msync() and __fput(), and if set, the file
> > times are updated and the flag is cleared
>
> Why not also check inside vfs_getattr?
This is the minimum, that the standard asks for.
Note, your porposal would touch the times in vfs_getattr(), which
means, that the modification times would depend on the time of the
last stat() call, which is not really right, though it would still be
conforming.
It is much saner, if the modification time is always the time of the
last write() or msync().
Miklos
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-02-21 18:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 17:51 Miklos Szeredi, Miklos Szeredi
2007-02-21 18:07 ` Peter Staubach
2007-02-21 18:23 ` Miklos Szeredi
2007-02-21 18:54 ` Peter Staubach
2007-02-21 19:07 ` Miklos Szeredi
2007-02-22 17:36 ` Peter Staubach
2007-02-22 18:16 ` Miklos Szeredi
2007-02-22 20:11 ` Peter Staubach
2007-02-22 20:43 ` Miklos Szeredi
2007-02-22 20:50 ` Peter Staubach
2007-02-21 18:12 ` Trond Myklebust
2007-02-21 18:28 ` Miklos Szeredi [this message]
2007-02-21 18:36 ` Trond Myklebust
2007-02-21 18:50 ` Miklos Szeredi
2007-02-21 18:50 ` Peter Staubach
2007-02-22 4:26 ` Andrew Morton
2007-02-22 7:49 ` Miklos Szeredi
2007-02-22 17:39 ` Peter Staubach
2007-02-22 18:08 ` Miklos Szeredi
2007-02-22 20:14 ` Peter Staubach
2007-02-22 20:48 ` Miklos Szeredi
2007-02-22 20:55 ` Peter Staubach
2007-02-22 21:04 ` Trond Myklebust
2007-02-22 21:28 ` Miklos Szeredi
2007-02-22 21:52 ` Peter Staubach
2007-02-22 22:08 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1HJwCl-0003V6-00@dorka.pomaz.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=staubach@redhat.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox