From: Miklos Szeredi <miklos@szeredi.hu>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: dirty balancing deadlock
Date: Mon, 19 Feb 2007 01:30:28 +0100 [thread overview]
Message-ID: <E1HIwQG-0005OS-00@dorka.pomaz.szeredi.hu> (raw)
In-Reply-To: <E1HIwLJ-0005N4-00@dorka.pomaz.szeredi.hu> (message from Miklos Szeredi on Mon, 19 Feb 2007 01:25:21 +0100)
> --- a/fs/fs-writeback.c~a
> +++ a/fs/fs-writeback.c
> @@ -356,7 +356,7 @@ int generic_sync_sb_inodes(struct super_
> continue; /* Skip a congested blockdev */
> }
>
> - if (wbc->bdi && bdi != wbc->bdi) {
> + if (wbc->bdi && bdi != wbc->bdi && bdi_write_congested(bdi)) {
> if (!sb_is_blkdev_sb(sb))
> break; /* fs has the wrong queue */
> list_move(&inode->i_list, &sb->s_dirty);
Checking bdi_write_congested(bdi) is not reliable, since the queue can
become congested _after_ the check is done.
Miklos
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-02-19 0:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-18 18:28 Miklos Szeredi
2007-02-18 20:53 ` Andrew Morton
2007-02-18 21:25 ` Rik van Riel
2007-02-18 22:54 ` Miklos Szeredi
2007-02-18 22:50 ` Miklos Szeredi
2007-02-18 22:59 ` Andrew Morton
2007-02-18 23:22 ` Miklos Szeredi
2007-02-18 23:59 ` Andrew Morton
2007-02-19 0:25 ` Miklos Szeredi
2007-02-19 0:30 ` Miklos Szeredi [this message]
2007-02-19 0:45 ` Miklos Szeredi
2007-02-19 0:45 ` Chris Mason
2007-02-19 0:54 ` Miklos Szeredi
2007-02-19 1:01 ` Chris Mason
2007-02-19 1:14 ` Miklos Szeredi
2007-02-20 0:16 ` Chris Mason
2007-02-20 8:53 ` Miklos Szeredi
2007-02-19 17:11 ` Miklos Szeredi
2007-02-19 23:12 ` Miklos Szeredi
2007-02-20 0:13 ` Chris Mason
2007-02-20 8:47 ` Miklos Szeredi
2007-02-20 11:30 ` Chris Mason
2007-02-21 21:36 ` Andrew Morton
2007-02-22 7:42 ` Miklos Szeredi
2007-02-22 7:55 ` Andrew Morton
2007-02-22 8:02 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1HIwQG-0005OS-00@dorka.pomaz.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox