From: Andy Whitcroft <apw@shadowen.org>
To: akpm@osdl.org
Cc: anton@samba.org, apw@shadowen.org, haveblue@us.ibm.com,
kravetz@us.ibm.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linuxppc64-dev@ozlabs.org, olof@lixom.net,
paulus@samba.org
Subject: sparsemem ppc64 tidy flat memory comments and fix benign mempresent call
Date: Mon, 09 May 2005 16:49:04 +0100 [thread overview]
Message-ID: <E1DVAVE-00012m-Pq@pinky.shadowen.org> (raw)
In-Reply-To: <427A59BC.1020208@shadowen.org>
I was going to rediff the memory present patches, but as -mm has
picked these up already here is a simple patch to clean up this
errant comment and address a benign call to memory_present().
Applies onto the existing patches.
-apw
Tidy up the comments for the ppc64 flat memory support and fix
a currently benign double call to memory_present() for the first
memory block.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
init.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff -upN reference/arch/ppc64/mm/init.c current/arch/ppc64/mm/init.c
--- reference/arch/ppc64/mm/init.c
+++ current/arch/ppc64/mm/init.c
@@ -631,18 +631,19 @@ void __init do_init_bootmem(void)
max_pfn = max_low_pfn;
- /* add all physical memory to the bootmem map. Also, find the first
- * presence of all LMBs*/
+ /* Add all physical memory to the bootmem map, mark each area
+ * present. The first block has already been marked present above.
+ */
for (i=0; i < lmb.memory.cnt; i++) {
unsigned long physbase, size;
physbase = lmb.memory.region[i].physbase;
size = lmb.memory.region[i].size;
- if (i) { /* already created mappings for first LMB */
+ if (i) {
start_pfn = physbase >> PAGE_SHIFT;
end_pfn = start_pfn + (size >> PAGE_SHIFT);
+ memory_present(0, start_pfn, end_pfn);
}
- memory_present(0, start_pfn, end_pfn);
free_bootmem(physbase, size);
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-05-09 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-04 20:30 [3/3] sparsemem memory model for ppc64 Andy Whitcroft
2005-05-05 2:31 ` Olof Johansson
2005-05-05 17:37 ` Andy Whitcroft
2005-05-09 15:49 ` Andy Whitcroft [this message]
2005-05-09 23:03 ` sparsemem ppc64 tidy flat memory comments and fix benign mempresent call Joel Schopp
2005-05-10 15:45 ` Andy Whitcroft
2005-05-10 19:42 ` mike kravetz
2005-05-17 13:08 ` [PATCH] sparsemem-ppc64-flat-first-block-is-not-special Andy Whitcroft
2005-05-05 17:53 ` [3/3] sparsemem memory model for ppc64 mike kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DVAVE-00012m-Pq@pinky.shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=haveblue@us.ibm.com \
--cc=kravetz@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox