linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@arcor.de>
To: Andrew Morton <akpm@zip.com.au>, ekonijn@xs4all.nl
Cc: Dave Jones <davej@suse.de>, Christoph Hellwig <hch@infradead.org>,
	kernel-janitor-discuss@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: page-flags.h
Date: Thu, 29 Aug 2002 21:04:59 +0200	[thread overview]
Message-ID: <E17kUbE-00034u-00@starship> (raw)
In-Reply-To: <3CE172C7.C250E7E8@zip.com.au>

On Tuesday 14 May 2002 22:25, Andrew Morton wrote:
> inlines in headers are just a pita.  I know it gets people
> all excited but I'd say: make 'em macros.

Responding to this old, old message - I strongly disagree.  Macros just suck 
too much, because of type safety and self-documentation issues.  Not only 
that, but using them extensively just lets the header inclusion order madness 
degenerate further.

Anyway, header inclusion order is a solved problem as far as I'm concerned, 
please see my patches/posts with 'early page' subject line, on lkml.  The 
winning strategy is to separate data declarations from function declarations, 
and automatically include the former in the latter.

It's true that I haven't brought these patches forward to 2.5, and for that I 
can be faulted.  There's still time though...

-- 
Daniel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

      parent reply	other threads:[~2002-08-29 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20020501192737.R29327@suse.de>
2002-05-01 17:34 ` page-flags.h Christoph Hellwig
2002-05-01 18:04   ` page-flags.h Dave Jones
2002-05-03  2:52     ` page-flags.h Andrew Morton
2002-05-03  8:24       ` page-flags.h Christoph Hellwig
2002-05-03 22:41       ` page-flags.h Erik van Konijnenburg
2002-05-03 23:06         ` page-flags.h Andrew Morton
2002-05-03 23:39           ` page-flags.h Dave Jones
2002-05-04  6:46             ` page-flags.h Erik van Konijnenburg
2002-05-14 20:25               ` page-flags.h Andrew Morton
2002-05-15 12:38                 ` page-flags.h Christoph Hellwig
2002-08-29 19:04                 ` Daniel Phillips [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E17kUbE-00034u-00@starship \
    --to=phillips@arcor.de \
    --cc=akpm@zip.com.au \
    --cc=davej@suse.de \
    --cc=ekonijn@xs4all.nl \
    --cc=hch@infradead.org \
    --cc=kernel-janitor-discuss@lists.sourceforge.net \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox