From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: "Stephen C. Tweedie" <sct@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Ben LaHaise <bcrl@redhat.com>, Christoph Rohland <cr@sap.com>
Subject: Re: [PATCH] Fix races in 2.4.2-ac22 SysV shared memory
Date: Fri, 23 Mar 2001 22:20:05 +0000 (GMT) [thread overview]
Message-ID: <E14gZuj-0005YN-00@the-village.bc.nu> (raw)
In-Reply-To: <Pine.LNX.4.31.0103231157200.766-100000@penguin.transmeta.com> from "Linus Torvalds" at Mar 23, 2001 11:58:50 AM
> On Fri, 23 Mar 2001, Stephen C. Tweedie wrote:
> >
> > The patch below is for two races in sysV shared memory.
>
> + spin_lock (&info->lock);
> +
> + /* The shmem_swp_entry() call may have blocked, and
> + * shmem_writepage may have been moving a page between the page
> + * cache and swap cache. We need to recheck the page cache
> + * under the protection of the info->lock spinlock. */
> +
> + page = find_lock_page(mapping, idx);
>
> Ehh.. Sleeping with the spin-lock held? Sounds like a truly bad idea.
Umm find_lock_page doesnt sleep does it ?
Alan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2001-03-23 22:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-23 1:13 Stephen C. Tweedie
2001-03-23 19:58 ` Linus Torvalds
2001-03-23 22:20 ` Alan Cox [this message]
2001-03-23 22:23 ` Alexander Viro
2001-03-23 22:29 ` Alan Cox
2001-03-23 22:27 ` Linus Torvalds
2001-03-23 22:35 ` Alan Cox
2001-03-23 22:37 ` Linus Torvalds
2001-03-23 22:31 ` David S. Miller
2001-03-25 0:13 ` Stephen C. Tweedie
2001-03-25 1:05 ` Rik van Riel
2001-03-25 16:50 ` Stephen C. Tweedie
2001-03-28 9:18 ` Christoph Rohland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E14gZuj-0005YN-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bcrl@redhat.com \
--cc=cr@sap.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sct@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox