From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC1BC71159 for ; Mon, 16 Jun 2025 20:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEDFB6B0089; Mon, 16 Jun 2025 16:01:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9E9F6B0093; Mon, 16 Jun 2025 16:01:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B66846B00A3; Mon, 16 Jun 2025 16:01:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A08716B0089 for ; Mon, 16 Jun 2025 16:01:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 18F17C0DF5 for ; Mon, 16 Jun 2025 20:01:08 +0000 (UTC) X-FDA: 83562332616.16.EF1EF83 Received: from relay.hostedemail.com (unirelay03 [10.200.18.66]) by imf30.hostedemail.com (Postfix) with ESMTP id C909280015 for ; Mon, 16 Jun 2025 20:01:05 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750104065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AomqQsJBTpg66zFC6IzNCQDm8xWbRpjPl0LqtiAdfzI=; b=rtYENfQc3HkBWuserPDn9m9w2M7CpgFtK7JYCwIfDZ2BfkdBdZsR6guLvnCDiW+CXQyVog uBpCdWqvkB4poKmBwvXDrIeZjd0a5da2Bvp+aRLPW1wRg0Vqwoh3AIpjkx8OQqQiv4BhCX Aeceik3ASjAfZi/unjwI0OO5Ve/wT94= ARC-Authentication-Results: i=2; imf30.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750104065; a=rsa-sha256; cv=pass; b=psJamOkngG8S6w6TZSOHThGeLJeRVILJg9wPD2MqDC1XpFvhFOOfSSO3No2GwYQ/1HzAtd DY9rwWIJqxCDwtyxZmTLXOO3ImeeHJJTTMufxaOinWQNnFcqkro6fAB1nHJruxYgu0zkhI mTrGaNTlkRDxdqZ02KAV8yL1TcFngUo= Received: from relay.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50558BE4CE for ; Mon, 16 Jun 2025 20:01:05 +0000 (UTC) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 20DCCBE4BB for ; Mon, 16 Jun 2025 20:01:05 +0000 (UTC) X-FDA: 83562332490.23.7E2AF46 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf05.hostedemail.com (Postfix) with ESMTP id EC428100009; Mon, 16 Jun 2025 20:01:02 +0000 (UTC) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750104063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AomqQsJBTpg66zFC6IzNCQDm8xWbRpjPl0LqtiAdfzI=; b=GdeV+6BdTTxIKb+zN+zJY9E10kpEpAFj82hpAEgBrzcf+6lcU/8Ku8fRyFwoxFd2FRwEUC PkxFu/AXtb8ST+/JORkHudanBGtrjRgk3TvL/DR2vldTLrpNJAb4I9C6L7lUeL7Dwr256r YUYtsB6AqKAl5tgcHytvN48qjZ15nrY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MIbLmxFk; spf=pass (imf05.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750104063; a=rsa-sha256; cv=none; b=f4XHgUa/pYywnixB9R3SanNqV4wt+8u00KyYY26p9PKsZmCvMr9YVc/407KVNY6awcVer4 pKE3Uhx1g3+TeHTkAv8nF6+S+ffh46/JXkFtIikCuDJ40A8LOgy5DYTqWy6yQFwtRnS2cl EirTuuO6HkbhvT/rSTFPEoPjRNgRS6Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 87714615F2; Mon, 16 Jun 2025 20:01:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC77AC4CEEA; Mon, 16 Jun 2025 20:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750104061; bh=63g4BFyDRQ9zPpgQi+aKRKc8QZqr403zshqDeyAnLYU=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=MIbLmxFkQvDlWahGwOzhitZt0cSzoXdhWUHu8g8OkqZLAupve4SlpvOS2uS1ZEWmj UwQ2s8yA8tAesX44zSYXdwSfJqH8TXAO82zH05g97Z/1UOjr1700+pmtNnzQBgsvl8 4ex7UC260hPMrrevOuoNx+ItcoPEWmxAHO8kKS0LskJGXsmB+Lw+lBdLI7AmEbxTyi Xaylvf43oG7bbuZKo2MFBbk3fvcCNc7E3lsmsbzOnTEhXlMNNdjS9szSMRmncYZuuz cV+XE+08Pnq5bgJ/0F99pB6Ea9gbVg9z6nnYTpH3+D1YHFBxVujigA5wdVTvZ/xroj anLaWnk5pcMew== Date: Mon, 16 Jun 2025 13:01:00 -0700 From: Kees Cook To: Lorenzo Stoakes , Andrew Morton CC: "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_03/10=5D_fs=3A_consistently_u?= =?US-ASCII?Q?se_file=5Fhas=5Fvalid=5Fmmap=5Fhooks=28=29_helper?= User-Agent: K-9 Mail for Android In-Reply-To: References: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-HE-Meta: U2FsdGVkX1/HEJXhZloqkdDhsr9Ooc0o4n4+6pKd/WbwwNNs60xweK2EbJazpfek0gLBOo1mBK1NvczNp/Jfg0soApkjTTwvg50ToDRuSTRsTxdNPX72y9XLpjPF0FCDnyML48bbN9o5LNdJC/7Uom33uVQEzzFIJLKq4lHTiPCEM2kJqOsf3d8p9WBzpbm6jCVpsGj4AYmOYYFoDEfqUboue1TykoeGr3nHdE8toYQahT+ToQ659HuEZAdTGVtN1Nk5clvv32QZhfUKi2fdNp98Gn2wntE3BnIWtrfV9rSH2OZC/6syVONlXmO8K06WcT+jyPnThJAeEpSTc90eSHheduPqakpyZ9nXuITwL4eCvI8hKmpGBOk9c0QI78t4g0vQJstCWmlpuO+YQqz2RD7V/6Kj1zibMgUPDyWoAxpwBKB1qnLAkHNlIxMQcSVDc/yBEbaHTEJPA0MqfocYiqXq5A36m6n/76u0bdqfQyWeW1PCt0k45vSH6BOSsNceh6p6SqBIKX0Wp9v5h92O7iv67PZAuL3udYggZz8XyHaf63Mtuex6XS++Y8u9GnmU20cuVeoHl1jqdUEP2ukQopemvq5sGnMP9uU06VOKWStl1FkQFB/C3EqTWf7bXSGY2dGHGfPIgiAgpA3w0lrJF82rwra8ffTf/FT6c8sAks6XnEr20bgfS5cHWSSOsB5E+AOwklzcxD0jNXISc9MWFpUKZB3jf3wAnxN7cX+svqWEaUqRaYvwPddmhziv+fkaVZzFWyREU0B4Rvhyk+6/UwelELZYsbjkuJXAxctg8jfX5cWg2j4gTwK+qvIixBYGKg7qmnotdc938sFt47hHFSnfiNLh4J3UjFvWGvo1UObKzGULJJKRLugcvfwZAppnVF5EG+wEc/hRUBFSgcIPy7+Qh9LNnEaRQAOgRzFmuhHZt9pjaQ/LR8yf0Lh34Rp5oK4fr79dbLuSa6TKj8L jfWQWPv+ J2PsNh5QSLbf++WhWzTkNqsKy94/ixkZl9iOwEepw5vD0SpT8E3B8FT6v5g56gXBHoZJ6xO1OYspcb8Sb8Ga0w1swh0rxJtW8Sym+spmltjyRTtp9vQn0QpCPtFsseYvUbz56Y8W0fNrk9zetDBsnRlHDH0YXtsXGKEIOodVHdNOwrjHu23yUXCqE09UGNiNbD26j78A7ABwygopwwcI5lO7ZIiUBMtPIQ4Z0wIlfNGiEVqCK4Y+QQcw9pVYepZDukQZD4sEfnjEUd4ZXPOmkJ0HKm08RoLZ3YL7AdvhtPT/dsNxvnR4bX3x0xnLqR6NOMlWXuqfoSNn3fIuV1rpMqhm0G5iO9o0Dh/SZipqVEvnIvQQaCCCBc8ui/V2/UoCRkeI9ueCzNn3atY48KfOygFTxiCSDT5bbY8s3t08ekWk2VTY8hOj8TyrHg8QogCamQBPs X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C909280015 X-Stat-Signature: m1x17mmwksuuznjxjwd7dxui758mzjdd X-Rspam-User: X-HE-Tag-Orig: 1750104062-873839 X-HE-Tag: 1750104065-873442 X-HE-Meta: U2FsdGVkX1/sFnZzNsLO7f+YoQYvzCNGGJ7vnsXQEYg7ydzFSznUNzm1zzI3m5OMzyty/9+ZgsOIRivfD5b+nRdVajpsvKcbjRxCqI+Q1lrI+mtz+gT/t7TlRQNh7/bDej9NGJHNKOoDP+Ss1I7PX2n/qMnJGNrhHtaH4I2gBmwFG5TNw8fCVIiFp5/9gID31hVm37AWaqHQHkovmx9gw3kVD70eqF0tbqkSdutYE9zXH1NyGLDlBNm2uT7QHjHsUT1Cy2N75OELFQfggI5uOrNHry84hlgi8d6zgFenCb72jk++dRWVl3m5M0w22vdBKoy4+W2qkS6zVSFK369cobUF3VejyZkBCZj8GvMGBrb/7t69Z+78fMvwwvcV93wX2doL65R+gxpY4bHTrHw4OQcaV64dvkXnY/OXE5gwC90tclQ+dJeIxhc0B2GR/mSO1r6F3e5z/tT6Wdb3laCBALlAKXqxPK3GHBFhXA4k06nghvHTKiNwiCA15MbwDO8dvD+s815Sm6mXzxQyXOZLaBvu1D3r4GX8zv/BDKBhX5DdaTLGVxFzdKb30Jm9rhqFa17W/A8f5+QFNIlzaqw5WDOIwBvmtiAISXz0rPrRq9j7M8lUxaF3C2xH29y1NKeizo4OF4+e6B9OwjT+1BnLE5Kk/nc1Nw8eEe91AKof55f3X+bYF58W84N0s923+4RkSml9wSiZ5EA6mUd9utUZYLyqt8xtiNKv/2+nqyzQkxxgqC7b/kU4vykDz4AZ89MErbDLDYf32DkANLrWjTwxEPPgkIftMUFBVtV5tUeMGgBD7tldTL+2nhldxk6CRHueqUOe528XupChFlrwsY0WnsfiIzyJNlFDro4/qFyyqPjUc273UwNqReZf2uxgvcAGsN41F+CYqlFU6IquUBPO5dVvhEFDoZsHpO7dekPtK7ClNkgU3H9e1WF5vkA6uH2mERQhrDQKmF0ABAAPdrI ei1BCNE+ JsHliFzO1znunRO9ebfXVvLwIdcmGjdl/1QyB2Cls0GREiUobX2y+a3L9LtryXlm/XgmrE/Oto38tH2OaczNcEb8EnYqRivTPaFiycwblGVFI4BUzwEGpsBfMgwLpmec9U5V90l2xZ5gBhfm5sHlzr6SgVxBw1/vNiGXrvK2pQ9t1l+3B+A/vKG0ZZnFO0mbzICve2nd4+iRcJlceFHOUoGHOr5uGP3SkgZ2rB6IjKn4TZYI1IFJTaUsz+FsP1ngOf6cbiIjkNTbC4D8s52VroP2IxRIRJ+uB6DLVhCEM2YjF2EpPx1+yUarDe8abdLqaeQqBPvTYvExIMgq3WMczQKwIBFepUBMvtrcqso+8CIj9OtUbxpxuSP06wK/ByRmKNumB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On June 16, 2025 12:33:22 PM PDT, Lorenzo Stoakes wrote: >Since commit c84bf6dd2b83 ("mm: introduce new =2Emmap_prepare() file >callback"), the f_op->mmap() hook has been deprecated in favour of >f_op->mmap_prepare()=2E > >Additionally, commit bb666b7c2707 ("mm: add mmap_prepare() compatibility >layer for nested file systems") permits the use of the =2Emmap_prepare() = hook >even in nested filesystems like overlayfs=2E > >There are a number of places where we check only for f_op->mmap - this is >incorrect now mmap_prepare exists, so update all of these to use the >general helper file_has_valid_mmap_hooks()=2E > >Most notably, this updates the elf logic to allow for the ability to >execute binaries on filesystems which have the =2Emmap_prepare hook, but >additionally we update nested filesystems=2E > >Signed-off-by: Lorenzo Stoakes >--- > fs/backing-file=2Ec | 2 +- > fs/binfmt_elf=2Ec | 4 ++-- > fs/binfmt_elf_fdpic=2Ec | 2 +- Thanks for the refactoring! Acked-by: Kees Cook --=20 Kees Cook