From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBD9C433DB for ; Sun, 10 Jan 2021 11:35:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0BC792333E for ; Sun, 10 Jan 2021 11:35:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BC792333E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 15B3C6B011B; Sun, 10 Jan 2021 06:35:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B9578D0018; Sun, 10 Jan 2021 06:35:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC2556B011B; Sun, 10 Jan 2021 06:35:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id CB0766B00B9 for ; Sun, 10 Jan 2021 06:35:32 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9308F8245571 for ; Sun, 10 Jan 2021 11:35:32 +0000 (UTC) X-FDA: 77689660104.29.horse74_4c0459627503 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 69436180868FA; Sun, 10 Jan 2021 11:35:32 +0000 (UTC) X-HE-Tag: horse74_4c0459627503 X-Filterd-Recvd-Size: 3532 Received: from aposti.net (aposti.net [89.234.176.197]) by imf21.hostedemail.com (Postfix) with ESMTP; Sun, 10 Jan 2021 11:35:31 +0000 (UTC) Date: Sun, 10 Jan 2021 11:35:01 +0000 From: Paul Cercueil Subject: Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic To: Thomas Bogendoerfer Cc: tglx@linutronix.de, airlied@linux.ie, airlied@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, bcrl@kvack.org, bigeasy@linutronix.de, bristot@redhat.com, bsegall@google.com, bskeggs@redhat.com, chris@zankel.net, christian.koenig@amd.com, clm@fb.com, davem@davemloft.net, deanbo422@gmail.com, dietmar.eggemann@arm.com, dri-devel@lists.freedesktop.org, dsterba@suse.com, green.hu@gmail.com, hch@lst.de, intel-gfx@lists.freedesktop.org, jcmvbkbc@gmail.com, josef@toxicpanda.com, juri.lelli@redhat.com, kraxel@redhat.com, linux-aio@kvack.org, linux-arm-kernel@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-csky@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, mgorman@suse.de, mingo@kernel.org, monstr@monstr.eu, mpe@ellerman.id.au, nickhu@andestech.com, nouveau@lists.freedesktop.org, paulmck@kernel.org, paulus@samba.org, peterz@infradead.org, ray.huang@amd.com, rodrigo.vivi@intel.com, rostedt@goodmis.org, sparclinux@vger.kernel.org, spice-devel@lists.freedesktop.org, sroland@vmware.com, torvalds@linuxfoundation.org, vgupta@synopsys.com, vincent.guittot@linaro.org, viro@zeniv.linux.org.uk, virtualization@lists.linux-foundation.org, x86@kernel.org Message-Id: In-Reply-To: <20210109003352.GA18102@alpha.franken.de> References: <20210108235805.GA17543@alpha.franken.de> <20210109003352.GA18102@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000069, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Thomas, Le sam. 9 janv. 2021 =E0 1:33, Thomas Bogendoerfer=20 a =E9crit : > On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: >> On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: >> > Hi Thomas, >> > >> > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this=20 >> commit. >> > >> > Any idea what could be happening? >>=20 >> not yet, kernel crash log of a Malta QEMU is below. >=20 > update: >=20 > This dirty hack lets the Malta QEMU boot again: >=20 > diff --git a/mm/highmem.c b/mm/highmem.c > index c3a9ea7875ef..190cdda1149d 100644 > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn,=20 > pgprot_t prot) > vaddr =3D __fix_to_virt(FIX_KMAP_BEGIN + idx); > BUG_ON(!pte_none(*(kmap_pte - idx))); > pteval =3D pfn_pte(pfn, prot); > - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); > + set_pte(kmap_pte - idx, pteval); > arch_kmap_local_post_map(vaddr, pteval); > current->kmap_ctrl.pteval[kmap_local_idx()] =3D pteval; > preempt_enable(); >=20 > set_pte_at() tries to update cache and could do an kmap_atomic()=20 > there. > Not sure, if this is allowed at this point. Yes, I can confirm that your workaround works here too. Cheers, -Paul