From: David Binderman <dcb314@hotmail.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: linux-next/mm/vmscan.c:3751: possible poor choice of data type ?
Date: Mon, 18 Jan 2016 15:59:04 +0000 [thread overview]
Message-ID: <DUB128-W86263FEE560D2053CF19D09CC00@phx.gbl> (raw)
Hello there,
[linux-next/mm/vmscan.c:3751]: (style) int result is assigned to long variable.
const unsigned long nr_pages = 1 << order;
Maybe something like
const unsigned long nr_pages = 1UL << order;
would be better code.
Regards
David Binderman
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2016-01-18 15:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DUB128-W86263FEE560D2053CF19D09CC00@phx.gbl \
--to=dcb314@hotmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox