From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEDF1C433F5 for ; Fri, 22 Apr 2022 15:18:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D35206B008A; Fri, 22 Apr 2022 11:18:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE4536B008C; Fri, 22 Apr 2022 11:18:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC29B6B0092; Fri, 22 Apr 2022 11:18:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 9804E6B008A for ; Fri, 22 Apr 2022 11:18:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 613E4239B3 for ; Fri, 22 Apr 2022 15:18:42 +0000 (UTC) X-FDA: 79384872084.11.BC2FBFA Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by imf31.hostedemail.com (Postfix) with ESMTP id 823ED20017 for ; Fri, 22 Apr 2022 15:18:37 +0000 (UTC) Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23MAEmWt028198; Fri, 22 Apr 2022 17:18:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=STMicroelectronics; bh=g6bME5zTVmp1DEGoDmgA+SD/tqTUUVmD+h5h8Ovbnwg=; b=CKkmdw57o++f3ntHZrytqTmOmBbed+o0Bxge8qQnoNfZUEsO+BhuSB7lfrZwlDcb9k+H xDz2Gp1TMzVd8HyzNrG5xXEe8Eb/nA5wiVQWPnhTYKknw0cEjJ4MALpO5/qF44rVrhLH M9OAKvyygYNWaqy8FVzceyuylXg/hRJOb3IaD86xxVbYZfZzgqFcvRghV8wDcy7kMjYy DKWLsWdMoYfw4ONdFI4ytVcGwKtl9er8JMvwHbApLWIzooosmd3ouuhjR0ZRXgzXDxC2 hR/NMZ1uo+qzxTdLU0j6hL9j7QVT3o4v51wmezjq/j09Io1fN3PTApTVB1HxbydVrUE1 RA== Received: from eur05-vi1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3ffpqh9nnm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Apr 2022 17:18:25 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xvdbb/Fqu2nH3/11Rh2LHjChWEWFNLSRWa/YDo2siTsSJh7spBRkae6zpNGgby0XkM0hj3iber7KoluDOTRFJBq6b5qw3/JsQvhSzc2SE80eZG7wJCRttpBAzeDotvYVPnpdATskMy0xjDhJf5FCQH82M1ja9GFkK8TEFPEnL4E3he6B8GAKOHR+OvW8VAFYWLCjvWRTH+O1qaqRogTPB4jLnv1IzAhW7QG5p9CDHseUKynKGWfVBN3Qi88aKNYZOcba5YIskvwbbyZHTjHAqGcCuxqhsmaJ38iP4OSDFEvdgQ+6Yj39QxE+8QS5K5cdd+ee/xIgxjKDcUJ0t89fdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g6bME5zTVmp1DEGoDmgA+SD/tqTUUVmD+h5h8Ovbnwg=; b=BEZA9P8TzUYA0F6O5GVrPyQ1O8vN6uXyCSx6FR2DgT/nUEdiq80iFN1WYnusXGgBB4TZ2k3fQHmNdRMSB3gm5LNSVuZvcm6t1VcpwghBN7q0mV96NJtJ3gitM7P8Id18+0+g4ay1mxhjeSegbsz7brsAlIkj1/A8rZ4AE0go5dCJamspAfxXRO2J3amo3pZM+A0NvWeZ0trXbGKGywjrqxYde76qC/V1kRgulQJXfbsB+/L4uc9T4dKpkClSl4LM61axHx7yyeqdW1lRfzcMNc4l8fW473dG7OTbqWDh6uws1lDDX6gStB79syFdL2Q71C39g5rY6jvP0tqxLC+oEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=st.com; dmarc=pass action=none header.from=st.com; dkim=pass header.d=st.com; arc=none Received: from DU0PR10MB6177.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3e8::20) by VI1PR1001MB1183.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:6f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 22 Apr 2022 15:18:20 +0000 Received: from DU0PR10MB6177.EURPRD10.PROD.OUTLOOK.COM ([fe80::f972:d341:e726:f5cf]) by DU0PR10MB6177.EURPRD10.PROD.OUTLOOK.COM ([fe80::f972:d341:e726:f5cf%6]) with mapi id 15.20.5164.020; Fri, 22 Apr 2022 15:18:20 +0000 From: Patrice CHOTARD To: Arnd Bergmann , Geert Uytterhoeven CC: Greg Ungerer , "Eric W. Biederman" , Kees Cook , Niklas Cassel , Damien Le Moal , Alexander Viro , Paul Walmsley , Palmer Dabbelt , Albert Ou , Mike Frysinger , "stable@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-riscv@lists.infradead.org" , Linux-Arch , linux-m68k , Linux ARM , Linux-sh list , Yoshinori Sato , Rich Felker , Sudeep Holla , Vladimir Murzin , Jesse Taube , Giulio Benetti , Pierre Yves MORDRET , Alexandre TORGUE Subject: RE: [PATCH] binfmt_flat: Remove shared library support Thread-Topic: [PATCH] binfmt_flat: Remove shared library support Thread-Index: AQHYVU8vk+qbt1yTWkiUo8ivi5fXOaz8DWEs Date: Fri, 22 Apr 2022 15:18:20 +0000 Message-ID: References: <20220414091018.896737-1-niklas.cassel@wdc.com> <81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org> <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> <01b063d7-d5c2-8af0-ad90-ed6c069252c5@linux-m68k.org> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Enabled=True;MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SiteId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SetDate=2022-04-22T15:18:20.026Z;MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Name=ST Restricted;MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ContentBits=0;MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Method=Standard; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d4a4c49f-4c6a-42a0-eb01-08da247355f4 x-ms-traffictypediagnostic: VI1PR1001MB1183:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2DKaSchTDT6LFJWyK7wcJIkcEkgWIzHWbHIcyw1S4k/iHlB5/Trg7H4nUVC165EB8cKZGIFEyXUUBeWKeorIusfZaONzy6awDC3E9u5G4GUcxEAl0WHu1IAPoq+/aD5lYJDqtVXZfh0zim1Wt+SJmgxP0wFlPdLic8JOhi3XYunn3t5mnV1jNxXB54l47J8KcZw4ugIbrrZIUY3vXhRBzast7ENa76YzCLuJcoCiL43H+UFrWeGoQWULGAAjKcWwTpZ4yY+RHIS1b2aFHujWNNmqKfp9QkLKK0QSlzUcZ2OnCcAprnPwovAEmxdWkeTSFTBN7o/dIWOBBmKQIVu7HuwkWEyfVEVy4jTUW46UATcFWt/dKr83e2ugKBAs8FkQmHoSQVGPwNMGbs1Pqt+yAwf+ggMavZb0GRMS1BHAoCzKgoDfV04x6oSXVP+AtTt62ORQ/zOAaL6hBye/fuJIoULiYdZE3V8BJEhChli4qWLgbZnfqwPSHKYVFsx2FJ8AmSzsnkk0pO7cFfgJYukAN7KMcDmpa95O0uIuYH3ixVaeGWtzbSaxfhj51V6kWCGmCzW4ybYnuA9zljmgiPkP8GEmsbkNTAqsWvc2wkdmwyTzVTfUxVAPmZmFTQbeFj/Hcp+b2addSn1/4VtPYkp/qBc7X7gNON2BAjbDOH1TUKz7AY9s88iHQ58wdeUbV8z23bS64y2hu1jvB+gatxzxL1m2U3qbUsGB5sxfT48RvGEqJV6X5IS8Xw3139DV22T+/+xdymz6/RtD2chogG/bGaoB6jgzBnq8rPaE1bsLbrQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR10MB6177.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(966005)(55016003)(83380400001)(5660300002)(8936002)(52536014)(186003)(508600001)(33656002)(316002)(7416002)(19627405001)(9686003)(76116006)(64756008)(66446008)(66476007)(66946007)(26005)(91956017)(166002)(66556008)(6506007)(7696005)(38070700005)(40265005)(38100700002)(86362001)(55236004)(2906002)(53546011)(110136005)(4326008)(122000001)(54906003)(71200400001)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?cEWKrr2UyjIS472clk2w+6O71cE6HeBceB92MC0McQm7EiAcLEh0wDMqkN?= =?iso-8859-1?Q?Rr5QzyhDCVyX4FFKb/JJ3aDBV3rYKDQY8Ql16KvSn9VwA/Aq1lRSA0M15x?= =?iso-8859-1?Q?YunCBVLMZB945kVjxHigMIoVJbIZAbkCiolVnEFTLW5G3mPzjBbNDLC6EV?= =?iso-8859-1?Q?Nf2dFXZ3dxDa/46OXX/M3PlqYuxzuYp5YdE7guTuf8HNAA41xHWZV3+atu?= =?iso-8859-1?Q?l0avmeqrT72vd1+6zuw4UV0ctA81jnyaxv4hDHQAiHODCbvg+GiAUu+6wd?= =?iso-8859-1?Q?XZ8+TE/N3XldYuaJixukVm52zvWVS73I0EEM4xwPGsi0T0XoYi/iSxzyEI?= =?iso-8859-1?Q?8tc+CDocQ4qrndeNi/tFV8hco7u8wjF0f3/NOZx/w24dGHe6tUBweYQnIt?= =?iso-8859-1?Q?axY50o7tH41YIahxmEKmPV2QyXasAPAqNKLyP96wierGpKidvy+Ysvs1fh?= =?iso-8859-1?Q?QToPT9Atfii/Ei8kJF3V5zB8OGuKO9FTZkbUwy8uXBUufZ01GSHwixNLWH?= =?iso-8859-1?Q?Py/Ix+OyYGARDkPD0fBXNvDVKcOShckspmFTs5nQkkM3yh0EA67CZ2AkK8?= =?iso-8859-1?Q?F42nFCNTXjkFYoPlnl6jx9Kj6KJeKdcddi8KA8sbnwM1f3TDByBgjRRVwq?= =?iso-8859-1?Q?eVbtUkEB66bPEf30GRIBTefh/GZWE7TdqAbxirQSKXqhQQlV9K5h7T3Vr5?= =?iso-8859-1?Q?I1eZlho5l6qQNmCF11sMIp0wwq22Vs1/lTZs2FEmz7Osm3WzHDpfrgRvCv?= =?iso-8859-1?Q?vhvySSRvzPKPePt6JoCu5nxL3ETpTzxg0Fubb17ShGFYZE6GvVVaScl5ZT?= =?iso-8859-1?Q?XSF9H093jnTs1NNDb1Tz1vkAgZuJQJRP/1SN5FUz5GTWoWogkkeu6uQjaa?= =?iso-8859-1?Q?tn+VsDQafabrr5jEzC/goRAVt+tD7F5KFZSuHuCOSj9ZW8uDy5X/J8tCjS?= =?iso-8859-1?Q?J8sE65RlRJhSGEu6CrW+j6dRsRKvZTGEvT4xybtHp7qaop0Or6edA5yI7y?= =?iso-8859-1?Q?G3XCVMxK+CxYL23Cf4UhsmW83vReOQHYE9ACysF9gKcZ3K3AkXDS1rzSeZ?= =?iso-8859-1?Q?XCP0t7z3JE7xD6x+p+4VF3LlTDj9/Zy84YwVpECp4gV8GMHBdvzNmmsasL?= =?iso-8859-1?Q?nyL9vcVJAvSJ6RW2gHQwQfhIR89yJY3rx1S/+jhipQHwiMdqBJtOQpvbEi?= =?iso-8859-1?Q?XMMbm2GRtCA9t7Ve/Rb6TaxaJLVfhyqSUGdWmVZeVaD5Ly84/kQyD5e52+?= =?iso-8859-1?Q?Adkn2q6MKgOEShB9GHg4p/FW64bldk6yb21VrAKO8Y8kM+uqNJ4aVvAndO?= =?iso-8859-1?Q?5xCXfBGMLv0Wk3YYh1a1GifuLYsyh4d7dtC7/NPtQso+tK3U+pYOzxbvM0?= =?iso-8859-1?Q?LkgNO3kDbBVivievKpM+qvifej/Mwa5HT6/SM+xGNngZlJsrenDnrQKhaa?= =?iso-8859-1?Q?cRK0g4UldXZcRmCuSfCC3dqbM3vEwKw24oPsM1ljVSUYIDRtPHlY3wB670?= =?iso-8859-1?Q?c5rokjt2NESardKRXyLPapBUfT+gybyng+Y/T0dmox+tX30eGhzMPzIRuq?= =?iso-8859-1?Q?JG2NGKN9vwXLjC2V696j/fAEz201SmOnmDbUEPX/AUtG9wcZNeJa+QbBMY?= =?iso-8859-1?Q?Be4BmkVWNHYUSkjWNJNnjsrKk1gvhxWhzrfZHHf86MFN8wQu8xU4rQirl+?= =?iso-8859-1?Q?XgVCk8MtqA9I8Cgz7/jO84xHjdChJQcHGGsCgN2SbeaiOSLFlI2Aozafwy?= =?iso-8859-1?Q?rfNHyCiJSdv8LMaoDy3f9CJDQHJCVI0ya7r/snZFk+4nTsCihseLbj8mSY?= =?iso-8859-1?Q?BMTBA3GiAw=3D=3D?= Content-Type: multipart/alternative; boundary="_000_DU0PR10MB61777257C9532D1E3155329A83F79DU0PR10MB6177EURP_" MIME-Version: 1.0 X-OriginatorOrg: ST.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB6177.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: d4a4c49f-4c6a-42a0-eb01-08da247355f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 15:18:20.6425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JoKmdFP9Ht+qgU8AYQUHkTMOsSjNui1/WE+NV2e4T1l2i7uffjML6r843Y3oVccXzI1CcxlP4RjphYy73qxsLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR1001MB1183 X-Proofpoint-GUID: d13aj3xHFhY837olcul9rImIuUI8L80z X-Proofpoint-ORIG-GUID: d13aj3xHFhY837olcul9rImIuUI8L80z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-22_04,2022-04-22_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 phishscore=0 suspectscore=0 impostorscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 adultscore=0 clxscore=1011 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204220067 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 823ED20017 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=st.com header.s=STMicroelectronics header.b=CKkmdw57; spf=pass (imf31.hostedemail.com: domain of "prvs=0111a5a18a=patrice.chotard@st.com" designates 185.132.182.106 as permitted sender) smtp.mailfrom="prvs=0111a5a18a=patrice.chotard@st.com"; dmarc=pass (policy=reject) header.from=st.com X-Stat-Signature: rmb4at35f7xph1fqekreahkbkibzrcmk X-HE-Tag: 1650640717-431281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --_000_DU0PR10MB61777257C9532D1E3155329A83F79DU0PR10MB6177EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Arnd Thanks for forwarding this patch. As far as i know, we don't need CONFIG_BINFMT_SHARED_FLAT flag. Tested on stm32f769-disco board You can add my : Tested-by: Patrice Chotard Thanks Patrice ________________________________ De : Arnd Bergmann Envoy=E9 : jeudi 21 avril 2022 09:12 =C0 : Geert Uytterhoeven Cc : Greg Ungerer ; Eric W. Biederman ; Kees Cook ; Niklas Cassel ; Damien Le Moal ; Alexander Viro <= viro@zeniv.linux.org.uk>; Paul Walmsley ; Palmer = Dabbelt ; Albert Ou ; Mike Frysi= nger ; stable@vger.kernel.org ; = linux-fsdevel@vger.kernel.org ; linux-mm@kva= ck.org ; linux-riscv@lists.infradead.org ; Linux-Arch ; linux-m68k ; Linux ARM ; Linux-sh list ; Yoshinori Sato ; Rich Felker ; Sudeep Holla ; Vladimir Murzin ; Jesse Taube ; Giulio Benetti ;= Patrice CHOTARD ; Pierre Yves MORDRET ; Alexandre TORGUE Objet : Re: [PATCH] binfmt_flat: Remove shared library support On Thu, Apr 21, 2022 at 8:52 AM Geert Uytterhoeven w= rote: > On Thu, Apr 21, 2022 at 1:53 AM Greg Ungerer wrote: > > On 21/4/22 00:58, Eric W. Biederman wrote: > > > In a recent discussion[1] it was reported that the binfmt_flat librar= y > > > support was only ever used on m68k and even on m68k has not been used > > > in a very long time. > > > > > > The structure of binfmt_flat is different from all of the other binfm= t > > > implementations becasue of this shared library support and it made > > > life and code review more effort when I refactored the code in fs/exe= c.c. > > > > > > Since in practice the code is dead remove the binfmt_flat shared liba= rary > > > support and make maintenance of the code easier. > > > > > > [1] https://lkml.kernel.org/r/81788b56-5b15-7308-38c7-c7f2502c4e15@li= nux-m68k.org > > > Signed-off-by: "Eric W. Biederman" > > > --- > > > > > > Can the binfmt_flat folks please verify that the shared library suppo= rt > > > really isn't used? > > > > I can definitely confirm I don't use it on m68k. And I don't know of > > anyone that has used it in many years. > > > > > > > Was binfmt_flat being enabled on arm and sh the mistake it looks like= ? > > I think the question was intended to be > > Was *binfmt_flat_shared_flat* being enabled on arm and sh the > mistake it looks like? > > > > > > > arch/arm/configs/lpc18xx_defconfig | 1 - > > > arch/arm/configs/mps2_defconfig | 1 - > > > arch/arm/configs/stm32_defconfig | 1 - > > > arch/arm/configs/vf610m4_defconfig | 1 - Adding stm32, mps2 and imxrt maintainers to Cc, they are the most active armv7-m users and should know if the shared library support is used anywher= e. Arnd ST Restricted --_000_DU0PR10MB61777257C9532D1E3155329A83F79DU0PR10MB6177EURP_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hi Arnd

Thanks for forwarding this patch.

As far as i know, we don't need CONFIG_BINFMT_SHARED_FLAT flag.
Tested on stm32f769-disco board

You can add my :
Tested-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice
De : Arnd Bergmann <arnd= @arndb.de>
Envoy=E9 : jeudi 21 avril 2022 09:12
=C0 : Geert Uytterhoeven <geert@linux-m68k.org>
Cc : Greg Ungerer <gerg@linux-m68k.org>; Eric W. Biederma= n <ebiederm@xmission.com>; Kees Cook <keescook@chromium.org>; N= iklas Cassel <Niklas.Cassel@wdc.com>; Damien Le Moal <damien.lemoa= l@opensource.wdc.com>; Alexander Viro <viro@zeniv.linux.org.uk>; Paul Walmsley <paul.walmsley@sifive.com>; Palmer Dabbelt <palmer@= dabbelt.com>; Albert Ou <aou@eecs.berkeley.edu>; Mike Frysinger &l= t;vapier@gentoo.org>; stable@vger.kernel.org <stable@vger.kernel.org&= gt;; linux-fsdevel@vger.kernel.org <linux-fsdevel@vger.kernel.org>; linux-mm@kvack.org <linux-mm@kvack.org>; linux-riscv@lists.infradead= .org <linux-riscv@lists.infradead.org>; Linux-Arch <linux-arch@vge= r.kernel.org>; linux-m68k <linux-m68k@lists.linux-m68k.org>; Linux= ARM <linux-arm-kernel@lists.infradead.org>; Linux-sh list <linux-sh@vger.kernel.org>; Yoshinori Sato <ysato@users.sourcefor= ge.jp>; Rich Felker <dalias@libc.org>; Sudeep Holla <sudeep.hol= la@arm.com>; Vladimir Murzin <vladimir.murzin@arm.com>; Jesse Taub= e <Mr.Bossman075@gmail.com>; Giulio Benetti <giulio.benetti@benett= iengineering.com>; Patrice CHOTARD <patrice.chotard@st.com>; Pierre Yves MORDRET <pi= erre-yves.mordret@st.com>; Alexandre TORGUE <alexandre.torgue@st.com&= gt;
Objet : Re: [PATCH] binfmt_flat: Remove shared library support
 
On Thu, Apr 21, 2022 at 8:52 AM Geert Uytterhoeven= <geert@linux-m68k.org> wrote:
> On Thu, Apr 21, 2022 at 1:53 AM Greg Ungerer <gerg@linux-m68k.org&g= t; wrote:
> > On 21/4/22 00:58, Eric W. Biederman wrote:
> > > In a recent discussion[1] it was reported that the binfmt_fl= at library
> > > support was only ever used on m68k and even on m68k has not = been used
> > > in a very long time.
> > >
> > > The structure of binfmt_flat is different from all of the ot= her binfmt
> > > implementations becasue of this shared library support and i= t made
> > > life and code review more effort when I refactored the code = in fs/exec.c.
> > >
> > > Since in practice the code is dead remove the binfmt_flat sh= ared libarary
> > > support and make maintenance of the code easier.
> > >
> > > [1] https://lkml.kernel.org/r/81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.o= rg
> > > Signed-off-by: "Eric W. Biederman" <ebiederm@xm= ission.com>
> > > ---
> > >
> > > Can the binfmt_flat folks please verify that the shared libr= ary support
> > > really isn't used?
> >
> > I can definitely confirm I don't use it on m68k. And I don't know= of
> > anyone that has used it in many years.
> >
> >
> > > Was binfmt_flat being enabled on arm and sh the mistake it l= ooks like?
>
> I think the question was intended to be
>
>     Was *binfmt_flat_shared_flat* being enabled on= arm and sh the
>     mistake it looks like?
>
> > >
> > >   arch/arm/configs/lpc18xx_defconfig |  = 1 -
> > >   arch/arm/configs/mps2_defconfig   = ; |   1 -
> > >   arch/arm/configs/stm32_defconfig   |&n= bsp;  1 -
> > >   arch/arm/configs/vf610m4_defconfig |  = 1 -

Adding stm32, mps2 and imxrt maintainers to Cc, they are the most active armv7-m users and should know if the shared library support is used anywher= e.

     Arnd

ST Restricted

--_000_DU0PR10MB61777257C9532D1E3155329A83F79DU0PR10MB6177EURP_--