linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Liu Shixin <liushixin2@huawei.com>,
	Naoya Horiguchi <naoya.horiguchi@nec.com>,
	Miaohe Lin <linmiaohe@huawei.com>,
	Muchun Song <muchun.song@linux.dev>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] mm: hwpoison: support recovery from HugePage copy-on-write faults
Date: Thu, 13 Apr 2023 00:47:37 +0000	[thread overview]
Message-ID: <DS7PR11MB6077389EC65455200379F872FC989@DS7PR11MB6077.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230412233719.GC4759@monkey>

> I do not think cc:stable is necessary/desirable.  Why?
>
> a873dfe1032a was an enhancement to better handle copying pages with memory
> errors in the kernel.  IIUC, we never handled that situation in the past.
> I would not call the fact that it did not take hugetlb into account a bug.
> Although, some might argue that it should have addressed all callers of
> copy_user_highpage which would have included hugetlb.  IMO, There would be
> little to gain by backporing to 6.1 as the issue of copying pages with
> errors has existed forever.  Perhaps Tony will comment as I was not involved
> in a873dfe1032a.

I concur. We are gradually fixing more cases where Linux consumes
poison data in kernel context. But this is an incremental process to
improve overall reliability. Backporting to stable and long term releases
isn't a priority.

-Tony


  reply	other threads:[~2023-04-13  0:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11  9:27 Liu Shixin
2023-04-12  0:26 ` Andrew Morton
2023-04-12 18:13 ` Mike Kravetz
2023-04-12 21:57   ` Andrew Morton
2023-04-12 22:21     ` Mike Kravetz
2023-04-12 22:56       ` Andrew Morton
2023-04-12 23:37         ` Mike Kravetz
2023-04-13  0:47           ` Luck, Tony [this message]
2023-04-13  1:55         ` Liu Shixin
2023-04-13  1:51       ` Liu Shixin
2023-04-13  1:49     ` Liu Shixin
2023-04-13 12:57   ` Jiaqi Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DS7PR11MB6077389EC65455200379F872FC989@DS7PR11MB6077.namprd11.prod.outlook.com \
    --to=tony.luck@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liushixin2@huawei.com \
    --cc=mike.kravetz@oracle.com \
    --cc=muchun.song@linux.dev \
    --cc=naoya.horiguchi@nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox