From: Brendan Jackman <jackmanb@google.com>
To: Bala-Vignesh-Reddy <reddybalavignesh9979@gmail.com>,
<akpm@linux-foundation.org>, <shuah@kernel.org>,
<richard.weiyang@gmail.com>
Cc: <david.shane.hunter@gmail.com>, <khalid@kernel.org>,
<Liam.Howlett@oracle.com>, <davem@davemloft.net>,
<david@redhat.com>, <edumazet@google.com>, <gnoack@google.com>,
<horms@kernel.org>, <kuba@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-security-module@vger.kernel.org>,
<lorenzo.stoakes@oracle.com>, <mhocko@suse.com>,
<mic@digikod.net>, <ming.lei@redhat.com>, <pabeni@redhat.com>,
<surenb@google.com>, <vbabka@suse.cz>,
<linux-kernel-mentees@lists.linux.dev>
Subject: Re: [PATCH v3] selftests: complete kselftest include centralization
Date: Tue, 06 Jan 2026 12:29:08 +0000 [thread overview]
Message-ID: <DFHI984SEFV3.2JL88CLHNT2SO@google.com> (raw)
In-Reply-To: <20251016104409.68985-1-reddybalavignesh9979@gmail.com>
On Thu Oct 16, 2025 at 10:44 AM UTC, Bala-Vignesh-Reddy wrote:
> This follow-up patch completes centralization of kselftest.h and
> ksefltest_harness.h includes in remaining seltests files, replacing all
> relative paths with a non-relative paths using shared -I include path
> in lib.mk
This seems to be breaking the x86 build for me:
❯❯ git checkout e6fbd1759c9ece5044d3470f30a5e2166dc9de89
❯❯ make -j mrproper
❯❯ make -sj100 defconfig
❯❯ make -sj100 headers
❯❯ make -sj100 -C tools/testing/selftests TARGETS="x86"
In file included from syscall_nt.c:17:
helpers.h:10:10: fatal error: kselftest.h: No such file or directory
10 | #include "kselftest.h"
| ^~~~~~~~~~~~~
[...]
❯❯ git checkout HEAD^
❯❯ make -sj100 -C tools/testing/selftests TARGETS="x86"
[builds]
If I just revert all the changes to tools/testing/selftests/x86/, it
builds again.
prev parent reply other threads:[~2026-01-06 12:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 14:47 [PATCH 0/2] selftests: Centralize kselftest headers to avoid relative includes Bala-Vignesh-Reddy
2025-08-27 14:47 ` [PATCH 1/2] selftests: Centralize include path for kselftest.h and kselftest_harness.h Bala-Vignesh-Reddy
2025-08-27 14:47 ` [PATCH 2/2] selftests: Replace relative includes with non-relative " Bala-Vignesh-Reddy
2025-08-28 8:10 ` Wei Yang
2025-08-28 9:40 ` Bala-Vignesh-Reddy
2025-08-29 1:43 ` Wei Yang
2025-08-29 10:53 ` Bala-Vignesh-Reddy
2025-08-30 0:55 ` Wei Yang
2025-08-27 22:56 ` [PATCH 0/2] selftests: Centralize kselftest headers to avoid relative includes Andrew Morton
2025-08-30 16:39 ` [PATCH v2 " Bala-Vignesh-Reddy
2025-08-30 16:39 ` [PATCH v2 1/2] selftests: Centralize include path for kselftest.h and kselftest_harness.h Bala-Vignesh-Reddy
2025-08-30 22:30 ` Wei Yang
2025-08-30 16:39 ` [PATCH v2 2/2] selftests: Replace relative includes with non-relative " Bala-Vignesh-Reddy
2025-08-30 22:31 ` Wei Yang
2025-08-31 20:03 ` Andrew Morton
2025-09-01 2:58 ` Bala-Vignesh-Reddy
2025-10-16 10:44 ` [PATCH v3] selftests: complete kselftest include centralization Bala-Vignesh-Reddy
2026-01-06 12:29 ` Brendan Jackman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFHI984SEFV3.2JL88CLHNT2SO@google.com \
--to=jackmanb@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=david.shane.hunter@gmail.com \
--cc=david@redhat.com \
--cc=edumazet@google.com \
--cc=gnoack@google.com \
--cc=horms@kernel.org \
--cc=khalid@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=mic@digikod.net \
--cc=ming.lei@redhat.com \
--cc=pabeni@redhat.com \
--cc=reddybalavignesh9979@gmail.com \
--cc=richard.weiyang@gmail.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox