From: Morduan Zang <zhangdandan@uniontech.com>
To: wangqing7171@gmail.com
Cc: urezki@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzbot+37b7f6cd519f7fb8d32a@syzkaller.appspotmail.com
Subject: Re: [PATCH] mm/vmalloc: fix KMSAN uninit-value warning in decay_va_pool_node()
Date: Fri, 3 Apr 2026 11:30:17 +0800 [thread overview]
Message-ID: <DFF3B3301CBB8797+20260403033017.23370-1-zhangdandan@uniontech.com> (raw)
In-Reply-To: <20260403025614.2032877-1-wangqing7171@gmail.com>
On Fri, 03 Apr 2026, Qing Wang wrote:
> First, va->list is inserted into the list_head when insert_vmap_area()
> calls link_va(). However, if find_va_links() returns NULL, link_va()
> will not be called, leaving va->list uninitialized.
>
> Second, even if link_va() is called, list_add() will still invoke
> __list_add_valid() which reads va->list fields (prev/next). Under KMSAN,
> this will also report a same uninit-value error.
Hi Qing,
While adding INIT_LIST_HEAD(&va->list) in alloc_vmap_area() would indeed
silence the KMSAN warning, I'm concerned that it might only be masking
a deeper issue rather than fixing the root cause.
It seems that the uninitialized access in decay_va_pool_node() suggests
a potential race condition where nodes from a concurrently repopulated
pool might be lost or the list structure could be incorrectly overwritten
during list_replace_init().
Instead of just initializing the list head to satisfy KMSAN, should we
consider modifying decay_va_pool_node() to avoid using list_replace_init()
which might drop concurrent repopulate nodes? Perhaps using list_splice()
or a proper merge of the leftover VAs would be a more robust fix for
the underlying synchronization issue.
What do you and Uladzislau think?
Best regards,
Morduang
next prev parent reply other threads:[~2026-04-03 3:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 8:14 Qing Wang
2026-04-02 10:31 ` Uladzislau Rezki
2026-04-02 15:45 ` Uladzislau Rezki
2026-04-03 2:56 ` Qing Wang
2026-04-03 3:30 ` Morduan Zang [this message]
2026-04-03 3:50 ` Qing Wang
2026-04-03 3:14 ` Qing Wang
2026-04-03 7:52 ` [PATCH] mm/vmalloc: fix KMSAN uninit in decay_va_pool_node list handling chenyichong
2026-04-03 10:55 ` Uladzislau Rezki
2026-04-03 17:22 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFF3B3301CBB8797+20260403033017.23370-1-zhangdandan@uniontech.com \
--to=zhangdandan@uniontech.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+37b7f6cd519f7fb8d32a@syzkaller.appspotmail.com \
--cc=urezki@gmail.com \
--cc=wangqing7171@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox