From: William Kucharski <william.kucharski@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: Introduce page_size()
Date: Thu, 3 Jan 2019 03:47:02 -0700 [thread overview]
Message-ID: <DFC451D4-9262-4538-A14E-4B05932C2D6C@oracle.com> (raw)
In-Reply-To: <20190102130932.GH6310@bombadil.infradead.org>
> On Jan 2, 2019, at 6:09 AM, Matthew Wilcox <willy@infradead.org> wrote:
>
> I'm not sure I agree with that. It's going to depend on exactly what this
> code is doing; I can definitely see there being places in the VM where we
> care about how this page is currently mapped, but I think those places
> are probably using the wrong interface (get_user_pages()) and should
> really be using an interface which doesn't exist yet (get_user_sg()).
Fair enough; I also agree the VM_BUG_ON for tail pages might be a good safety
measure, at least to see if anyone ends up calling page_size() that way at present.
next prev parent reply other threads:[~2019-01-03 10:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 13:42 Matthew Wilcox
2018-12-31 23:02 ` Kirill A. Shutemov
2019-01-01 6:39 ` Matthew Wilcox
2019-01-01 20:11 ` Zi Yan
2019-01-02 0:58 ` Matthew Wilcox
2019-01-02 1:16 ` Zi Yan
2019-01-01 3:27 ` Aneesh Kumar K.V
2019-01-01 3:27 ` Aneesh Kumar K.V
2019-01-01 6:30 ` Matthew Wilcox
2019-01-01 10:11 ` Aneesh Kumar K.V
2019-01-02 3:14 ` Matthew Wilcox
2019-01-02 11:46 ` William Kucharski
2019-01-02 13:09 ` Matthew Wilcox
2019-01-03 10:47 ` William Kucharski [this message]
2019-01-01 10:15 ` Aneesh Kumar K.V
2019-05-10 18:12 Matthew Wilcox
2019-05-13 10:56 ` Michal Hocko
2019-05-13 12:43 ` Kirill Tkhai
2019-05-14 11:53 ` William Kucharski
2019-05-22 20:03 ` Andrew Morton
2019-05-23 1:55 ` Matthew Wilcox
2019-05-23 21:33 ` Andrew Morton
2019-05-23 21:44 ` Matthew Wilcox
2019-05-24 6:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFC451D4-9262-4538-A14E-4B05932C2D6C@oracle.com \
--to=william.kucharski@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox