From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6DFCC54ED1 for ; Fri, 23 May 2025 03:28:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 653826B00B1; Thu, 22 May 2025 23:28:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DC636B00B2; Thu, 22 May 2025 23:28:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CC486B00B3; Thu, 22 May 2025 23:28:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2C80A6B00B1 for ; Thu, 22 May 2025 23:28:11 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DBC0DBEE5B for ; Fri, 23 May 2025 03:28:10 +0000 (UTC) X-FDA: 83472739140.24.9A9FCB1 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) by imf16.hostedemail.com (Postfix) with ESMTP id 9839A180004 for ; Fri, 23 May 2025 03:28:07 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VmCNDU6R; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747970889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OkBBGRiZvHopGFHqemEWcoi8ZXJj13K2xBFdk1g5S+M=; b=1vUgxAhCdIUS9zS7saw/+7VpKzuvuu3ODcWoqmQ0J70qniM7e+QJgU2GuE43mNdWkmFzkO CxYiAsIARqN4vw9fG1T5p7pDTffvUiLyAFrsEMEj59o7rrsmbhOEJqCw5D2Vi9KsCI7XLw wZ3u9zn8x+wC/OyxV3303RAxcJzBLRQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VmCNDU6R; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747970889; a=rsa-sha256; cv=none; b=VSQULqtnxreffOOUg/B1NxD5I6kAeWPzWvL3g3MC9uPrKfHFBPXEvurTJeHecSQ+dEZ8PY zuoyRG9UF9igWuSKPR/emLEVw1K4XKM5UCAngw/FHZrjibtofhl28K8ixuQKXv38IKgqVi h91qNaOQ81rdH6xOjut9YypSu1K82v0= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747970885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OkBBGRiZvHopGFHqemEWcoi8ZXJj13K2xBFdk1g5S+M=; b=VmCNDU6ReO//kpfia09uvQ9HWShRmKAi1aepryhQ/5NqYAzKKISirb7T78Ee0+sC3DtLaD Hh8ae1Y0ugChF7y46eXppHgzx5DLbsF/RfaISMHTkCesJatFoMTb1bQHX20RAvFBOLQtc8 mnBqQeCA4H7+twGAjYZrrbNfME9If1w= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) Subject: Re: [PATCH] mm/hugetlb: fix kernel NULL pointer dereference when replacing free hugetlb folios X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Fri, 23 May 2025 11:27:18 +0800 Cc: Ge Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn Content-Transfer-Encoding: quoted-printable Message-Id: References: <1747884137-26685-1-git-send-email-yangge1116@126.com> <644FF836-9DC7-42B4-BACE-C433E637B885@linux.dev> <3B8641A1-5345-44A5-B610-9BCBC980493D@linux.dev> To: Oscar Salvador X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 9839A180004 X-Rspamd-Server: rspam09 X-Stat-Signature: rxwufnwwkxnh3uhierdhm1mz7p6dibnx X-HE-Tag: 1747970887-62251 X-HE-Meta: U2FsdGVkX18XshNvMVOSRYko8WUFASbVVpwLoxp03ZhkllPSD99uC5Qz5s+JmrUM+BZrxPKK++ghY8ha+/wJn7jg/lSxhSlmWooBGLNtsTCOE8WD0PJv43+GyTzAgMLKmc2wAxvno0F+rFd8htNBQzESiRlclCM0QqYwjpv84MW3x75JTu1n2n+QyD9/uU5eAk2UXgrGpfhrItWyDfmbI9x91zBcHrk8n6CXm46m5nJPao5pQh7vzFdzrnzSPVCJwL7of9tucwAkOS60utcBqhRvh+1Pk7TYz/hAmn3YReVUhf7QJYZiBuWAO2nWs4iK7Hl61mMW01WAXmQk6NnreQ+jsVcg0gMymQ1efAT8E1h+lQH2K+2CwubrpXgahuItmeguTfQHyb5HkUhjzct2OYFPqA0COD02zNbZnLTKBpxg/0fw0ksgLKpwEFDxDbluJy8M9yTGFgZJ5OcnAtPDUyOy+IUF2xdYTMMOSmi+F8Iv/71EQ7hxSV+x3tuHbszUTSp2Is90c7AWZJi92au2xrewUd4sa1Y75r5rpPQQmYXh6Ll4wG5u4DG/6l6dsRmMYsHTQOQXtFcyZv7BBm1xkOltmv2LhOH8/RFxhEjk5W0ztKEcRsOND9yGc5iN93pJxZcbdhJUcN2EPp0W12dCjNCdGmcfDZ3nLcIhdwkM1DajAQW9y6oN2/5QAwlkRnnMLZunGj7h2037/MILz+ID/gfOrGRZsLUnjF8w2xVnOc4RPcLjGJBQ1rx306CtoiZ1p5TwnmVWKDVOJDxX8x9bhYNZxlpsVkRAFwHoPn+0sbfkESfn1A95xvNXrhIngHd9Chy/O3d4TQ2y2e3R+hWdSuBsNme6xF7yGXoG52RckFTS9FnTgiJ8dogEAtLbI3EjeEM7tsEJGTndcq8UONdYwUqqHnIeEDRgOpWy+Bbcz8xn73aFWsBkTcolkWyorMw1DW++eHtwNhK+3yD+BDh svxXHMZG xYT+r3kICVkL6HxoQ6JbP0HA9S+yrMDeeQ+m7pey4Kd9SfCpJdpIzGGcC8END5+e3LCwSf6LGboFRPfIF4nhd47QYJq28c26fagsAGtfaxqf0fABI3iZzCpULFgCYMKMwlJ3nqHtUpqgx85Y41YkQt99wJutjUmTCVT/Wzknz3ecfx/wTBICAHOdXoOrRHjJuZ8jKezFZWKWeeh/xykFldoul4FUAABHjcWK2eJ7J7mVNRtpoLImKmGx7bw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On May 23, 2025, at 03:32, Oscar Salvador wrote: >=20 > On Thu, May 22, 2025 at 08:39:39PM +0800, Muchun Song wrote: >> But I think we could use "folio_order() > MAX_PAGE_ORDER" to replace = the check >> of hstate_is_gigantic(), right? Then ee could remove the first = parameter of hstate >> from alloc_and_dissolve_hugetlb_folio() and obtain hstate in it. >=20 > Yes, I think we can do that. > So something like the following (compily-tested only) maybe? >=20 > =46rom d7199339e905f83b54d22849e8f21f631916ce94 Mon Sep 17 00:00:00 = 2001 > From: Oscar Salvador > Date: Thu, 22 May 2025 19:51:04 +0200 > Subject: [PATCH] TMP >=20 > --- > mm/hugetlb.c | 38 +++++++++----------------------------- > 1 file changed, 9 insertions(+), 29 deletions(-) Pretty simple. The code LGTM. Thanks.=