From: Brendan Jackman <jackmanb@google.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
Brendan Jackman <jackmanb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/vmalloc: clarify why vmap_range_noflush() might sleep
Date: Mon, 08 Dec 2025 07:39:39 +0000 [thread overview]
Message-ID: <DESNXS1K25LW.2E7ZWFWV56PZD@google.com> (raw)
In-Reply-To: <96aa9bf7-1f1d-4870-90d2-84d3d6d4254c@arm.com>
Hi Anshuman, thanks a lot for taking a look.
On Mon Dec 8, 2025 at 6:41 AM UTC, Anshuman Khandual wrote:
> Please add <asm-generic/pgalloc.h> in mm/vmalloc.c - otherwise it does not
> get built as GFP_PGTABLE_KERNEL is not available. But otherwise LGTM.
Oh, but that's not correct, IIUC we shouldn't directly be including
asm-generic headers from here.
So while in principle GFP_PGTABLE_KERNEL is a sensible common
demoninator here, it doesn't actually exist at all everywhere, e.g. it
doesn't look like m68k defines it for Motorola.
So maybe the best way here is a really vague:
/*
* Different archs allocate pagetables in different ways, assume
* GFP_KERNEL as a common denominator.
*/
might_alloc(GFP_KERNEL)
... a bit yucky but I think still useful.
Any thoughts?
next prev parent reply other threads:[~2025-12-08 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 5:19 Brendan Jackman
2025-12-08 6:41 ` Anshuman Khandual
2025-12-08 7:39 ` Brendan Jackman [this message]
2025-12-08 17:32 ` Uladzislau Rezki
2025-12-08 8:51 ` [syzbot ci] " syzbot ci
2025-12-09 2:56 ` Brendan Jackman
2025-12-09 1:10 ` [PATCH] " kernel test robot
2025-12-09 1:52 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DESNXS1K25LW.2E7ZWFWV56PZD@google.com \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox