From: Muchun Song <muchun.song@linux.dev>
To: Yu Zhao <yuzhao@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel test robot <oliver.sang@intel.com>,
Janosch Frank <frankja@linux.ibm.com>,
Marc Hartmayer <mhartmay@linux.ibm.com>
Subject: Re: [PATCH mm-unstable v1] mm/hugetlb_vmemmap: don't synchronize_rcu() without HVO
Date: Fri, 19 Jul 2024 14:18:26 +0800 [thread overview]
Message-ID: <DE0EB84C-B69E-4FA0-8CBC-516BEB821BDE@linux.dev> (raw)
In-Reply-To: <20240719042503.2752316-1-yuzhao@google.com>
> On Jul 19, 2024, at 12:25, Yu Zhao <yuzhao@google.com> wrote:
>
> hugetlb_vmemmap_optimize_folio() and hugetlb_vmemmap_restore_folio()
> are wrappers meant to be called regardless of whether HVO is enabled.
> Therefore, they should not call synchronize_rcu(). Otherwise, it
> regresses use cases not enabling HVO.
>
> So move synchronize_rcu() to __hugetlb_vmemmap_optimize_folio() and
> __hugetlb_vmemmap_restore_folio(), and call it once for each batch of
> folios when HVO is enabled.
>
> Fixes: bd225530a4c7 ("mm/hugetlb_vmemmap: fix race with speculative PFN walkers")
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202407091001.1250ad4a-oliver.sang@intel.com
> Reported-by: Janosch Frank <frankja@linux.ibm.com>
> Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> Signed-off-by: Yu Zhao <yuzhao@google.com>
Acked-by: Muchun Song <muchun.song@linux.dev>
Thanks.
prev parent reply other threads:[~2024-07-19 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 4:25 Yu Zhao
2024-07-19 6:18 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE0EB84C-B69E-4FA0-8CBC-516BEB821BDE@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=frankja@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhartmay@linux.ibm.com \
--cc=oliver.sang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox