From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A628C28CC0 for ; Thu, 30 May 2019 17:23:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B90E925E5D for ; Thu, 30 May 2019 17:23:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="IIt0PtrH"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="FMiOBCG6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B90E925E5D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=fb.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C0406B026E; Thu, 30 May 2019 13:23:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 471EF6B026F; Thu, 30 May 2019 13:23:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 312436B0270; Thu, 30 May 2019 13:23:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by kanga.kvack.org (Postfix) with ESMTP id E8A0F6B026E for ; Thu, 30 May 2019 13:23:56 -0400 (EDT) Received: by mail-pl1-f197.google.com with SMTP id d2so4340511pla.18 for ; Thu, 30 May 2019 10:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:dkim-signature:from:to:cc:subject :thread-topic:thread-index:date:message-id:references:in-reply-to :accept-language:content-language:content-id :content-transfer-encoding:mime-version; bh=p/Ukfbxd3jQZ8Ife0hv45+W30kQmJn7dbk2U+rff9fY=; b=MUJwjhkxw4rwhTGgQTCgNqd8nY0fnGG8RQaM9gClG+xUnE5a7m2MOFFcIXE8CnkJp3 gsnlV2Xd2z3GpB20vXJImZw/nijwm2ceyJlFcI8m14LIzai+oEzlhRMG5a84wkYLc/F9 aoi/Cy/n69i61lQ4VriQB6lYCckQ+vD5BilWS62p8gV12hPMg5EOQRNTyAL90IjW05nu lQ6FEl961t7c4dpRFagZCxWel0PMThH/ZAhFva+8wMh8nWJ3yz74oqF1aJnOwBsKxEpq SPpDmKqa34sshjjQn0aIIkKnddAcggKTzrYg8tcBZg4OvKkFkaVtyEHIThzDotqs/UaM lLJg== X-Gm-Message-State: APjAAAWGVIq9OF4fB/oO7lGWVsnoii9rSw9WG5jXvsqum9DNDa5smr42 K9/j5U2WGKHjz9ImAMlZpZ59ijvr8S+5KnxYUPXqFMSz+TmcQ3ioLJwAEI6gaRHosqopzYhjsJ3 OrJ+loc4u9r2mhTPCJiMnB1/awXlQO/T2XgpYPjBRxZ2S8/j1qB2e6mWYa9KGLGB4DA== X-Received: by 2002:a63:a1f:: with SMTP id 31mr4597085pgk.233.1559237036556; Thu, 30 May 2019 10:23:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwGcRrR01uszrcaPjkd/Ex7R5LIPflvmG7WetoRq+JomQexk0LHyPdevi2ga1L9EkTN5ixq X-Received: by 2002:a63:a1f:: with SMTP id 31mr4597044pgk.233.1559237035883; Thu, 30 May 2019 10:23:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559237035; cv=none; d=google.com; s=arc-20160816; b=u7twHDaKpHpYganmHZVJOwxR7RUrQhppdYSD9H91JQN2GWFt4poR/wU4n3RRmKt6bu H52h9RjP/RKzL/p9FrvqNOtGT9P3amH1LlUsybVb+9I0ItJR0cjlZEpoXp79x9pDcCzz 4eti98fWz1wgWLLuQO9HeNoilm1O8X3ewHmqXoFT6p4A8mwO9hjgfF72D7HeKfMB4wKh 0vTsmIaDF1W9fcoZNQzKugBb5KdouO8bzgE2lxdZij09cQhb7z96RgK6EjSu85L37Euv 4upTWjmhRLNi7Dr8b5l3D1w2h5tveljKNTEtQswy17YrpwYVBar7SPIfUEHAvMnSgUm/ lZjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-id:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature:dkim-signature; bh=p/Ukfbxd3jQZ8Ife0hv45+W30kQmJn7dbk2U+rff9fY=; b=e1DoZepCIO8NEU1yYVxqZmkD+kiixu/0fl//egA7k6JB9fQLRhl6PGgFKJ/P8b2FXn 258eLErsl4guYtaE17ZXX008lRM63cbcKnS0asEocPDPK84e7hR4pAgT3/yyhkbSmmXp fyqjPa1N5yst7qH4LsJu9PPd1vd8acJ4ZvrPbYlHFRWxcz2jk93VcFF4e+/JSFinWISy 8kcz1dt//q0nEQ2+3jUsnfj6UI6tVwYWfWQYnFjbHgBq0E7POF2PD0CWI014diVXAFMT +TJAUPUUmzWQcuqhQYcrpVCHt9SmUHzBp6QpIUgh69P9ypFbGRwtNBETq8ZSgMY3zl2C 9d6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=IIt0PtrH; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector1-fb-onmicrosoft-com header.b=FMiOBCG6; spf=pass (google.com: domain of prvs=105329df1d=songliubraving@fb.com designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=105329df1d=songliubraving@fb.com"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com. [67.231.145.42]) by mx.google.com with ESMTPS id n65si3332949pji.53.2019.05.30.10.23.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 May 2019 10:23:55 -0700 (PDT) Received-SPF: pass (google.com: domain of prvs=105329df1d=songliubraving@fb.com designates 67.231.145.42 as permitted sender) client-ip=67.231.145.42; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=IIt0PtrH; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector1-fb-onmicrosoft-com header.b=FMiOBCG6; spf=pass (google.com: domain of prvs=105329df1d=songliubraving@fb.com designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=105329df1d=songliubraving@fb.com"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4UHJeVi031730; Thu, 30 May 2019 10:23:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=p/Ukfbxd3jQZ8Ife0hv45+W30kQmJn7dbk2U+rff9fY=; b=IIt0PtrHITx553H2RKghWXYX3nFZW4lKRIUuEpTkrpqNQHFFxhh3RK5iZ1aBz7TfQfv7 LF2azEdh4J1KTm74RgXnSLBCVkd1RS6+gOZ4mm6goElxfiRi8KxHQefwCGeKfrlVHJUV yhORulLNPq4COlKCHHMa6NkhB8bJfNlkE1s= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com with ESMTP id 2stf3x8ymu-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 30 May 2019 10:23:22 -0700 Received: from ash-exopmbx201.TheFacebook.com (2620:10d:c0a8:83::8) by ash-exhub201.TheFacebook.com (2620:10d:c0a8:83::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 30 May 2019 10:23:17 -0700 Received: from ash-exhub202.TheFacebook.com (2620:10d:c0a8:83::6) by ash-exopmbx201.TheFacebook.com (2620:10d:c0a8:83::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 30 May 2019 10:23:17 -0700 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (100.104.31.183) by o365-in.thefacebook.com (100.104.36.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 30 May 2019 10:23:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p/Ukfbxd3jQZ8Ife0hv45+W30kQmJn7dbk2U+rff9fY=; b=FMiOBCG6TWm/uLxLhqhWBXEOe2NpCo/+RgJzT8xkPmWIb6fvvHRW6xcvA9z8ifG9vyuc3L12RusbvS8Jjag8hzF2tzi4DcVtfrfm+WDcbtGmguFyvBWMGok08TYXdF4aQsPBDz4kNFoDWCtQGXMfQ5Uxaho3EIZIOnjtMiqLg0M= Received: from BN6PR15MB1154.namprd15.prod.outlook.com (10.172.208.137) by BN6PR15MB1539.namprd15.prod.outlook.com (10.172.151.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.16; Thu, 30 May 2019 17:23:15 +0000 Received: from BN6PR15MB1154.namprd15.prod.outlook.com ([fe80::adc0:9bbf:9292:27bd]) by BN6PR15MB1154.namprd15.prod.outlook.com ([fe80::adc0:9bbf:9292:27bd%2]) with mapi id 15.20.1922.021; Thu, 30 May 2019 17:23:15 +0000 From: Song Liu To: "Kirill A. Shutemov" CC: linux-kernel , "linux-mm@kvack.org" , "namit@vmware.com" , "peterz@infradead.org" , "oleg@redhat.com" , "rostedt@goodmis.org" , "mhiramat@kernel.org" , "matthew.wilcox@oracle.com" , "kirill.shutemov@linux.intel.com" , Kernel Team , "william.kucharski@oracle.com" , "chad.mynhier@oracle.com" , "mike.kravetz@oracle.com" Subject: Re: [PATCH uprobe, thp 1/4] mm, thp: allow preallocate pgtable for split_huge_pmd_address() Thread-Topic: [PATCH uprobe, thp 1/4] mm, thp: allow preallocate pgtable for split_huge_pmd_address() Thread-Index: AQHVFma9gbzZ2z2z40KErGQDdtT9DaaDg7aAgAABHwCAAGcWAA== Date: Thu, 30 May 2019 17:23:15 +0000 Message-ID: References: <20190529212049.2413886-1-songliubraving@fb.com> <20190529212049.2413886-2-songliubraving@fb.com> <20190530111015.bz2om5aelsmwphwa@box> <20190530111416.ph6xqd4anjlm54i6@box> In-Reply-To: <20190530111416.ph6xqd4anjlm54i6@box> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3445.104.11) x-originating-ip: [2620:10d:c090:200::3:bc80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c81fb8be-ffc4-4034-1ee9-08d6e5238005 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:BN6PR15MB1539; x-ms-traffictypediagnostic: BN6PR15MB1539: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1417; x-forefront-prvs: 00531FAC2C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(51914003)(476003)(256004)(71200400001)(71190400001)(2906002)(25786009)(54906003)(2616005)(57306001)(76176011)(66556008)(50226002)(7736002)(76116006)(486006)(46003)(91956017)(6506007)(99286004)(102836004)(73956011)(316002)(53546011)(33656002)(66476007)(66946007)(6116002)(7416002)(186003)(14444005)(305945005)(11346002)(6916009)(6246003)(66446008)(81166006)(83716004)(81156014)(478600001)(36756003)(8676002)(82746002)(68736007)(6436002)(6512007)(53936002)(86362001)(4326008)(14454004)(229853002)(6486002)(8936002)(5660300002)(64756008)(446003)(14583001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1539;H:BN6PR15MB1154.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6976WPZ4NMq/RLvEQNBXsJG5dgGt/lKAsMXQWoZw45AvGM6JlkVOjkyCIpbH7hDN4hX5eIbAkD1SmnwBYKjeI3ArbAta2rgIffAZ5WqHL9tF2q54UxFcJqFwtPmWKVzgCTY90BRevumN+Mhf+yuAax0wyOc42ec4zBJPJIMH92e5P8xzvbj9WBjhyadPdBVSibs0nhwWNvWPwSFO0DccB+tOQtf4oXnX5nkuJuW80ffd70bTmv5QYc9Zua/uHs0i0DlviksuVSoeGIZZ/MTyadIuadFeCPoYEwEpX8rWbIIza5KV4bb6ZcDIWVy0/QMbl07DnqLUxmwAhy4KZ5/uTjHwYoGg7nwSeF6zQr79w51ecDW4PIoDqUp+kUy6q1BGb7JSYYyIkc+IohcM9tEjHL55Hn1JOxNpI8J9wAOzxpQ= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c81fb8be-ffc4-4034-1ee9-08d6e5238005 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2019 17:23:15.2457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: songliubraving@fb.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1539 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-30_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300122 X-FB-Internal: deliver X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On May 30, 2019, at 4:14 AM, Kirill A. Shutemov wr= ote: >=20 > On Thu, May 30, 2019 at 02:10:15PM +0300, Kirill A. Shutemov wrote: >> On Wed, May 29, 2019 at 02:20:46PM -0700, Song Liu wrote: >>> @@ -2133,10 +2133,15 @@ static void __split_huge_pmd_locked(struct vm_a= rea_struct *vma, pmd_t *pmd, >>> VM_BUG_ON_VMA(vma->vm_end < haddr + HPAGE_PMD_SIZE, vma); >>> VM_BUG_ON(!is_pmd_migration_entry(*pmd) && !pmd_trans_huge(*pmd) >>> && !pmd_devmap(*pmd)); >>> + /* only file backed vma need preallocate pgtable*/ >>> + VM_BUG_ON(vma_is_anonymous(vma) && prealloc_pgtable); >>>=20 >>> count_vm_event(THP_SPLIT_PMD); >>>=20 >>> - if (!vma_is_anonymous(vma)) { >>> + if (prealloc_pgtable) { >>> + pgtable_trans_huge_deposit(mm, pmd, prealloc_pgtable); >>> + mm_inc_nr_pmds(mm); >>> + } else if (!vma_is_anonymous(vma)) { >>> _pmd =3D pmdp_huge_clear_flush_notify(vma, haddr, pmd); >>> /* >>> * We are going to unmap this huge page. So >>=20 >> Nope. This going to leak a page table for architectures where >> arch_needs_pgtable_deposit() is true. >=20 > And I don't there's correct handling of dirty bit. >=20 > And what about DAX? Will it blow up? I think so. >=20 Let me look into these cases. Thanks for the feedback! Song > --=20 > Kirill A. Shutemov