From: Brendan Jackman <jackmanb@google.com>
To: Ujwal Kundur <ujwal.kundur@gmail.com>,
<akpm@linux-foundation.org>, <peterx@redhat.com>,
<david@redhat.com>, <lorenzo.stoakes@oracle.com>,
<Liam.Howlett@oracle.com>, <vbabka@suse.cz>, <rppt@kernel.org>,
<surenb@google.com>, <mhocko@suse.com>, <shuah@kernel.org>
Cc: <linux-mm@kvack.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct
Date: Thu, 21 Aug 2025 12:44:14 +0000 [thread overview]
Message-ID: <DC845LPNX9EW.248S4JXKRUJAP@google.com> (raw)
In-Reply-To: <20250817065211.855-1-ujwal.kundur@gmail.com>
On Sun Aug 17, 2025 at 6:52 AM UTC, Ujwal Kundur wrote:
> Refactor macros and non-composite global variable definitions into a
> struct that is defined at the start of a test and is passed around
> instead of relying on global vars.
Hey sorry for the delayed response here.
Based on doing a range-diff vs the v4 that I reviewed this LGTM,
thanks!
Reviewed-By: Brendan Jackman <jackmanb@google.com>
next prev parent reply other threads:[~2025-08-21 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-17 6:52 Ujwal Kundur
2025-08-18 7:56 ` David Hildenbrand
2025-08-21 12:44 ` Brendan Jackman [this message]
2025-08-28 12:37 ` Brendan Jackman
2025-08-28 18:49 ` Liam R. Howlett
2025-08-28 22:54 ` Andrew Morton
2025-08-29 8:07 ` Brendan Jackman
2025-08-29 15:29 ` Ujwal Kundur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC845LPNX9EW.248S4JXKRUJAP@google.com \
--to=jackmanb@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=ujwal.kundur@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox