From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F056C83F17 for ; Tue, 15 Jul 2025 16:12:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA9086B0089; Tue, 15 Jul 2025 12:12:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B80FD6B0093; Tue, 15 Jul 2025 12:12:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABD706B0099; Tue, 15 Jul 2025 12:12:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 99DF46B0089 for ; Tue, 15 Jul 2025 12:12:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4A00C1D90C0 for ; Tue, 15 Jul 2025 16:12:24 +0000 (UTC) X-FDA: 83666991408.02.EB6993A Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf24.hostedemail.com (Postfix) with ESMTP id A3060180008 for ; Tue, 15 Jul 2025 16:12:22 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="DHryj5/M"; spf=pass (imf24.hostedemail.com: domain of dakr@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752595942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6A5LqusL7wmJyTqNmpWA1eBlORYcHYzaLkEs8PDBmyw=; b=iZkqJ6x6oNHNnMCY5BcSVgbagBhcCT83sjAL6df63xk09Y7aZxMiSnnpTCTbVvpv3oDsFr hjF4YPf9c/HscMhyMPLqzxmOgLmRQM65k1anKVhHpH/dRd2o1aiJXq8LQ65wr7jhb2U0vj 6efBj43Rc6TaiLOTiG5eGskAbkI3l4E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752595942; a=rsa-sha256; cv=none; b=adxXxujxDElqoovbKfB/NuNJ6Fhd41q2bMRN9RlhhWQFp55WS5ItGD7IbgDOFBwWI0WgYg nHdeODv3ew/TfeOjgL7+msgahGEimVw2INEumckrRmMRJAjma90WqJ4hGVqEFZDf+TQrUY CEWp2q4I/nYr4LyegjUDNcLcS0kzrdc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="DHryj5/M"; spf=pass (imf24.hostedemail.com: domain of dakr@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8739E4563E; Tue, 15 Jul 2025 16:12:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D987C4CEF1; Tue, 15 Jul 2025 16:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752595941; bh=S6NeTh0N+OJFfOpss2s8lIkigkMHFd/akf+52X3RrsU=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=DHryj5/M1MASVx/6obu/6ILztY1hiSeq6H7Aib/15MQAB2zQBgCr9/3DgzPB9CZn2 fytEE+daaQ7mfxvETj2Ty4/FdCf/qn3CU+yB3+U3jsIGzUbSMZJLd520oCqXg7Y6mR bFAOADAf/RCMW74v58FpMWTAKjYJ2Ft9dPchRRPIJTEzLK9fKnHmWew3xwhiDCah9/ dzT8rCFea6uK6H5X0chyxTwY6X4DA1qbYd4ZZEfZxyBwOLX7aqinRcEZSjc2CRciPX 7Q8Mu8Gqvp6a+FFfD9+JRC8zaFYGq59iU5KTkgJhzeLdynPn8RqiF13HBTGG/bBBDT UWjPxe4CIgrfA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 15 Jul 2025 18:12:16 +0200 Message-Id: Subject: Re: [PATCH v13 2/4] mm/slub: allow to set node and align in k[v]realloc Cc: "Vitaly Wool" , "Linus Torvalds" , , , , "Uladzislau Rezki" , "Alice Ryhl" , , "Lorenzo Stoakes" , "Liam R . Howlett" , , , "Herbert Xu" , "Jann Horn" , "Pedro Falcato" , "Kent Overstreet" To: "Vlastimil Babka" From: "Danilo Krummrich" References: <20250715135645.2230065-1-vitaly.wool@konsulko.se> <20250715135815.2230224-1-vitaly.wool@konsulko.se> <07d3689c-185e-496e-a0b8-53bb3194f0da@suse.cz> In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A3060180008 X-Stat-Signature: gra34awkez5usgfsuiuzsnzcfkt96akt X-Rspam-User: X-HE-Tag: 1752595942-681995 X-HE-Meta: U2FsdGVkX1+U4I8n8DbHL//rGA6OJZWYVEPbzHQ+rrFc5Ns5BbhsbXqji9y7PdX4olEjB3yYmpaDyaYoj/cLUmhdDWI5+Cq4lV5+lPP46IV0n+f/N4YxGAdYILttIkwlBS2/NkS3Y2IjvNH/hZf5j1IuGlGiyJGZCX/nsLADMwLQ0aeZ7x4qPdwmeC+cpDf0+0vLlwK43fEiviwqACUIhwHI5aK8sCH8uxlmDsGCYWa/rUXfCDVNv9r0WVN+WIj243irq/M1lzuuTr+gUqZmbik4QZ6rmE+Vac5GOixLdCXv1swedqLcceU5z59KjW5uNdTj7Y9ea1FSZl4zYwK53SkF7N/iOVM6lvk64Fj2NXxQ6XJ++mYLtVHcFR0d0wgwhoE1hP4ZapwBp33wmOaXsF1w/+mkvZddx8KxY+jCLI0QDJNDpxHCdk5R3LDiCU8ercesaxd9VayH28XsyudRC7WvUUOUxDz1Y+x35PxtTVl3VtPGzY/SKXND9RBTnhqZxOWvYFg7T6FiYzOHXxk6afTYaJUc3otpIuq37iXF058rOmYBZVMvuBkL5DkYWKaCq9ikHIzhBj4LPpIPV8z8LMDlJfdKrEOGT/Ywc8GkfIqKRN8b5rEJZrrRuhUnQbWx8DpJ5FsydNTWnO7Idi1yLIiyW7IbyAdpzQn8bqKAIdSvFg3F0CkNNYGZ93W10DVCPFKHgKiptjLUqpdv+nE/lX6c5SjAqXBjTcXou4CDJf/o/IGUmytIB/qawzY28+dLxTwGX/cEo2jgxGViSmy4GXVvBZoy6Fo3Quhds0FUihgKOP4kwG22EDM/qB7EAHM9G+5UzCeRzPJFHHzdUB2liybY3ZYYI0jVVNCTTtD7W1oDyhRH2TeUng9OICy8o2TyFi182VSXBmvcqSIT+IavKZC7Nbd9CyhVQ9eGYkH+/FE0S+PYXFnmWiCkEcZbeGrO+AsNOfrNImDlH+8ofmM oxkl0Bx/ oYgRSyCo+V6bnlLI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue Jul 15, 2025 at 5:48 PM CEST, Danilo Krummrich wrote: > On Tue Jul 15, 2025 at 5:34 PM CEST, Vlastimil Babka wrote: >> On 7/15/25 16:33, Danilo Krummrich wrote: >>> On Tue Jul 15, 2025 at 3:58 PM CEST, Vitaly Wool wrote: >>>> diff --git a/fs/bcachefs/darray.c b/fs/bcachefs/darray.c >>>> index e86d36d23e9e..928e83a1ce42 100644 >>>> --- a/fs/bcachefs/darray.c >>>> +++ b/fs/bcachefs/darray.c >>>> @@ -21,7 +21,7 @@ int __bch2_darray_resize_noprof(darray_char *d, size= _t element_size, size_t new_ >>>> return -ENOMEM; >>>> =20 >>>> void *data =3D likely(bytes < INT_MAX) >>>> - ? kvmalloc_noprof(bytes, gfp) >>>> + ? kvmalloc_node_align_noprof(bytes, 1, gfp, NUMA_NO_NODE) >>>> : vmalloc_noprof(bytes); >>>> if (!data) >>>> return -ENOMEM; >>>> diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h >>>> index 0a4b1d433621..2d6d4b547db8 100644 >>>> --- a/fs/bcachefs/util.h >>>> +++ b/fs/bcachefs/util.h >>>> @@ -61,7 +61,7 @@ static inline void *bch2_kvmalloc_noprof(size_t n, g= fp_t flags) >>>> { >>>> void *p =3D unlikely(n >=3D INT_MAX) >>>> ? vmalloc_noprof(n) >>>> - : kvmalloc_noprof(n, flags & ~__GFP_ZERO); >>>> + : kvmalloc_node_align_noprof(n, 1, flags & ~__GFP_ZERO, NUMA_NO_NOD= E); >>>> if (p && (flags & __GFP_ZERO)) >>>> memset(p, 0, n); >>>> return p; >>>=20 >>> I assume this is because kvmalloc(), and hence kvrealloc(), does this: >>>=20 >>> /* Don't even allow crazy sizes */ >>> if (unlikely(size > INT_MAX)) { >>> WARN_ON_ONCE(!(flags & __GFP_NOWARN)); >>> return NULL; >>> } >>>=20 >>> Do we still consider this a "crazy size"? :) >> >> Yeah, with "we" including Linus: >> https://lore.kernel.org/all/CAHk-=3Dwi=3DPrbZnwnvhKEF6UUQNCZdNsUbr+hk-jO= WGr-q4Mmz=3DQ@mail.gmail.com/ > > I don't know why bcachefs needs this, hence my question. But I agree that= this > clearly raises an eyebrow. :) I.e. this is me noting that we're considering anything larger to be unreaso= nable while having an in-tree user bypassing this check intentionally.