From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10439C83F22 for ; Tue, 15 Jul 2025 15:48:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A44AF6B0095; Tue, 15 Jul 2025 11:48:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1B706B0096; Tue, 15 Jul 2025 11:48:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 931816B0098; Tue, 15 Jul 2025 11:48:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 82FD16B0095 for ; Tue, 15 Jul 2025 11:48:20 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 37B49B9FC4 for ; Tue, 15 Jul 2025 15:48:20 +0000 (UTC) X-FDA: 83666930760.14.1639231 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf28.hostedemail.com (Postfix) with ESMTP id 6FC48C0009 for ; Tue, 15 Jul 2025 15:48:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ll5nqSFn; spf=pass (imf28.hostedemail.com: domain of dakr@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752594498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hCjAq8gB0jHelYKv+Q7r2BQ5N3hmVMo9kLBJKngltwk=; b=umk0sn0ayP5zroFpw+Yn2oJJJrd+vRVU5EXFug+KgJH5zKmD2H98uPAVs6E0FrQlk+JPs9 ye/TmaaWsZ9oMfixyGWy+pXrl/oJmwsK0bSyINLxHBtPZj9Hts+CeCeCpuWe3slLA2Cscd mqTPvN4/Z9PW2I7RKna8+UCWqi2yCts= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ll5nqSFn; spf=pass (imf28.hostedemail.com: domain of dakr@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752594498; a=rsa-sha256; cv=none; b=nM3tlyihHzEyHsT2gs23/sFoDhX/oSXpe26g4hSX2Cxm+Qp5NuYoEDzKzECnCGjal0OFMj d8Hlkn3OHZ10cLngdBbiW0sd3F2/DuJeJAActI3k9n+jiAiRDpGbk2EGRaDdk9a25iQa/m kani1x9SenwWmaar4tw8CyZ+l6iP04E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1FC9F4554E; Tue, 15 Jul 2025 15:48:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2F04C4CEE3; Tue, 15 Jul 2025 15:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752594497; bh=yDmUHWGgxGRLJjN/sJvcSFzoD0oqxgTLlj8Aakr+6zc=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=ll5nqSFnkHQRwDoKLvbKe//dMvkq9OGgdcszxpaJTiArXkMBFlBEGznIoL9ge1UqC tPNW6WABr+jUY3rf81U5zoaNpmrRK+D1Xh0rlRVG514AbLDqlG4YNK6ttjnHgFrNYU EyyCygEyO645JjBNy57Mzk+zWPur8Dk6bVgjp6YIHobOUWKGXE+8OFcc9+PEIZpO6g bVdgyi+HToePqiBI2Uq23KG+Ky8Uu8yrQnna/Lpx98z1wcnuXAuC9+Nd+tuCjXYHFL 5g0d6/IiUJYoiDbpZart9nJhJyWh0hRgX7ts8SQSWemTGI0/SvZypERIvavb2NyXce 1YKkrQHJUeE1g== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 15 Jul 2025 17:48:12 +0200 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v13 2/4] mm/slub: allow to set node and align in k[v]realloc Cc: "Vitaly Wool" , "Linus Torvalds" , , , , "Uladzislau Rezki" , "Alice Ryhl" , , "Lorenzo Stoakes" , "Liam R . Howlett" , , , "Herbert Xu" , "Jann Horn" , "Pedro Falcato" , "Kent Overstreet" To: "Vlastimil Babka" References: <20250715135645.2230065-1-vitaly.wool@konsulko.se> <20250715135815.2230224-1-vitaly.wool@konsulko.se> <07d3689c-185e-496e-a0b8-53bb3194f0da@suse.cz> In-Reply-To: <07d3689c-185e-496e-a0b8-53bb3194f0da@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6FC48C0009 X-Stat-Signature: 9gw49m1i3s6eyqzwmmkzfm6qwq19h1cf X-HE-Tag: 1752594498-971142 X-HE-Meta: U2FsdGVkX18DSes8kZ2RbWgI5hbh9i9hKzNEFAifjMRO7eYMCiIXzSbDSoNSRL5Vwz2E0Xvv7rAcSJBEBnp2mD8AHzeU5/2n74VgI0SeYgdYDKTeoKWTHJdoAdOKc5/XRF36qdHEGZlD2dST38MMpe+HXluO4+q8Dti6PmifDA8ESlJBwNVi+1WZjyQo/RSyCgjxcWrvrWkxP/1dZpIeiN0mvlXyz8mAyQsBsaG1dWwe6OAaNuAx0N90VMypaiv3dzXTYb5TSedETWMRBGa/BbTMaKp9EwWYXvAU4N2yccWpgTwMv1r/rHrfpIVs+POzTjfp7lChQdObdU5hVd6pYAr3MkdRisER9ezej0DCdPVrwvlhCCyOw3gw7R2dWYMwFl+9LulFxLnEKrm95rb9048keGkqg5U9DQuWM5w1WJWyJri3bTGLAVKtamsyHruPFAiWQr7jckXg2WxH3wQJ6l3cw+j+YDViv4fJWn4Ey5jAP0v46CVrSnMcaN1V0Ek7Lsia4jphOU9RUJQVkj3O3jj8BWuCIDUj7JGtbsFCYFdLD7GjgVLQ4ESj8Ifr0neoHsYTPpyinAEE9+mxEhwCk+t5plLPRfkMZf6KQiwf37mLsol7yDqb2GYwpU/9yBf9stG5ikvbzKURMsDoTHz8CSSwmuZZejTtnVZohgTF2GUp1otZqzssq2ZHHhdYXIRWMw6qAKJfYJxxSqevIHTbHeiLIKW1gbiURReMs/VnLY7ljVGz9+VW0kwoPo0A8O7tMxOt6xS9g/nvrj41+usvfCRS0pm/GQAVw2EG624VjaC6kNSC3yvTtKII6nHd4KohjLlu/0hPyVAU521n3HVdyj0Epk9dbRoXW5HrTj9du01yacIDzsA9sGwS/09dKx0+HidZGLsfQwC3G3CODKhj68dkTk8Yb1Kv3KqOJXy6z/uw5xntOXymtksqfTnOgf7gM0cH6PXWlogrCpwptNX kVyHaZ+x 7bAUYSHhrwlSQozukWlC8XxjZ4kHzx788YFq01PfBP58o+RfpPWW5sCvgbEv29hRCe1gKWB+b0ggj8vkpVxZFCBS9QDe87zptwLKTp8Fnw9iITVrseP9NBryfHnGOR1kLu2O+JNSMoTiidpTSj2S/QlNWsrQBpQI6JsY2z0kl8aRU4hrtuvI2E8L/7/rpp70GA93rM2a17Y+5uZpIm7JEpZMiAr0YOlSIEwGJF1U+W7v2HKiL00GI40bj+6sIkjvIiq3KegXSWAhN2Tr4NQW7uwM30AiYHdR22mkVWXGspBbJpmKoF1/YCtstBmtmuniVMaKsbxm9pQqSTwTkIjAO9y2xgzuJ+Z/RkUadUHbo8bxl+PA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue Jul 15, 2025 at 5:34 PM CEST, Vlastimil Babka wrote: > On 7/15/25 16:33, Danilo Krummrich wrote: >> On Tue Jul 15, 2025 at 3:58 PM CEST, Vitaly Wool wrote: >>> diff --git a/fs/bcachefs/darray.c b/fs/bcachefs/darray.c >>> index e86d36d23e9e..928e83a1ce42 100644 >>> --- a/fs/bcachefs/darray.c >>> +++ b/fs/bcachefs/darray.c >>> @@ -21,7 +21,7 @@ int __bch2_darray_resize_noprof(darray_char *d, size_= t element_size, size_t new_ >>> return -ENOMEM; >>> =20 >>> void *data =3D likely(bytes < INT_MAX) >>> - ? kvmalloc_noprof(bytes, gfp) >>> + ? kvmalloc_node_align_noprof(bytes, 1, gfp, NUMA_NO_NODE) >>> : vmalloc_noprof(bytes); >>> if (!data) >>> return -ENOMEM; >>> diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h >>> index 0a4b1d433621..2d6d4b547db8 100644 >>> --- a/fs/bcachefs/util.h >>> +++ b/fs/bcachefs/util.h >>> @@ -61,7 +61,7 @@ static inline void *bch2_kvmalloc_noprof(size_t n, gf= p_t flags) >>> { >>> void *p =3D unlikely(n >=3D INT_MAX) >>> ? vmalloc_noprof(n) >>> - : kvmalloc_noprof(n, flags & ~__GFP_ZERO); >>> + : kvmalloc_node_align_noprof(n, 1, flags & ~__GFP_ZERO, NUMA_NO_NODE= ); >>> if (p && (flags & __GFP_ZERO)) >>> memset(p, 0, n); >>> return p; >>=20 >> I assume this is because kvmalloc(), and hence kvrealloc(), does this: >>=20 >> /* Don't even allow crazy sizes */ >> if (unlikely(size > INT_MAX)) { >> WARN_ON_ONCE(!(flags & __GFP_NOWARN)); >> return NULL; >> } >>=20 >> Do we still consider this a "crazy size"? :) > > Yeah, with "we" including Linus: > https://lore.kernel.org/all/CAHk-=3Dwi=3DPrbZnwnvhKEF6UUQNCZdNsUbr+hk-jOW= Gr-q4Mmz=3DQ@mail.gmail.com/ I don't know why bcachefs needs this, hence my question. But I agree that t= his clearly raises an eyebrow. :)