From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7682AC83F17 for ; Tue, 15 Jul 2025 10:38:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03A1C6B00A0; Tue, 15 Jul 2025 06:38:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D996B00A4; Tue, 15 Jul 2025 06:38:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1B8A6B00A6; Tue, 15 Jul 2025 06:38:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CE1386B00A0 for ; Tue, 15 Jul 2025 06:38:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7BDB9140406 for ; Tue, 15 Jul 2025 10:38:01 +0000 (UTC) X-FDA: 83666148762.25.5BA1563 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id C3E951C0012 for ; Tue, 15 Jul 2025 10:37:58 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sg9BVJUE; spf=pass (imf20.hostedemail.com: domain of dakr@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752575878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7WgG+OnEAx7vMxa1C67THit5Y+K9i6iMpWZlSHSBsfY=; b=DqjfnhDSz3+vMchRFfofWSCeBZPUtfeOLkFS8D9lVcqxljokB6/kv15syjYJjaVY9Ov+7O Xt7nQcNhKuMXyqPqZLb9zs99IrH1yoFAl/mKMPathkYS4q2mWjKtWvDzLjVLpqONyFY2Uf q89Oandh/nmTXi1wqIamQ7CLdnuovbg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752575878; a=rsa-sha256; cv=none; b=u9fZKlElMFMextwju6RXfdB28xPJeQc2g3zk/Az6eHgZmaQxYOHRoONwHYKhABYFYW17AD CfJfrONqqhj4R+d8ZWpGlXGlXIZTpsZYPwfJd6FoFWyaPWlXM/vXq5s/pVFN6VTUmgErO1 zEKvjpLY9waAElgkucKPiOJn685M/LU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sg9BVJUE; spf=pass (imf20.hostedemail.com: domain of dakr@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 63C4F444CB; Tue, 15 Jul 2025 10:37:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4FC4C4CEF1; Tue, 15 Jul 2025 10:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752575877; bh=nvxs4JefX2Fe4yKb5WKZ7M6l9ON2bv8gKISzvr7j2i4=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=sg9BVJUEjWs0T11lxnAPKFTb5iCEvHqTj6KKLXpyKytQ/mQER+vjv2fmRR6ACiJLO 2SVYf2uLn3nM8483OjsXGrxbXD87wLFC4cdhVQmIHDZJogP/DcPiJ32zks10sYS1km dylH8vRsKifhYMF9u5KQw0AX+ssSLXTdv2YcchVagpRIxtUeJxOrRSGe0mxskM12es n7Z+322O01Cll8G+IlSihqBD2Hn2zj2RSDrYi2502JB2XTcHXtPfZSeg1CuegxTOwt ts/JHVlcRmnNRI1CCPSqxpGtVd8PR64ByCtbyV0XLBqPftKzyPt3XrxjLV7USldrok Dhw0+bN+ZI86w== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 15 Jul 2025 12:37:52 +0200 Message-Id: Subject: Re: [PATCH 3/3] rust: add a sample allocator usage Cc: "Andrew Morton" , "Uladzislau Rezki" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Geliang Tang" , "Hui Zhu" , , , To: "Hui Zhu" From: "Danilo Krummrich" References: In-Reply-To: X-Rspamd-Queue-Id: C3E951C0012 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: do9uf57o9augneksg537xfdgduqap8rr X-HE-Tag: 1752575878-356678 X-HE-Meta: U2FsdGVkX18MRavLxG97pgqBenJcVRDz4z7mWlJIjzUaK7p9NjmT07n5ZpF/RT8ZoTo5ScHu0TAVxow4TUwZTuZSBmdzxXQR2wwlH/a9oKcVyKYKRGFYAa70Q893xGQFRExHMiaWPX0LGEYBM3/tCkxS1dbEZD8UUaeC/V2iB3tiXUdnPze4vVhByimWqsQNaPurOSztkMZJdMPL64nDDpd+v9Qx2YG8Gp+QA9ZrzM67bZwY27Wfh3xN8NTf+ESYPH3SwM4Sq6wVfBULqHMzgIH8ZCELnOQ71LqlNbQZN2u2vMlaTU6Hsw6UJEOrPKHfVTWY5HG0T6yJ3Q+Kiq1yEdOerRJ+ykp3dxoJQmSanza1wkYkOW3bD7REsgiOEZMtmX5msQ0vTKkFfH3lNnnIJdfZhz9SikNwtW58pAAz3iivPcnpCHkCqUseQfjMyBP7gif7VsdYpRCRJNRDQAnh63P3skb4FakphMIPo6VWB9JHQ1g9l922CFobVBm6oVw/jR5CKAfcezsXOHUxPlkStPKFRJ+c9mIuEZgPCZBuvnWS8I/rAyggSMBnF/rTnVjidNLd5WPAataYHSX3KLt3fkXWQjGc2ec6siGL6B7AbXU0pR9VA87NGbSmI1lrTCEQuscpivGjIzd6xSmRrQNeTJpQW11KmfKTVNV2vujpSpZl1YRo90BkbGzswNeAQgJZeRzbbgfGTLMwqfFJ1rmXMVOJGEUiqnojDB/EhEj9dFtjanoxeIVhQ351e0kXskGc4WRKwIbhV7W0dasio9s7ttg5YwNlhy8pJM5cKY9bfCuV42OFx/eBCwzH/imcR1vwTtJSTPUs63OB8PKctuEaxEAwknNpWZrz5VDkKM1euEpXu6uae7Xh36Dufj1WvvImsmfuYv0zwh0JhbH4UTIcwtZqzeD7k42ZgVp0xh82qiuY19+5jUrSwfPdZXxA2NaIBfra2uaVQOI+VPeOJko OpLSwHPb 3qcjp16Qzhj53HevtPEIyC4XPuJ8/aywqMNMB0BNz8pAfI7EiYhcRZTd+G2IjNwN++G9B8FjmHYb0X2pW1gmxyeaBzfdwLmFLiLtpwM/Ek1nadsJ4ZyzX2afTAABiEsubA4O440QbXJU+juwpWidyi4Kr5FpyxqshZoWBSBrdk0CtZtXr5wA1t9NcfwdQEOwyVixw85+bMSZse8pSlhWIWOKBndT2RDGHJYnFKhEUi3QgU10e6upc3A82S/G6nb6Klb+byvMsIk+iIYO8Y9BtglHhgzalyfAUCyon+A8RfeubUjBbU5oIe/lqGivsW/JFUdqDbhiFMZlwujvzz4edwnG3xqb+yW7v1v0P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue Jul 15, 2025 at 11:59 AM CEST, Hui Zhu wrote: > +impl kernel::Module for RustAllocator { > + fn init(_module: &'static ThisModule) -> Result { > + pr_info!("Rust allocator sample (init)\n"); > + > + let mut vmalloc_vec =3D KVec::new(); > + for (size, align) in VMALLOC_ARG { > + let (ptr, layout) =3D vmalloc_align(size, align)?; Ok, I think I get the idea, you want to demonstrate how to use the Allocato= r trait for raw memory allocations. However, doing so is discouraged unless there's really no other way. One ob= vious example are Rust's own memory allocation primitives, such as Box and Vec. So, instead of this raw allocation, you can just use VBox::new() or VBox::new_uninit() in the following way. [repr(align(ALIGN))] struct Blob([u8; SIZE]); // Creates a vmalloc allocation of size `SIZE` with an alignment of // `ALIGN`. The allocation is freed once `b` is dropped. let b =3D VBox::::new_uninit(GFP_KERNEL)?; This way you don't have to handle the layout and the Allocator type yoursel= f and you also don't have to care about explicitly calling vfree(), VBox does all= this for you. > + > + let (addr, is_ok) =3D check_ptr(ptr, size, align); > + if !is_ok { > + clear_vmalloc_vec(&vmalloc_vec); > + return Err(EINVAL); > + } > + > + vmalloc_vec.push((addr, layout), GFP_KERNEL)?; > + } > + > + Ok(RustAllocator { vmalloc_vec }) > + } > +}