From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1EEC83F22 for ; Tue, 15 Jul 2025 10:21:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACA5D6B009B; Tue, 15 Jul 2025 06:21:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7AA46B009C; Tue, 15 Jul 2025 06:21:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9699E6B009F; Tue, 15 Jul 2025 06:21:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 810946B009B for ; Tue, 15 Jul 2025 06:21:57 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3054C16041D for ; Tue, 15 Jul 2025 10:21:57 +0000 (UTC) X-FDA: 83666108274.07.A3FF48A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id 9912E10000A for ; Tue, 15 Jul 2025 10:21:55 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iwrUcIoP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752574915; a=rsa-sha256; cv=none; b=gUap+X7WBYixWZ3E7AAN1dLYynR8gxe68qihmd6WsKfJVS4y/HEPItaQhjZu1TUXCYic8u pAjgr5mQZpS18JD6VvLITHnttWK4cYaw8+cwgGJVa2FCfng6lJhTvinYscHUTgqATfMP2j TJgLBfltq1WEydYl+GuyDdIU/NOhUAc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iwrUcIoP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752574915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3fI0sIyC6QvfuLV/Cy0sgafRGz9R2/GQ6EOZB1tSsIg=; b=RpFXy+cRAA4tKfc4t6KE5AH6n3CsbZbVDAYueA4XNbZN0YA39wuIFJ2LM3zj05cBWWUKHD xQ+Fk8udNTx0PTFd8WipEDb3R09mMOsUnLOe9ZpxsYtTjCN8uWm8sL9IvbJifEhFOU5tlS AsxJ48U19uPFBWObBPzNiLsEImOJR1k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BCCA8A530D1; Tue, 15 Jul 2025 10:21:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34F71C4CEE3; Tue, 15 Jul 2025 10:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752574914; bh=3fI0sIyC6QvfuLV/Cy0sgafRGz9R2/GQ6EOZB1tSsIg=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=iwrUcIoPUzM98i0KrBucfHAUuQfuqTpdtI5NMJpIU10O1pkI7DnfjVGm7gzHlLjaR OuplIQv6NbXSUw1S+qfqMDzfrOp2Evf/bYCLV0x5Lic88EV/A2WTjMpozZb9v4N0xe o/iz/c1XuE5suiCgipiXi4w7ljeeCD+7LyDDV6VuhVumbh9Tm7P+B/Fahr9KBdq8Zt BQ2U0wFxsi64Xmv1P5w1AP1/McKUkYtCyk+ZSpVyOLUC2kASjv/13+bug8mC54DWDA 97ihYZhL0z28BZrZD2QnX7UY+Z3NdEQhcKDQOvaTB1JFGSFO6H7JeZXhP1ZIDPO2rT vCdTJkMOpXfEA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 15 Jul 2025 12:21:49 +0200 Message-Id: Subject: Re: [PATCH 0/3] rust: allocator: Vmalloc: Support alignments larger than PAGE_SIZE Cc: "Andrew Morton" , "Uladzislau Rezki" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Geliang Tang" , "Hui Zhu" , , , To: "Hui Zhu" From: "Danilo Krummrich" References: In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9912E10000A X-Stat-Signature: nbmimyca3s4axe3zooni8sacdnjks9qo X-HE-Tag: 1752574915-692331 X-HE-Meta: U2FsdGVkX1/7wGusyzeseltY0rHZ0BE+lrntUZ8HH0vcPRt0OKPkiIxGwemxRNCs632PpHLFuDvN5FslQqsywQpUsJMXf1EpKG5viF7QllOzPYgY+nPG+txcfX2YJrQd5OxGxiSlRT/nWkxARqDYKgXL3Bz88/uzmg487y2HINGB9+YVLdEdroFt0zqaRAJPBp6k5uVosyL75/i4sJHkjK1pBea5UGw5zTaLSfVgNaez1/IbNjnZtvDnCjqtokfsExHiHX3ZolRiyRQblcYlo/KtThXK6TvdccwQxoasn/Urq5HOQwp31mXE+mPncp6ujtup2pOAO5JaGM+h6Ue94E4o+BCPrRrKxKaHa9zxwzuhF4LPNuXLK6mWOpEomCT+uCFtFbX7GGw5dmK01BaSY9BAgZkfVcRmVeSkb+pxPwjIgRTbM6dDJDLTdjRp301bZkagNoXWBZPeuwVLDfe/+M65i8+BIOsBKVi5bcZfHIWNY4QRZbVjp3SulJ88qpwIHe9qLaRJLmkwU1X6BlBsmYqA+v4Vk6BzyZxRULX2XUBiyi5OyMZnnQWh6wyHFfWGud0Fg3p/pJ3PpsEgQDNh4ssaJw9/CO/BXIzHDhLMMwbxuib5hPUFGMWGeky2jY2et64+2rmhbU5AKpPezna5gv0ScT5dsN0pPUgodUqS+fQqSUsiwU9brr2V6teD+LtwlSb+bNJhO6T8wP0qjj2nqRYLpHoDY2cCSnymgA08B9D5dwoNdPlx7MmndhNBHn49TrZ9dK25dRsfncvLDlhphY5xkAVifwZMYFCOb/DevXtedj4gVzmLB3f0tRs2vL3haD9e2ZDhRQH8LRT1mhu0msY1SRkedWOJbZwwXrEbXQaqviH1TrGtwECQaLds1oCPJzQaM6zev1hWEU1SDfGlBFcoQijQl3oHc4ob+NZ4v664Uo6EAUacCyxUaSh/WMmnjXrMUcQgGO7eO/DWhzc M0mbGDtC c3/92y5fEm6IJQZJ4AK6U0OgyKSp0kmz5nPTIN07Urap5Pq/vplVv00J2u2nxQY8KSXPG9pnQbt3ktVeHw2ZUj1OlZLRiPOsrpVsII8+VBGCG6ZDRRYntOedBXNeL/csIS86uPNGijwlPaEUwIhPlvHugHTOpLR5VJ1v6jYiGjeYH3dQVu2qiwOzJpZTsmHxfT8dYkKq9nCrWXhpLFWNber6xcnhTlXmNXnICppm7Jn125YEugoWQ1nqAmavXNygG2TGfTviahssFv5b70w8Z5gec6tfuNqt1Hc5OAvPTloTg+tMT9e4b/vATW8GTQEupC4iswuBJSkgXbY05iBIxsqqA7dL8VX6pqE3mZb2DAigqvE6ZbsOcYFSgTpe4j4FON7jKbE9hUt4vFs5Jf3K0wVhz8J3GBnBK/PoL89nGWtiyC3ZZs8+P+ZERRfYYDQMWgoWV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Hui, On Tue Jul 15, 2025 at 11:59 AM CEST, Hui Zhu wrote: > From: Hui Zhu > > There is a TODO in Vmalloc::realloc "Support alignments larger than > PAGE_SIZE." > > These commits make allocator vmalloc support alignments larger than > PAGE_SIZE. > The function vrealloc_align is added to vmalloc.c to support reallocating > aligned vmap pages. > When Vmalloc::realloc intends to reallocate memory aligned beyond PAGE_SI= ZE, > vrealloc_align should be used instead of vrealloc, thus enabling support > for alignments larger than PAGE_SIZE. Thanks for the patch! Please note that there is already a rather progressed patch series addressi= ng this [1]. However, I'd be interested in your use-case for alignments larger than PAGE_SIZE. :) > And add a sample to the samples memory allocator usage. The example looks a bit odd, more on that in the corresponding patch. We already have other examples in the form of documentation tests [2]. Not = all of them are for VVec, some of them are for KVec and KVVec, however, they al= l share the same code, only the allocator backend differs. If you'd like to introduce additional examples, please do so in the context= of documentation tests in rust/kernel/alloc/kvec.rs. If you enable CONFIG_RUST_KERNEL_DOCTESTS they're compiled and executed at = boot time. [1] https://lore.kernel.org/lkml/20250709172345.1031907-1-vitaly.wool@konsu= lko.se/ [2] https://rust.docs.kernel.org/kernel/alloc/kvec/type.VVec.html