From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A7CC83F17 for ; Wed, 9 Jul 2025 23:27:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7B3B6B0173; Wed, 9 Jul 2025 19:27:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A52FF6B0174; Wed, 9 Jul 2025 19:27:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9900E6B0175; Wed, 9 Jul 2025 19:27:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8AAD56B0173 for ; Wed, 9 Jul 2025 19:27:01 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1C7571602A7 for ; Wed, 9 Jul 2025 23:27:01 +0000 (UTC) X-FDA: 83646313842.03.BFFA99D Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf04.hostedemail.com (Postfix) with ESMTP id 917CE40007 for ; Wed, 9 Jul 2025 23:26:59 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b2g1Q+zI; spf=pass (imf04.hostedemail.com: domain of dakr@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752103619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/2YB2YD7nc7Ui1ape1zLdth3aEDpuF4f35oSaRHOL5Y=; b=lLZ+AQth0m9eZFUIoehA0NF+VhbV4pI3767QwjF8IFyjTHiaW7qH6W3xpGh0+Q+CKR4DgP F3cLGLXjScIPk8h8CDCLi/774tfDxLtHGPxqseiI2CIYYGE6HUJWHX+xaSQhz+dBYNSJUu SzII9E505v6V//FcfpsRJiBLhqQkQW0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752103619; a=rsa-sha256; cv=none; b=5P9A0j0lGv7ZvzHgQ21g1Kam+tE8dORrYLFQHk8P+oJGPZYIEw5VesUPH46BqgSM2uMO+a nH5Dw4hVt0ECg1GsGhFxvaZS9AH+ujZXVeo7jmqwsDpcDNdJCkkC2niCQypWd4xwTu7v+2 BSBrtqh8Yq1EQBj5N9W1kuQcZ1Pz4iE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b2g1Q+zI; spf=pass (imf04.hostedemail.com: domain of dakr@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C635361139; Wed, 9 Jul 2025 23:26:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FF2DC4CEEF; Wed, 9 Jul 2025 23:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752103618; bh=IPEkOrMLiuYPZNTOAJdwlYClp6f/Px6JZvPwRaELaS0=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=b2g1Q+zIZl/+BRBTP5p6IPueQ9i/noMS14SUk6j/a4rs6rm+xarisc4yVYbX3CvTa b/PTn9nuKDQSjB90es6LVAdiO7XZoLirdDYVav//SYbp6B6rVYx6YiVpRly0bx/1Ee uM6l57S4G/17nCoGXyASois71bPjvogxbE4JSKheGnN8PAd52n2VT5ytybnE7l54fb tiwvzwoa1E9R8juCK7Tqd0Bkx1Sm+i1IHwhvSE+Qhp5GDK0s0/50osQAnF3ZCuWVmW a+4oWt23yWtzwNE6dIGKbL9tdXh9+qNZh3r+Gsxp5ZOBjvZDEeV+iHFPidD2t5BZbv 77sm08E8miyGg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 10 Jul 2025 01:26:53 +0200 Message-Id: Subject: Re: [PATCH v12 1/4] mm/vmalloc: allow to set node and align in vrealloc Cc: "Vitaly Wool" , "linux-mm" , "Andrew Morton" , "LKML" , "Uladzislau Rezki" , "Alice Ryhl" , "Vlastimil Babka" , "rust-for-linux" , "Lorenzo Stoakes" , "Liam R . Howlett" , "Kent Overstreet" , , "bpf" , "Herbert Xu" , "Jann Horn" , "Pedro Falcato" To: "Alexei Starovoitov" From: "Danilo Krummrich" References: <20250709172345.1031907-1-vitaly.wool@konsulko.se> <20250709172416.1031970-1-vitaly.wool@konsulko.se> <14b08e7c-c2e8-435c-a1dd-bd51cfb42060@kernel.org> In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 917CE40007 X-Stat-Signature: dqqt9hqrq5kf1oz866yeuz95h19md94y X-HE-Tag: 1752103619-902320 X-HE-Meta: U2FsdGVkX18Ld7TVxEjfDec4VXEnEFYKFXenIMMewloAMDiOb2VXu18TSdQPE8rJfzT7xPEUwGV/2kaC+hxDEFXY3M+YTi/5MhOMJPA1G5AWgedDEdzJ5+492y3JpFhScBeNCKAUymLE1NQKLMF53a02FCmQifS3nBGv18rewPvQj2OEsRoSh7JrqfCE49rcXE6dM+pVLdJq2FXMQxza7uKY+1T7alyTzHKIGd/YrJuSjbWIfwo5Ck8KhhCHBf2iWSwshmsM9v38QQIgS3dTRg6XDwUssPC5YP8xjYVYv6AdhDST0/kYLxYPDvHJ9u/qyAob8HCMA1KsU5tcVgq9ofhBKFgZfuiORBKbyHHgdSuxXuGYcXWoxs7i73xlpUO7BEsfgtFCdXZ5jN/3EUpeFM7ieM2xpc+KPt12d70371HNY9iChspx9k/8/yOEhhnEUtPTe8pGm5fHZd5bwvwaesnLao35OKF7BlpMutlUGgqheInhKJMXd204IJEY8jOUnfVaFFANCn52+EcmmrqcjrciRXGVy62MrFTqcyMADr0XaN3PZRdWUX0EATIZTy1soRM1uXXaTUknEOphN2bKXiQDZRLBYnj+QVZplfjgnUVMs+NrDvlvwAju37f7djITdLBi5GPAP0yU/MxnPwldUCzuL7sSZxbBrFlhA4QFYqsd8a6pKvP9UfOilrfqVGsepqmXdBRWKlEMd0+hjcDpHsrVJhKxURL+OMtdq0l2iNRUQ0lb8ug5gQgHq1YLHAr6kOHJ2GWLZ+8Y+G4rp+kjKGnNVVbb5PbFoDLNX40yupzlvFaNy8lwC/BVva5h25xpF0mSaLPdPN/r3UTIrFHVJqDjmwIkGC10Z0ISSXSzieIR3Hiz4KEwRIFruoixh0TLrMzn3KutoZvfHy7BEYz57n5LIzNNWXxuJUhA5VXOQpcW8L4zFxCwl9GeslInz7E5e0zXLpitUu0YHc6ASur rf3wq1iT ZHHWVysC1gKN/KZUa+uYNGP6IHBushFmArEy8M7ju5zfCYEbBX5XXvawVs9y6XgmnQZq2DkiDWVZcuZfm1B3rABcEW5uT0YNdKZa7kR+5tUDGsL0K/PbB1gUknpTP/e0GoeJyPMdXQsJ25dRNPzwTmBbDpMAwqU9CE/kvqaHinKMjwEzbSNzcjZd7Syb3eY+a5v4Jj2J2fnms2KOzFko4Ih183HJLHizwZKKK3EKZEKOL5PQgp5t98ZS/+j5p7DNmRgiMTgyTKE1ydsI8xrPq2I17+c09mcWVdGJ1p4/QNSafFqpPLlszpeyB7aJ0kWrHD8lwfH/kdWUNxWGUmbpi+yDwHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu Jul 10, 2025 at 1:14 AM CEST, Alexei Starovoitov wrote: > On Wed, Jul 9, 2025 at 3:57=E2=80=AFPM Danilo Krummrich = wrote: >> >> On 7/10/25 12:53 AM, Alexei Starovoitov wrote: >> > On Wed, Jul 9, 2025 at 10:25=E2=80=AFAM Vitaly Wool wrote: >> >> >> >> >> >> -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) >> >> +void *vrealloc_node_align_noprof(const void *p, size_t size, unsigne= d long align, >> >> + gfp_t flags, int node) >> >> { >> > >> > imo this is a silly pattern to rename functions because they >> > got new arguments. >> > The names of the args are clear enough "align" and "node". >> > I see no point in adding the same suffixes to a function name. >> > In the future this function will receive another argument and >> > the function would be renamed again?! >> > "_noprof" suffix makes sense, since it's there for alloc_hooks, >> > but "_node_align_" is unnecessary. >> >> Do you have an alternative proposal given that we also have vrealloc() a= nd >> vrealloc_node()? > > vrealloc_node()?! There is no such thing in the tree. > There are various k[zm]alloc_node() which are artifacts of the past > when NUMA just appeared and people cared about CONFIG_NUMA vs not. > Nowadays NUMA is everywhere and any new code must support NUMA > from the start. Hence no point in carrying old baggage and obsolete names= . This patch adds it; do you suggest to redefine vrealloc_noprof() to take al= ign and nid? If we don't mind being inconsistent with krealloc_noprof() and kvrealloc_noprof() that's fine I guess. FWIW, I prefer consistency.