From: Mircea CIRJALIU - MELIU <mcirjaliu@bitdefender.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jerome Glisse <jglisse@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"aarcange@redhat.com" <aarcange@redhat.com>
Subject: RE: [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range invalidation
Date: Wed, 11 Dec 2019 16:16:21 +0000 [thread overview]
Message-ID: <DB7PR02MB3979B35C4DED689057F60192BB5A0@DB7PR02MB3979.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <20191211154429.7tscxcqk725guyce@box>
> On Wed, Dec 11, 2019 at 09:29:21AM +0000, Mircea CIRJALIU - MELIU wrote:
> > MMU notifier client may need the VMA for extra info.
> > This change is needed by the remote mapping feature that inspects anon
> > VMAs with huge mappings.
>
> The change itself is okay, but commit message should be better.
>
> Do we have any user of mmu notifiers in current kernel that affected by the
> missing vma here?
No. This patch is a small part of a series of commits for the remote mapping feature.
The kernel can do well without it.
>
> And subject starting with 'also' looks wrong to me.
>
> --
> Kirill A. Shutemov
Mircea
prev parent reply other threads:[~2019-12-11 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 9:29 Mircea CIRJALIU - MELIU
2019-12-11 15:44 ` Kirill A. Shutemov
2019-12-11 16:16 ` Mircea CIRJALIU - MELIU [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR02MB3979B35C4DED689057F60192BB5A0@DB7PR02MB3979.eurprd02.prod.outlook.com \
--to=mcirjaliu@bitdefender.com \
--cc=aarcange@redhat.com \
--cc=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox