From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EC26C77B76 for ; Mon, 17 Apr 2023 14:22:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3A536B0071; Mon, 17 Apr 2023 10:22:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C2FC6B0072; Mon, 17 Apr 2023 10:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8639F8E0001; Mon, 17 Apr 2023 10:22:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 70B6A6B0071 for ; Mon, 17 Apr 2023 10:22:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4849D80517 for ; Mon, 17 Apr 2023 14:22:43 +0000 (UTC) X-FDA: 80691099006.25.061CBA7 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2086.outbound.protection.outlook.com [40.92.58.86]) by imf01.hostedemail.com (Postfix) with ESMTP id 55A014000F for ; Mon, 17 Apr 2023 14:22:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=hotmail.com header.s=selector1 header.b=jV84X0Ft; spf=pass (imf01.hostedemail.com: domain of dcb314@hotmail.com designates 40.92.58.86 as permitted sender) smtp.mailfrom=dcb314@hotmail.com; dmarc=pass (policy=none) header.from=hotmail.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1681741359; a=rsa-sha256; cv=pass; b=3E8L4mwyOcHP5Iy8pdtsNWz5l5Zxk21hmn8Nxi7Jl9AbdhfVLfUZw3hp+lbNBZBmH8VCNb TOPQhl4JgZRQujRxJCoGqp8RBgLvAzwXU/SldIy1gbodxICz76Wdni0MD3kaN5t9cCRV0Q xcNrWCivU7Vx7VfJRmzzKAPYI+VJsXc= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=hotmail.com header.s=selector1 header.b=jV84X0Ft; spf=pass (imf01.hostedemail.com: domain of dcb314@hotmail.com designates 40.92.58.86 as permitted sender) smtp.mailfrom=dcb314@hotmail.com; dmarc=pass (policy=none) header.from=hotmail.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681741359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hcxTT6UF9js318S99sa+KWysi/C4jiZaemKNiEHU6Gc=; b=5l8M9p2x+lPkK79jHvaB2qgT/2u4NnS1AWviYRg9T0uCZBxCr0W0r8ki9YIOdSuDO9mjQd zNt+MXFjlckn5jdh+DYoRVl/A+wsMJk/E57rzrCzazw/0zezoCdwZKyylTcY6TabzIWNUl yQC/JLA3EoLenYkLkXhMlVvCVEcAG78= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J5rIVsESXRUZ6+hBbC8nye7YrFqf1C4oj6ZylTrF5awtQquW8ByrPwLYaMJgAQXQOUb2Jdvl7MJr4pUI2jooFxrJ3DawNf/271CE8z78luWg3U0v4g4hGe8A2AKz6yVuHnM+nt0R1m22jSJoqPlA3BBkJYKOlQnpLEbODcup20Rlwj1nIrOKGAkhKJywh9+VbSrHjOJMDRvy3N3rGRBzUPYxnbuBlGxPJQFO7BJse2EANUfKuNvBev5Qx3QZ0J+dep5X8lYOGV88tEEG2kegpeVMJyg93rdBWEeGBwgM0OV+p7GxGs3Zh9yuyCCRF/gAwsf53SZbj8NoEKLTQzGSGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hcxTT6UF9js318S99sa+KWysi/C4jiZaemKNiEHU6Gc=; b=dbFgk5vZfj0M53L/wkhsq0PPad/edDu41XQjB5hPx9MZUP07GJ8qSixKCkYo/HsoyYaeYSRwXGGl0Au+PEWJvS08T8gl6fgJcLyVrPdSr8qcUuacfWtV2iOohY8tw5tME7HH8sgG4Tz/CCMQboQ2C5kklTr9zlmYGdsZoDqEDlEzB0f2K4hV58zwlF5ChdZfDb/rYyoXvcezOA09Bk7hY40qKFQSMJlMUOgT0IMiEd3LIk8QqAOwlcuisyHzgyrX5IESn4Tq8JnUNxsAnPUBNjA9IZBtcsruGOJkcjSB8Tkm2blDpEQINyD2iHX3OOX4nO4lGRAG1tH2bRvUx2B1uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hcxTT6UF9js318S99sa+KWysi/C4jiZaemKNiEHU6Gc=; b=jV84X0FtpTQgYNJX4J5C7T952WAiKVoUVXdYNFiv+ssZtKC8BmOdqciD+zjYRIz6Nick+RnX/du7mjdKzJUPxO8MEsftruvjCZ9h958hpvTQn6iO8pYs3otJfWxhAZLMUTlCXPrOySye3aH12htp0kmVkGkGkcABfwRHGkowQHxww+99k1oqhevY4dM7jQTPIjZtCGp1QKuzkF1B0oGCKbKMgtOPtCZx+sFX/5UsUbXgi34O4aMaHMKDQgYJqvatn4l1sc4s840wMP4++VR5m0FUnyPR0BjpVLH7qpByHPOIJps3NdnWHdwA2xOnn43BFnPV6bwoAAjNz7e/eHB4cw== Received: from DB6P189MB0568.EURP189.PROD.OUTLOOK.COM (2603:10a6:6:31::16) by PAVP189MB2410.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:30c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Mon, 17 Apr 2023 14:22:36 +0000 Received: from DB6P189MB0568.EURP189.PROD.OUTLOOK.COM ([fe80::5849:317a:3d56:7846]) by DB6P189MB0568.EURP189.PROD.OUTLOOK.COM ([fe80::5849:317a:3d56:7846%6]) with mapi id 15.20.6298.030; Mon, 17 Apr 2023 14:22:36 +0000 From: David Binderman To: Peng Zhang CC: "Liam.Howlett@oracle.com" , "linux-mm@kvack.org" , Linux Kernel Mailing List , "maple-tree@lists.infradead.org" Subject: Re: linux-6.3-rc6/lib/maple_tree.c: Two style issues Thread-Topic: linux-6.3-rc6/lib/maple_tree.c: Two style issues Thread-Index: AQHZa3oGkjmGjA5gLkua9Txw7MMTQa8kNJAAgAAIsiQ= Date: Mon, 17 Apr 2023 14:22:36 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [F6uosOT4urZ2bMpbyNb9rC6oLKTKk5XM] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB6P189MB0568:EE_|PAVP189MB2410:EE_ x-ms-office365-filtering-correlation-id: 47e2f971-a146-4862-6135-08db3f4f3175 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z/JCHBSEWQxa1wVvDIhwUbzK7Uw7p39Dl7GettxbEXTNfiCW8S772GInowPqA6+dSrTaFL36J6Q3H3KjQxN9BtOKR7ykttunm2Fpq0jcOiOdN06r2DM+0HU+rjKEqxWzGglb6NPW4W3spFrwwY35yBnCcmB87y6yEq5ZjxRJOrw5HHr9R0oa2IdxfOy6P+zCoXbfWRK7FHt6vRijmv/pIt9v3rffdpxckeaRsBUeTd0+gCP9wwBSTs3za4MSSh+jTqhe6tEN/1tU8sfztZvyi9QHhAlJcs1aqAzp4UIAJ5coB2heLvScoJcN9FZurTNb/C9UbD+HRyRT/vYqfRfIof2Jfv13F/I1dLDZcXq8SkY2jnU9Hj+I7tRB83J1TkdZolnrVDYlPcQZGappzMuwfxAIhXnQxLPoBRRGMX5d42uLGkNWpLOE4J6VovEtfcBN8rYNAQRocAfSxyVrprJsDqWvUXZkr5GhU5jf+3TP7LRqtJ8NY2C7sF4F6VB/rRN8gcjRnFAdWqZ8VoZO3i5Y1/5zyOZ2m8VR+ThMemwUllDdONqxHA1FO0RcUj2d2HCLhCDzahF4zNbU8KkqL0dPi1HiqhJQAhLi+uoQWrsn+xr4FCjjuH5i2YXaESuudYyg x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?uKNZibjFH0FyoK9qDWPJoTZ1W5M1qmwmE7JaBEZgPgzC1Bgy3VS78z8v0U?= =?iso-8859-1?Q?obcqWXsSPmmg8C7IgmutX2baWGSsHBID61bk7zPwQAkt3F28kewwZmIY3V?= =?iso-8859-1?Q?2m00l6ylWz9k42QecGsxiCc9MOo0z0/dr0L499bVUK+OtDqqpX2iVWKib4?= =?iso-8859-1?Q?5w46xm5svE/mrc3/vybXgMCWanXDnC0FvABJmL1ULwvwfHhmiuPZB077z/?= =?iso-8859-1?Q?BmCW9RTvwTpy964zMjq5jAnP6CBbOxDPfW6+DrA9F42gxQgdcePXxd+rNc?= =?iso-8859-1?Q?lhL6U5nygFhEUA/90r18xsD+Ssv5Fj/Fjd34+/nMd54v2/7TbgefkaPCcW?= =?iso-8859-1?Q?NwbJTdNSElzooXAbmCy4Em2zh2o3I5nzeqJ4znlwGC+W3Ua4TGXxLvnQQd?= =?iso-8859-1?Q?oXhAwB2PpBKNCHkNHPZYOXC7TihvsW9mMHQanxo1263SOy30SJ2oK+o0y2?= =?iso-8859-1?Q?ykI/p6jicbK5rab+IRwOc3dNh2AiMFGY1sOwyjDHdqYYFmlGg7mzybDFtt?= =?iso-8859-1?Q?sbbCazNUfvDH2LZr7TLrPLrkxJ4VTNXsYysmd9ECIn9m5vwZAOcn6ONDFw?= =?iso-8859-1?Q?HqhW7Xi6/ssa9hyJl+Xbfh7FC8nurXq9Yqtgyq+yPsL3ZsP+nZ0ZboM5wu?= =?iso-8859-1?Q?Wq0Uv8LR4irPOCyCsD6iycdDBxnTbH55LJDX4VS9WzCsOIITmOXVf7okze?= =?iso-8859-1?Q?Nyoe2c3qJ9XzhnP1zpN2e586fHB8JySbHJv01FZ4dhMnAbxfgwc2Urn7aB?= =?iso-8859-1?Q?kfyd+0RrBmrjAckIU5jT6irjdIUsqJPUmwVV+2EnoxAcGpFQEhFBCKzRJM?= =?iso-8859-1?Q?lpe6rFRGAHdSJewAEgVFVznpdlbP1NqDyDitHVsRk0meGyEXbAzCf/ckv4?= =?iso-8859-1?Q?d3ZEFhgcu36bv0OGA0MiQx8HdXQETDOWOk9Z+DRgbyUWjE3zMUrSyJ+fDJ?= =?iso-8859-1?Q?X1gQXxFiTbMpV6WTl8UsM9e90NYpB8k+n8VBVpnZ7kLAnNlCPgFkd53SyH?= =?iso-8859-1?Q?D/GEmdN8WMsB6zbGaEUugDNOgTZBqdRAiL0aZTEg7FsDVtSgvxbBBfv/3i?= =?iso-8859-1?Q?e9oVfbrFCrFuTwjmFmHNhzYtTAf60ON3pKQFmP1cT4II+IJSz8aD3Xm5tj?= =?iso-8859-1?Q?PWzY34fjxLsJX5G7r1XGHFV6xc9U/lmuI/PvapYKvLI6gQKXg8pL6rHOHl?= =?iso-8859-1?Q?0aUDplpqIgLz+SnQ6lAzqKf3Hm+nzE0JXc0aOWVSImEUpWmwkspJQYiz?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4734-24-msonline-outlook-c54b5.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB6P189MB0568.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 47e2f971-a146-4862-6135-08db3f4f3175 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2023 14:22:36.7353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVP189MB2410 X-Rspam-User: X-Rspamd-Queue-Id: 55A014000F X-Rspamd-Server: rspam01 X-Stat-Signature: ar78m41ssf318zagesahy4h9tti7w79k X-HE-Tag: 1681741359-255283 X-HE-Meta: U2FsdGVkX19v9FyIa+t3dt3vrCwWoGBTuEABYBRHsGLFr6CXhr5WFjGcjOQwa/vjnkRL3mCrHG7lrRXL/rzhKNWbXMoNGaK+IsRBYSRiuq/K4GoxpqJ2W4WtH7cT27tHSrwTUOPu4TZB/XEUBnnuOQ+VMA+qllXRqAOOxZYsmgyCpaAO7wgMrdTNrQCiQgZNM8NjVIuvm5dQVJGU2GqqX2Lrm6HyU0NfC/1KgTy564S2me5JwvLt2VWijdtgXk7NiJgaMMTESc5oHIYJHh9HYMN5p76iQZ5CsJhjQeQziDV0aY7LUBmkYtF+aCT3Pz5OcQ9ke6/oJskGUHUY22eAztDEC3MHDE7OORVJEzMBwObDBHcfTEVc86hyujKwgxPgxghmFm5NnvFjzCAUrvZwwqqSehyViVHaKTWlVTliHdaA8ad/iB+pxsl/DLjexdZ925Q50ex0S9NZJXMoJmR+LFUGAYxXg7uNQlBLmYNK7UmPalpzQQYsYzFXR3fioJK+lXbOkGwIrK1cV+T0EhpOdzirWEs43ELlUJKVoU0yapBzmMmuRc5jBA5554YISw8eCH51MXPjlIz9Vsc5ALseRnhylMp4LhxQF9s0wihkmQzKRPs2j67bSdFli+iapPT89qQcTvKEFhyiKRD6rrWZkPiODkk4cYCXGoQbme4AGQAK1QSpBFdK75+WPjUSwg22wsqpAlbqydEq1G6mTPZ6b69LvB+jsT1r8PAyjWYF/wivn2RN4RQiHFifzzBtFtBDRXRBsEN0EcumivezMB9U5JjdBsHiS2Wy3uxn7Sc5oWpQu+YnDSJgNr7WaepN2HofAp35uZRtNJImkPQ5A32KzxMlGgzhjIDVOdi6NPnpRpz89bKKMLO2/rncr4yynTPXFAQJhhQmIRX3ziGj6iIRzCGDdvLG1CMVNPN1//VhJDjd0zmTWAXLbJrH6WFuQywUJ5oRyjhUE6XYCXQzQxy qPIqKM+w OKNjxXHUXJRFofMBemtKIjg5AuBTPUGAHn+q/Ni07DQ7FB0cEHa2PVgT2vJ1ziq1IVd2BcEzONMj3+y5mJuthIm1B9hC4/qbfIa2G4ZaWFJ6Ug/T/J1elInr79ZhgauA2U0C62QVPWD3sNnX5PUxq039NLMGIu8KOsn9m1VgLBmlF8F5qYaifH6aGT+2MQHO2s8dMBE6n5AM39+95sqHBo1sk0HYsEksUBd6GyHxfaHRe3B+nUmjSg3a8iHidkD0Xslg60PgFRmd/VJ08ttg17beWaARHJF0yw0sptXIslxZi+OfCrdbDkbyBEL5u/SO0Q1S4VO1HBrcKZgh6U3pdhKyzEjfyBeey9gdPUQH1m8LMKu4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000672, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello there,=0A= =0A= >It should be fine here. =0A= =0A= Perhaps I have been slightly less than clear. The discussion is about the *= style*=0A= of the code, *not* whether it works or not. My apologies for the lack of cl= arity. =0A= =0A= Expression is=0A= =0A= while (A &&=0A= B && C)=0A= =0A= The static analyser notices it is poor style to have B do a limit check, bu= t have A use it.=0A= Sure its working code, but suggest new code=0A= =0A= while (B && A && C)=0A= =0A= It won't make much difference to the code, it will merely be better style.= =0A= =0A= 2.=0A= =0A= >> Source code is=0A= >>=0A= >>=A0 =A0 =A0 =A0 =A0 =A0 =A0memset(pivs + tmp, 0,=0A= >>=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(unsigned long *) * (max= _p - tmp));=0A= =0A= >It's not good here, I can fix it.=0A= =0A= sizeof( pivs[ 0]) is a better thing to say than sizeof( unsigned long). =0A= There is reduced future maintenance burden, when the type of *pivs changes.= =0A= =0A= Regards=0A= =0A= David Binderman=0A=