From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 695EB6001DA for ; Tue, 19 Jan 2010 03:33:45 -0500 (EST) From: "Zheng, Shaohui" Date: Tue, 19 Jan 2010 16:33:08 +0800 Subject: RE: [PATCH-RESEND v4] memory-hotplug: create /sys/firmware/memmap entry for new memory Message-ID: References: <20100115143812.b70161d2.akpm@linux-foundation.org> In-Reply-To: <20100115143812.b70161d2.akpm@linux-foundation.org> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "ak@linux.intel.com" , "y-goto@jp.fujitsu.com" , Dave Hansen , "Wu, Fengguang" , "x86@kernel.org" List-ID: I did some investigation for my patch, I see that there is an error when I = make v4 patch from v3, I change the function firmware_map_add_early() by ca= relessness,=20 The code=20 entry =3D alloc_bootmem(sizeof(struct firmware_map_entry)); was changed to=20 entry =3D kmalloc(sizeof(struct firmware_map_entry), GFP_ATOMIC); The modification from v3 to v4 is minor, so I did not do full testing for v= 4 patch, I apologize for my fault.=09 The patch works after I correct the this code. I will resend it.=20 Thanks & Regards, Shaohui -----Original Message----- From: Andrew Morton [mailto:akpm@linux-foundation.org]=20 Sent: Saturday, January 16, 2010 6:38 AM To: Zheng, Shaohui Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org; ak@linux.intel.com; y= -goto@jp.fujitsu.com; Dave Hansen; Wu, Fengguang; x86@kernel.org Subject: Re: [PATCH-RESEND v4] memory-hotplug: create /sys/firmware/memmap = entry for new memory On Mon, 11 Jan 2010 10:00:11 +0800 "Zheng, Shaohui" wrote: > memory-hotplug: create /sys/firmware/memmap entry for hot-added memory >=20 > Interface firmware_map_add was not called in explict, Remove it and add f= unction > firmware_map_add_hotplug as hotplug interface of memmap. >=20 > When we hot-add new memory, sysfs does not export memmap entry for it. we= add > a call in function add_memory to function firmware_map_add_hotplug. >=20 > Add a new function add_sysfs_fw_map_entry to create memmap entry, it can = avoid=20 > duplicated codes. The patch causes an early exception in kmem_cache_alloc_notrace() - probably due to a null cache pointer. config: http://master.kernel.org/~akpm/config-akpm2.txt -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org