From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A837C3ABBF for ; Wed, 7 May 2025 15:27:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5C476B0093; Wed, 7 May 2025 11:27:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0B786B009C; Wed, 7 May 2025 11:27:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D4346B00A1; Wed, 7 May 2025 11:27:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7E2996B0093 for ; Wed, 7 May 2025 11:27:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 86BE7C0718 for ; Wed, 7 May 2025 15:27:23 +0000 (UTC) X-FDA: 83416490766.26.E8CD7F1 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf07.hostedemail.com (Postfix) with ESMTP id 9E84840010 for ; Wed, 7 May 2025 15:27:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="NfTd/LfT"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of 32HsbaAgKCIUsjltvjwkpxxpun.lxvurw36-vvt4jlt.x0p@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=32HsbaAgKCIUsjltvjwkpxxpun.lxvurw36-vvt4jlt.x0p@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746631641; a=rsa-sha256; cv=none; b=lABEfLpVXihDRlTQ9x+f6Wk+PFZDLu4tqBmf+KVIw/z2aFnOpV1a+/biMj+8Z7QDQIVIMs 2usSMgYeGGBLCTpxgVeHB+J9lzgsX2fxcYi1Boh6Kzv1FKclHTKdpsQ0cn0+7aOHMxLbW0 arcJebOwNM/ef1xRJEU3hlpX1OIDQSg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="NfTd/LfT"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of 32HsbaAgKCIUsjltvjwkpxxpun.lxvurw36-vvt4jlt.x0p@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=32HsbaAgKCIUsjltvjwkpxxpun.lxvurw36-vvt4jlt.x0p@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746631641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UVScMaJsNdWzXaWbUOC+RQZonS9hMcxETO6CXiEAlRw=; b=uoUG8nOyhjNnEk6tyGNHyPxs8JsUb6hjE+8uCCXL9wOBYRHYghnnM8Wrk5os7ILFF2mYOi 9VKOqvZ2nFdHV0Uun4Yciyl2yhT6v3BlNB9D/ZMJRCa5tu8910mSwe+D1iNo54asV53kg3 6hbeSRUmR57v0dLSKP3VYbj5U+UJx3g= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43cf5196c25so60435e9.0 for ; Wed, 07 May 2025 08:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746631640; x=1747236440; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=UVScMaJsNdWzXaWbUOC+RQZonS9hMcxETO6CXiEAlRw=; b=NfTd/LfTQ/4KjGvby+XkaE57KJqa4UDx6Mdy0QX8zZgx7i/0Iq98QqPG6f+RWjUHsw JqbUE8Gy3y/sZK+M2inmYKL0fnLDtRjHdOS6E38PMx1BQhztFoxbBI+PCylU3Ghai98X tDaFA5cTbtFmmK5ij70GtxQ9EVm9NxrvEeT6YeSQbO0pb6Tw/BRFEANeaB6PJDM89G4O M4VUjrAGc71HvxXZGZBYCuUXexRxWMolyP0YVjez9BpZ8kQmEbkXKiGL9HP1k0hR1870 24Puyq8hTH+1Qz2BNrcBzTXEgQx7NWNP62AjIir2MvHKkJ+sfVYta23ZCeHrUU9uzSWu vn+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746631640; x=1747236440; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UVScMaJsNdWzXaWbUOC+RQZonS9hMcxETO6CXiEAlRw=; b=GS72MA3CuXXi34qD1D1mYiGB/QwKLrbADotMYe/FN6MCdvx3WDDnvra2pmnnESlri1 s56ujjydZ/QYmtyDAS/SbVXL2JXVcZwbqVcVzap5QUzM1QlrvCjjAnJ42p+193X9k1AW YCdPI+miHelaGeqWg8eCRbEH1jtSgQwG64seZOlDWJX6YbIn8clXTuaKkXSL4FcaoApA v9LPI+wbn7lgmW0OrvvCjfkd4YpU0nLjVTMWJ17HI0PACBWnCjr5+yZBwt/5W7tUpowa 9OTJXa53/EinigEazU2JFqNnHa35VD6MgQ7U/0ajzJc1kwZf4pd849nEvmaoy7Fs/zFi anUQ== X-Forwarded-Encrypted: i=1; AJvYcCXv50EC+AM2qPYOy71xk8THTeT28X+CI4b93SJdKTTXuIUCQ2OPw8zdNAnvC0s74K9kzo2ySqnPhw==@kvack.org X-Gm-Message-State: AOJu0Yyd6QkUCjPcDdg47xInYaIGRgeSE0Mu82O6oofKnzE7h+bYyY7k Sbq/A10dfIMS1OPDkRDDqRXNlyPBwRXHI6HNSxuP6W5SVjPb8IPFIivI6DyOyrIhdg48KQ9YW/0 WpLh2KRjjIA== X-Google-Smtp-Source: AGHT+IFbv1gkzIUlafRoPSulkZnF0yX8hhTbcTrPKkzq/6eQOecLcqYYtCLGIV57zt9Rt/Zmw0wGOrsHsd3dlA== X-Received: from wmbeq6.prod.google.com ([2002:a05:600c:8486:b0:43c:fd99:1b7e]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:5122:b0:43d:160:cd97 with SMTP id 5b1f17b1804b1-441d44dc257mr25363515e9.25.1746631640335; Wed, 07 May 2025 08:27:20 -0700 (PDT) Date: Wed, 07 May 2025 15:27:18 +0000 In-Reply-To: Mime-Version: 1.0 References: <20250506112509.905147-1-kirill.shutemov@linux.intel.com> <20250506112509.905147-2-kirill.shutemov@linux.intel.com> X-Mailer: aerc 0.20.0 Message-ID: Subject: Re: [PATCH 1/2] mm/page_alloc: Ensure try_alloc_pages() plays well with unaccepted memory From: Brendan Jackman To: "Kirill A. Shutemov" Cc: , , , , , , , , , , , Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9E84840010 X-Stat-Signature: 861txshgqbbyiduau3i1qc8bfpbexc3o X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746631641-322957 X-HE-Meta: U2FsdGVkX19MaKxd+FK4oW25imBhY9jdcIMQimrdYugl+L68W6BHG2vUUYps1A2X/nEhxPiLpzhrgDyhPCuHn+Pb2M1FQSEWXNA6we5VgtVsoVaxPA8/9TxbZhN1HUR8oSEJSOubTHliV0vPFw6xqlF9KA/oHh4UAUUCeetoclYxOZjGFp2RmvD402vAODhKuMg/6aCVFgxABFbzhcEiD2+zNT+adVkZGeOHItU+iDubXXgkxoH/oWbcAEVH0M3+lueCSxi8/3s277DmnAcujsANKyMvxbjqlaQh5QAE8taU/+cskzPBt6fzJsoGXC6RhxXC+H/WZFh2wdvLiVyAwdkuWeJ/8My0NUQm/poxy+zVUd99l/KEeApYzFWxIJqu4THVudKqrWHT8I0SKRk7JT8yDxYIF+AuKWDkMinkYcf4jaLf1HH6MIlUdOLt54LZh/purvahD67VagWIdJl6zziN4556NbRqK4XLOa234U4Ts+/uSRw00NxanRCbKx8OMc6/zwmui5rpxC7KOrYl003lNWHbBxKoaIo/qvWZeLYhCFZWoCjKBV8vSPfp/chtKoAkweHRyaE17RJ+9opqdbmxswrx4UQSvXWwSk5iQk48fSoI2pC4bNYohmd5C4YTCUsYVgYz9/haIiWVhtjG8lbt2d5VseECSiPQIkFVKva8lpvmckDPpnjL1t8y+jCeVOcXsGpb66XRnTY2Vb3OuCa4eWQL/n7QA4z3ukg3CbkUA0zqUatTuVRhqIbqpuNICZDlb4W56sNOZ5OY/bBaNB+VVMOZsi6zYdN+R+uNzDZ6VWpJS4BxHdiuZPpUP1oYdFt4EklCPpcb27MVikpA5U9CmuR0WyhYzg9YaiCtMjJ8r4997xAGvZY2tCYpCYWp5l2x9M+GavEJSCio8f3OOv0UtsKL/NJCC+0hOUdN38Qz5U1r6wTqao1NbkIdBMS+b7wxNJpQ5xJJQQpzbWa XuKNkjZu uw47uwPQKq7m0/TBkSmOchixLhvA+8oYeLzy8iVZQPoweU6bvOAFtZV4d5Taxa60fpam1F84+Bn5pSGDCihpKAAXSNecfkNH1T6QJuJ1imf2ecUx5JH4wE2AeOiTQTCTcu/YBW2uMy9GfB6oTqAQwk0KhFsUTm0XeeGVPNSqdqB1x0jdfVylYbkDBqtu+7R0mmqMAhvN0cd8PXoCNmFyi/UsL/vEyn2cKxGdHaT8V1Wu0ikbpIOdlMOBluNkojdkULd/3AFBacVn7rTSOeRIYtQ5/JSIwMmpsaitldSJICACfcvZ5ZI7WWJoUre5h9L2O8zfr71PRWM3DlxHDQFIXZF7/77mirqL30xo1z+7y3qyGU7yl0SKtbaWczkdhmdrRtAss3UzBVG2tDaDEsT95OSrJAfpIWotH0Vr2//BZfvThoFuGIwIaJLq5Dhwkm8Ebwy7DUYmnHpLGX0rx9BD6hA1IurMRsVlGxNhRJul6AY5petRFd9kGXKOG2NCOw7FW1sqTgcz0oTmsBO8uoKAiMreylnxurrCAUQ6t/MUfHsTjF8whlmhZ6lPp+uCmE/OrMeXmuCpQgtvUIgptgkDPmMNs6Z2BJSbNyhDL0OOJgg04ZB4GWBCKq9FgAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue May 6, 2025 at 1:34 PM UTC, Kirill A. Shutemov wrote: > On Tue, May 06, 2025 at 01:20:25PM +0000, Brendan Jackman wrote: >> On Tue May 6, 2025 at 11:25 AM UTC, Kirill A. Shutemov wrote: >> > + /* Bailout, since try_to_accept_memory_one() needs to take a lock */ >> > + if (alloc_flags & ALLOC_TRYLOCK) >> > + return false; >> > + >> >> Quick lazy question: why don't we just trylock it like we do for the zone >> lock? > > It is not only zone lock. There's also unaccepted_memory_lock inside > accept_memory(). Right, but my lazy question was why can't we "just" trylock that too? But anyway, that's no use because if we win the trylock we'd still have to do __free_pages_ok().