From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5D9C3ABAC for ; Tue, 6 May 2025 10:10:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0205B6B0085; Tue, 6 May 2025 06:10:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0F4C6B0088; Tue, 6 May 2025 06:10:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAF3B6B0089; Tue, 6 May 2025 06:10:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BCA186B0085 for ; Tue, 6 May 2025 06:10:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 169FBCCD29 for ; Tue, 6 May 2025 10:10:39 +0000 (UTC) X-FDA: 83412063798.18.E50395C Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf10.hostedemail.com (Postfix) with ESMTP id 237EFC0011 for ; Tue, 6 May 2025 10:10:36 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=OdoolDHc; spf=pass (imf10.hostedemail.com: domain of rkrcmar@ventanamicro.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=rkrcmar@ventanamicro.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746526237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MDlCPukG676ZkXDqA7+irYPpUi8ypltoa/WLU7iYTZw=; b=UC6HRgARV0qFUk0BF/Vcg236kIufgaPmrVoN4asEy+v/R2ibypGRKk1kDSWwZAoU9dNo3A ErpeRCKgUVqfovGM27keISqUFBaP2GdJ3ipCLguDyHBvinzMVE6KLTGZZRodDtbDncddJr 243J9JofUcYoJhttHQ1ZpK3U3sldFyE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ventanamicro.com header.s=google header.b=OdoolDHc; spf=pass (imf10.hostedemail.com: domain of rkrcmar@ventanamicro.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=rkrcmar@ventanamicro.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746526237; a=rsa-sha256; cv=none; b=eUa7SnXMEzkR/Q8STd8WX1/nT+rHAPpfyxL9dSjhYtKf9vuCmXx4cAT6PyGHnvJpNrusE9 40mMl0aPVtD7I6OeBoH+YsTXofcqafhF2qSUA8LIM3FDPlFtLDpXervxbY4Eb8XVIEiRjY o1q/2GAbOFx1kfcB54QljFJj5WKdZs4= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3912387cf48so115318f8f.3 for ; Tue, 06 May 2025 03:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1746526235; x=1747131035; darn=kvack.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MDlCPukG676ZkXDqA7+irYPpUi8ypltoa/WLU7iYTZw=; b=OdoolDHc7k19NC6Hp3YeLFVHvBnvP8ZVCE6bBP64m2+GuCX264ULfiW6DvUier18u/ t42+nw/ClKPqs7MV9gYCeC31EKmkj3sRBedvpbeUReORy6K+fH2fPN1l3FEtEe6pNhtS flYpdeqAUlruoUP4cytAPDPUIjg2J1cmzdnbrszFQLDrGmzSMiNfTVOMbi2/BFFP1Jz+ sUjyf6jwH6t9J23dfdMQU9iSQ2uQTHKqCHpQ8393m7K8bLx2yqPASyQ0Xybyw7ztVEhi JfNs0dDw7BfSfMXRZOKUucl0NLqj+UYkImy383dx2W1yqdcooR0qB28RU7N0LlQfJK7U m08g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746526235; x=1747131035; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MDlCPukG676ZkXDqA7+irYPpUi8ypltoa/WLU7iYTZw=; b=UOqIg91P/zyKQokUggYCqkPurTSfqhTnHMAjAG9cd4unMjuggMNWdP94iA/lZMs/t3 L8qNDKL6fk7qPo/09VtKvG5O6QVdSHzxrVYxq3d4M0BPG9bs68/MfVXd0ZsuI0AwJvVH m8LVFYdm9sGvchO3dZQw2u1jV+9jubdSd5RgmDqsq44BNWEaX1SrKn5DkmNYZd0sr6l7 ktlLT1nNFTDtNXaxUTJQlfpPcAhv+FiAWFIzZFQPh6Gj5DIKN+AZx7jiO6QR3GU8EZVf vLiQlH06COHNC6L7L579yA4V45yRhQ8hYH+MUQ2QY8HyWqZGLMNwomVwzQI5m5SbmKdv lorA== X-Forwarded-Encrypted: i=1; AJvYcCXCnEWcIkM/WFjvISDw5ChE1E5ptRaPG5Pr++XWlsTp95vo8kR+jbxM9+o98xQJ+EFuawGtnfpzGQ==@kvack.org X-Gm-Message-State: AOJu0Ywga/4Oxe2QKhJ7slyAoL5mhbBjlXMrtZc/Ao5kfHlcNX9La6r4 hT0rlFZYH/16WAfuBVNd1Q9BPnA7w4yXV70DRiyAfRsMyDLl/ikv+3Lz04E1HmY= X-Gm-Gg: ASbGncsibkvOxrAbl+YsdYRE9Zt7QzsDw77DXvZduMzpEjOqS+5h1wygel1fRoR7J4z aQAh6XEA7trsSfyRWg7rhMGzc577xlkMoiJqG2q2gTDqayUncdHwMzbki32JbnGj/KcI1Wl19yP 7qpSiuNd29NXrnt5t1vY4ymz1VjhzLCXYztIeFp/YlIcW0QPXZm6n/0766lbsX7aKmT2jild08E v0Ssz9FHYfgZfWba/vYwuydiDS9hAmZZC4rPN2J0FbfzFqyY9Mc9sRGXqQQbNvx4WSIbcqFUS3j yF+KSVmDExSqpOCtZx0lcLgSNQnqMy6dDwbm4nI2AP08dxuq X-Google-Smtp-Source: AGHT+IEUjKjGwlmMCjrKZvF7YuhMUsrs5D+dPoN1CPSaPd4oD3QBATAQzTQqUOqU1bgynoQlRYwsyA== X-Received: by 2002:a05:6000:144a:b0:3a0:9f28:2e53 with SMTP id ffacd0b85a97d-3a09f282ec4mr3244079f8f.0.1746526235363; Tue, 06 May 2025 03:10:35 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:d5f0:7802:c94b:10f6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b89cc441sm166448565e9.3.2025.05.06.03.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 03:10:35 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 06 May 2025 12:10:34 +0200 Message-Id: Subject: Re: [PATCH v15 05/27] riscv: usercfi state for task and save/restore of CSR_SSP on trap entry/exit Cc: , , , , , , , , , , , , , , , , , , , , , , "Zong Li" , "linux-riscv" To: "Deepak Gupta" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , , "H. Peter Anvin" , "Andrew Morton" , "Liam R. Howlett" , "Vlastimil Babka" , "Lorenzo Stoakes" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Conor Dooley" , "Rob Herring" , "Krzysztof Kozlowski" , "Arnd Bergmann" , "Christian Brauner" , "Peter Zijlstra" , "Oleg Nesterov" , "Eric Biederman" , "Kees Cook" , "Jonathan Corbet" , "Shuah Khan" , "Jann Horn" , "Conor Dooley" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20250502-v5_user_cfi_series-v15-0-914966471885@rivosinc.com> <20250502-v5_user_cfi_series-v15-5-914966471885@rivosinc.com> In-Reply-To: <20250502-v5_user_cfi_series-v15-5-914966471885@rivosinc.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 237EFC0011 X-Stat-Signature: 7jmgzxoqmk9uhy8trwkmsbgqkok3e89u X-HE-Tag: 1746526236-70538 X-HE-Meta: U2FsdGVkX193NndUKiz/sjsNSOnNU04knro7laFjcq3b1yETh63RBiTpkjgMxn9k+IzUlI6aHpFElAME+zYWiOy8PHel8Yncp7NZ2Kd1A/cwPC9AmWuSiRuUFLr8+IDxkwMVdr3YEpb+C0LssHsIHwk93opLHJQvdwoLPTGIl3xWSUF/LxTOi8VBzUiGnYpR9PIU9q+lZQ9V5tyM7Omwg8e+2vbGOEo+zwdtbI46nv+q0SxtvyugK7x18oAnZUfvxPpCoPOvBSxIiG8lAu1HL955OTcfi8xC2CdwE13iMxjipceGgtdPzQ9DXuIt/1Mdsu0oYo2WqDY7DgGwJU9OE8baBHmvxACJxN12BIBmGO0UDYDob0UM5CEbSuGgghVThUq46KS1/9vxq/KSFH+L0wYOGJm53HWIoRsMwMjojqOflHXhlCLSqdQb/bc+f5B1R+Zs3nm9v7pYYfbqk3WHrbZWtREnPYBUs1aC4zmkIlSAqE8anUE3neUl7NNi0q5GBJcmYfDie9Rlk1Bui33xglGvhMiDUM0NBe4KiihfJVhzfbpDDoWshbg/mSE8UatubdgiHFyagKFOk4AzhcggX3G1lh75eZadVCPIXQkBxDk78KSvKkSd/a/cSzWOzsYMBIvbeicycIGNElhE0tRbRY/+fMgudaL3rFQ+wA2EmrmN8jHL4J/0tozFhh4GNxtimWy6PTB3/LcW1ZH0m4XuA8W24E/PSqgQNsgXPIRG0aAvWqFFabxvHtGdf7Grwd0OS6hhoQxtcGDIUaoTcpueC6S/nqBYJroEt0Qz8PIMbZ9ArcHgt3FCdsydaJmO9Mz4fofrhJ0CyflSqaBXidB5RmNce/W0nQZT1bzmquw3q6sV8KaEl3ginzgQKj4uV6Vnyy/OnM2wzOtVOWkcaoY14j17GsTw3y121yg3JwFk3x6VURmzYroJy1wbzEdpdt/9xZsJTJnPnDlJm2MvuRT D3e6ZUqq 5R2vW+HRQEP1iZSMiJLHOQsI80tj0e+qhLJU0vuL0kqGfrIKzgLt5cCxmr/9c2XN6M9kwObnQPllg2pqe2RAHcbzbgHuXobGtJS07+M+TbMEt9Z0bN6f/IGll9krAfgK5bheGVyvlKqbjMGEykAfDSrOnKDOkHcbNHGs019/dg6usry+cbMuk9zrH6U27KAOxqQrTyZ/3gsMhtnZBHi5aL9MrFj7RDAP8dYf3hGwRfmAweM26Y2AxnPsWMtKQi/efNgtpvqEkq6XvzAKGbDKUp+yJ8UkCjeb1/BFv6LGHKChILJ5+j5zLKqVNJnxTkymZSdNW3CSA2NMr13gW6NjIeIlyHP/C5/AoY4J14Fkg7Yo2OQDHAcK/eMpcuXmxwVbqHmfaLf5vW51Xb7cwH01UeAQzYm/tVGelC/rUgevH0StKP1/Rrnrt+Y7dUchv8JMFZh3ywqWBLnDn17eM3Nv/R4NDyVbzmiAweDEv4dJBABHOCXctoawABQP4QHvC/ds4qJvR/5YSyVHJJWV5kisodxQLtADSCZM76F5wvCN9FM7SklppVC7JUDodTNVMlW1mkI64NiagKfqn6kMsV5yi9x8k2GPE7yjxeNq6vIuzWu0oBw+lOUWUQn8NGc/OMyL3yvdKyUt68k/6cOe0ltGmZzxp1pWzzd/5rc0Db2k+a7rq84oO0TUI+s8cTZuVELirPSIc5nIZOcRSGls= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [Ah, I missed v13 and v14, feel free to Cc me on next versions.] 2025-05-02T16:30:36-07:00, Deepak Gupta : > diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S > @@ -91,6 +91,32 @@ > +.macro save_userssp tmp, status > + ALTERNATIVE("nops(4)", > + __stringify( \ > + andi \tmp, \status, SR_SPP; \ > + bnez \tmp, skip_ssp_save; \ > + csrrw \tmp, CSR_SSP, x0; \ > + REG_S \tmp, TASK_TI_USER_SSP(tp); \ > + skip_ssp_save:), > + 0, > + RISCV_ISA_EXT_ZICFISS, > + CONFIG_RISCV_USER_CFI) > +.endm > + > +.macro restore_userssp tmp > + ALTERNATIVE("nops(2)", > + __stringify( \ > + REG_L \tmp, TASK_TI_USER_SSP(tp); \ > + csrw CSR_SSP, \tmp), > + 0, > + RISCV_ISA_EXT_ZICFISS, > + CONFIG_RISCV_USER_CFI) > +.endm Do we need to emit the nops when CONFIG_RISCV_USER_CFI isn't selected? (Why not put #ifdef CONFIG_RISCV_USER_CFI around the ALTERNATIVES?) Thanks.