From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39493C3ABA3 for ; Fri, 2 May 2025 12:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E12786B0088; Fri, 2 May 2025 08:16:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC0186B0089; Fri, 2 May 2025 08:16:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8AE36B008A; Fri, 2 May 2025 08:16:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AB3A26B0088 for ; Fri, 2 May 2025 08:16:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DA6178006C for ; Fri, 2 May 2025 12:16:22 +0000 (UTC) X-FDA: 83397865404.13.5961F0F Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf25.hostedemail.com (Postfix) with ESMTP id 1413CA0009 for ; Fri, 2 May 2025 12:16:20 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0vJYccMf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of 3k7cUaAgKCJwF68GI6J7CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3k7cUaAgKCJwF68GI6J7CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746188181; a=rsa-sha256; cv=none; b=VCmkqr2v6xfXG0Er5evoX/hhdpzNgOkYC8wcpWRUbOwAlw5hvbIllnJPoMu0mOeu87Uk+d UYGvaXsGNoJIxjpNaFo4ertT+T7IluvdUFCGZVGmYCqgZZnGUmMyFzXwFVxZj7rZL+855Y sqmz9SnPYg6bpKfS4s6Y7ypkvTx06Es= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0vJYccMf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of 3k7cUaAgKCJwF68GI6J7CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3k7cUaAgKCJwF68GI6J7CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746188181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xpQTX7qbtTqiZ2cYzNQe4qlADufga3HtIbspyW6RXEI=; b=OqDGiTz0MOg76pAL56H8h7iITLIcuWUUkMuSRdoUT2GOuSytQRy17SY0s51DArcVddypCp h0dEmLF5nym1TRaI8OrXKsYSKymszNQRA7u5GjnUx1ueauMH/NsLSS/g0u/LeeJJY1J7iY 4RyZTzVSx3SLk38YBgh/iMG3oSM4WXA= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43f251dc364so10668315e9.2 for ; Fri, 02 May 2025 05:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746188179; x=1746792979; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xpQTX7qbtTqiZ2cYzNQe4qlADufga3HtIbspyW6RXEI=; b=0vJYccMfg/4EIauwmMuTBBh7T9e+5+jWFWRskUFIzD6Vucypc7ZTzUrymmAcwskyVs C9QEh82lJZU38BP0nrG+xKmdDP5z+jPfYGoLjlTvlSm0hwIfNNTTE0tCA/IYicRRj7Rs /DvjTnueAXwGrZFPT4kCD+OQCyFrERjKqbybeuLHWQuqUKIqBZBzApxeBDoMs5FpsrIw nHpo940afPs+p8ySZkeqP+LJ1mPyIpRzUQ/J3ijnEgc4uYGa4nOsq39co/htPWQvr7W6 i4yJajgeZywtv8x0z8iqB3rwW5fQ/pg4zS/ocQ412EnpptDXrXl/imJ5qBujLCMf071s WOSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746188179; x=1746792979; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xpQTX7qbtTqiZ2cYzNQe4qlADufga3HtIbspyW6RXEI=; b=rG+F0vx1c5kYBYQ+2E/k+Za5Jcdm1W+HA2JWP3NAZ+J/ox7VnJJA+2Py9jm8INKMdl gRjX2LsMY98wKWr7mPQAuqE4YOL40nx6uniXjtkvmyMJ5kELhpOTpKI3fByjtMS1T0gj c9PnlajkKM/+ll7t2SbRh9xXGIOprrR4IIRsutQrl/TVaZUo7yHoEZTvFWRNbqzA7HdJ lqvhctxIK0DUOzvQeZWWIxtyqSJrWUGPf99/2hIDPFxWp2bm4onv3qi+y9gO8M2JhWHk YD6+vvEqfHl9qIBWzYNv5tAJLaHpQdYRGRmmIkRFSDNPgp6Uq1y1PPccBEC95junuTmC F/vw== X-Gm-Message-State: AOJu0YysGAekxdQJ3Hz0P/lL5JWxGazm95gpA3hK3W+dnS/j0CeRpTOJ kqUvAg0ZJewsCAUlKyC/LK1mQe65zvmFrfz6Tgd9+R4RKkntSNVIII4MXkVrxbBXoiBGeNYG5Y2 LZGRsGP/HIg== X-Google-Smtp-Source: AGHT+IHGPJ8d8Rj7Vp0b8xFb7q1PChNxC2PGcrvlNuQ85axCMGpx4XborD9U5msKtCnHqeVLkMXXzpsI/8IeTQ== X-Received: from wmqe18.prod.google.com ([2002:a05:600c:4e52:b0:441:b607:4ec0]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1992:b0:43d:9f2:6274 with SMTP id 5b1f17b1804b1-441bbeb3383mr21806185e9.14.1746188179399; Fri, 02 May 2025 05:16:19 -0700 (PDT) Date: Fri, 02 May 2025 12:16:17 +0000 In-Reply-To: <20250501163827.2598-2-ujwal.kundur@gmail.com> Mime-Version: 1.0 References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250501163827.2598-2-ujwal.kundur@gmail.com> X-Mailer: aerc 0.20.0 Message-ID: Subject: Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct From: Brendan Jackman To: Ujwal Kundur , , , Cc: , , Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1413CA0009 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: e5o8egq4qz9ro1uuingt5be57qb1wkkn X-HE-Tag: 1746188180-688815 X-HE-Meta: U2FsdGVkX19mppTQEcG5BTObKdbAkSmT/Edabht4TA7PN9YAPFJwbdk86mczYwaRt4A5aCp2sVmKKvGSRTBalHljCG9bFPzu9JLnO8vJ1hcKXN9J6RGY5ulcDBCQFP1EnPQt51bLx9wRBllv73DE3mr8oE4pYjtYoPd6dz5G7P7xW7c9dTNml6wpuEW0hHq8/8KC6zbb2wkoWlMAtQuf17eghE+vShYB5vKxMa03Aa56OouvwVJf/sBix9mWNItrjcnRBudN/yDAlUjE/FLZWq0r5Pq6MjHEhXAXEmh4bLVSYu/MdoltuGXUUa16iRQgn4ApQlTnA2CJbEDGRymJHiO00nIGWsu7egK7Qk5lCtKuoP1A8wWaR2upGKKNaqxNGI7lkSqDmOf4MJYHy18ZNFhx+HjlIuKIUIw1gBa7H0EkqVaPU11Xg++AbguX4etzYjHExQZ6Br7HrjdXntmP/O48vAup/Q3dCfmv/X3uJWPWSFGqpnKXu2TU+GmOShnZNSefSNuGR7nukeHuPp9GUM8IPZjR+rcYcN/pKx+foDsbJUpF4LPYM9GsadwdpW+j1LzhE5MWwweDuG4XgFqqAmdUVK9fuGAtNQpC1w2ekBaagu1OdR6yTlu3DOxkI87SASJhhcArpH0/ai8LHNtIuyQwgeJwqhV1ngOcq0MCkTpvF0zwKHOq/E46HfjR0RK+1YMoIDegwRDCvcQBPwKJbsgRGNof7ZWIPvsTtJXpanDA/fUzO++RMYOCczODNjhmLEjeUxVQyF562d94aYDfcV8HLclbHAtERwBf6qAmHrk6e912oxU8ixulcBMzdQrmWrBENEic5GOZYrVolFNmAL3i49agsVOHQRSReARQEUmPwhH/kBYzPzhmHjZ5ePasfjITz4P29kzC8Lg0nf+SKW9Ho7rEgnonHa+nispSOcdlqfMNos3C0PFnlTqWjBQe7oeeXNUTFEggUT3n8JN gKzhmFLw hfB+DpZRVBDl26LLVEFi+JzedAupOfeDzLQRx+dVmFZEVL4AfeqMxPyXEWFQuKXl08eor4gXppbeDeTUJvzXl6IWJmeYbcF0HmavvzlHCYKSxUL2DaCPH3iw1wKz3nsyIT+ffxG3u5HINCR8pHJfhGFGL2LqeKJmCcJMBwxqJb0pBkriDqqly5vQno8KqnXvc34P0duflffNEI5SwHxWClrXdegDxIzcl2Fuz5HSars/4OvLbs9gGx9zGxobP+TYinAZ0TaEG9CIEAZ7VNpYQQ/+ekehfzJc8aSE3mq+Md5CBWtu54MWFWc3YVBpJUmx3imF9pQHhXA1ex1yRcJfJWmUHUv9R3y3E+kBYUI16doZsZpwCQWCLvAgLV9Bda+vChQk/VixVpKMLuX6sI5uI/DUNLF/POP/tZmfJ0p/zjs+jWYpu5Q0gBZRlSdwunGmFSXengFp6CiXwOkawdV0pcy2DIxbnx2OBhQpJIeJZ2vLltH7RsCwJUNxlLHYN0wyXsIahB6VdeHEVgiWSxCgmsVpQKAtaAweVrarFLQF6SlR17n6PIzgaitUfQAcgmA8zE6CzLHVAd7fHU3X5HKJiTywyjEvHQCzgqqOqwiX9P9opVYS+1xEDcD+yFsdr+QYi7SQs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu May 1, 2025 at 4:38 PM UTC, Ujwal Kundur wrote: > + * count is placed in the page after pthread_mutex_t naturally aligned > + * to avoid non alignment faults on non-x86 archs. > + */ > +volatile unsigned long long *area_count( > + char *area, unsigned long nr, > + uffd_global_test_opts_t *gopts) > +{ > + return (volatile unsigned long long *) > + ((unsigned long) (area + nr * gopts->page_size + > + sizeof(pthread_mutex_t) + > + sizeof(unsigned long long) - 1) & > + ~(unsigned long)(sizeof(unsigned long long) - 1)); Stray space after the minus there > -static void retry_copy_page(int ufd, struct uffdio_copy *uffdio_copy, > +static void retry_copy_page(uffd_global_test_opts_t *gopts, struct uffdio_copy *uffdio_copy, > unsigned long offset) > { > - uffd_test_ops->alias_mapping(&uffdio_copy->dst, > + uffd_test_ops->alias_mapping(gopts, > + &uffdio_copy->dst, Little bit of indentation mess here I don't understand this code but since I was hurt by these global variables I had a look over the diff anyway, it LGTM (aside from the formatting nits), thanks. Reviewed-by: Brendan Jackman