linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: add mm THP section
@ 2025-04-24 11:16 Lorenzo Stoakes
  2025-04-24 11:20 ` David Hildenbrand
                   ` (6 more replies)
  0 siblings, 7 replies; 12+ messages in thread
From: Lorenzo Stoakes @ 2025-04-24 11:16 UTC (permalink / raw)
  To: Andrew Morton
  Cc: David Hildenbrand, Zi Yan, Baolin Wang, Liam R . Howlett,
	Nico Pache, Ryan Roberts, linux-mm, linux-kernel

As part of the ongoing efforts to sub-divide memory management
maintainership and reviewership, establish a section for Transparent Huge
Page support and add appropriate maintainers and reviewers.

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 MAINTAINERS | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4015227645cc..85cd47a28a0a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15563,6 +15563,29 @@ S:	Maintained
 F:	include/linux/secretmem.h
 F:	mm/secretmem.c
 
+MEMORY MANAGEMENT - THP (TRANSPARENT HUGE PAGE)
+M:	Andrew Morton <akpm@linux-foundation.org>
+M:	David Hildenbrand <david@redhat.com>
+R:	Zi Yan <ziy@nvidia.com>
+R:	Baolin Wang <baolin.wang@linux.alibaba.com>
+R:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
+R:	Liam R. Howlett <Liam.Howlett@oracle.com>
+R:	Nico Pache <npache@redhat.com>
+R:	Ryan Roberts <ryan.roberts@arm.com>
+L:	linux-mm@kvack.org
+S:	Maintained
+W:	http://www.linux-mm.org
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	Documentation/admin-guide/mm/transhuge.rst
+F:	include/linux/huge_mm.h
+F:	include/linux/khugepaged.h
+F:	include/trace/events/huge_memory.h
+F:	mm/huge_memory.c
+F:	mm/khugepaged.c
+F:	tools/testing/selftests/mm/khugepaged.c
+F:	tools/testing/selftests/mm/split_huge_page_test.c
+F:	tools/testing/selftests/mm/transhuge-stress.c
+
 MEMORY MANAGEMENT - USERFAULTFD
 M:	Andrew Morton <akpm@linux-foundation.org>
 R:	Peter Xu <peterx@redhat.com>
-- 
2.49.0



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 11:16 [PATCH] MAINTAINERS: add mm THP section Lorenzo Stoakes
@ 2025-04-24 11:20 ` David Hildenbrand
  2025-04-24 11:28 ` Dev Jain
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 12+ messages in thread
From: David Hildenbrand @ 2025-04-24 11:20 UTC (permalink / raw)
  To: Lorenzo Stoakes, Andrew Morton
  Cc: Zi Yan, Baolin Wang, Liam R . Howlett, Nico Pache, Ryan Roberts,
	linux-mm, linux-kernel

On 24.04.25 13:16, Lorenzo Stoakes wrote:
> As part of the ongoing efforts to sub-divide memory management
> maintainership and reviewership, establish a section for Transparent Huge
> Page support and add appropriate maintainers and reviewers.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
>   MAINTAINERS | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4015227645cc..85cd47a28a0a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15563,6 +15563,29 @@ S:	Maintained
>   F:	include/linux/secretmem.h
>   F:	mm/secretmem.c
>   
> +MEMORY MANAGEMENT - THP (TRANSPARENT HUGE PAGE)
> +M:	Andrew Morton <akpm@linux-foundation.org>
> +M:	David Hildenbrand <david@redhat.com>
> +R:	Zi Yan <ziy@nvidia.com>
> +R:	Baolin Wang <baolin.wang@linux.alibaba.com>
> +R:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> +R:	Liam R. Howlett <Liam.Howlett@oracle.com>
> +R:	Nico Pache <npache@redhat.com>
> +R:	Ryan Roberts <ryan.roberts@arm.com>
> +L:	linux-mm@kvack.org
> +S:	Maintained
> +W:	http://www.linux-mm.org
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	Documentation/admin-guide/mm/transhuge.rst
> +F:	include/linux/huge_mm.h
> +F:	include/linux/khugepaged.h
> +F:	include/trace/events/huge_memory.h
> +F:	mm/huge_memory.c
> +F:	mm/khugepaged.c
> +F:	tools/testing/selftests/mm/khugepaged.c
> +F:	tools/testing/selftests/mm/split_huge_page_test.c
> +F:	tools/testing/selftests/mm/transhuge-stress.c

Thanks Lorenzo!

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 11:16 [PATCH] MAINTAINERS: add mm THP section Lorenzo Stoakes
  2025-04-24 11:20 ` David Hildenbrand
@ 2025-04-24 11:28 ` Dev Jain
  2025-04-24 11:34   ` Lorenzo Stoakes
  2025-04-24 11:39 ` Lorenzo Stoakes
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 12+ messages in thread
From: Dev Jain @ 2025-04-24 11:28 UTC (permalink / raw)
  To: Lorenzo Stoakes, Andrew Morton
  Cc: David Hildenbrand, Zi Yan, Baolin Wang, Liam R . Howlett,
	Nico Pache, Ryan Roberts, linux-mm, linux-kernel



On 24/04/25 4:46 pm, Lorenzo Stoakes wrote:
> As part of the ongoing efforts to sub-divide memory management
> maintainership and reviewership, establish a section for Transparent Huge
> Page support and add appropriate maintainers and reviewers.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

If you don't mind, I'd also like to be added as reviewer, I am primarily
active in THP stuff : )

> ---
>   MAINTAINERS | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4015227645cc..85cd47a28a0a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15563,6 +15563,29 @@ S:	Maintained
>   F:	include/linux/secretmem.h
>   F:	mm/secretmem.c
>   
> +MEMORY MANAGEMENT - THP (TRANSPARENT HUGE PAGE)
> +M:	Andrew Morton <akpm@linux-foundation.org>
> +M:	David Hildenbrand <david@redhat.com>
> +R:	Zi Yan <ziy@nvidia.com>
> +R:	Baolin Wang <baolin.wang@linux.alibaba.com>
> +R:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> +R:	Liam R. Howlett <Liam.Howlett@oracle.com>
> +R:	Nico Pache <npache@redhat.com>
> +R:	Ryan Roberts <ryan.roberts@arm.com>
> +L:	linux-mm@kvack.org
> +S:	Maintained
> +W:	http://www.linux-mm.org
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	Documentation/admin-guide/mm/transhuge.rst
> +F:	include/linux/huge_mm.h
> +F:	include/linux/khugepaged.h
> +F:	include/trace/events/huge_memory.h
> +F:	mm/huge_memory.c
> +F:	mm/khugepaged.c
> +F:	tools/testing/selftests/mm/khugepaged.c
> +F:	tools/testing/selftests/mm/split_huge_page_test.c
> +F:	tools/testing/selftests/mm/transhuge-stress.c
> +
>   MEMORY MANAGEMENT - USERFAULTFD
>   M:	Andrew Morton <akpm@linux-foundation.org>
>   R:	Peter Xu <peterx@redhat.com>



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 11:28 ` Dev Jain
@ 2025-04-24 11:34   ` Lorenzo Stoakes
  0 siblings, 0 replies; 12+ messages in thread
From: Lorenzo Stoakes @ 2025-04-24 11:34 UTC (permalink / raw)
  To: Dev Jain
  Cc: Andrew Morton, David Hildenbrand, Zi Yan, Baolin Wang,
	Liam R . Howlett, Nico Pache, Ryan Roberts, linux-mm,
	linux-kernel

On Thu, Apr 24, 2025 at 04:58:20PM +0530, Dev Jain wrote:
>
>
> On 24/04/25 4:46 pm, Lorenzo Stoakes wrote:
> > As part of the ongoing efforts to sub-divide memory management
> > maintainership and reviewership, establish a section for Transparent Huge
> > Page support and add appropriate maintainers and reviewers.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> If you don't mind, I'd also like to be added as reviewer, I am primarily
> active in THP stuff : )

Of course! Apologies for not including initially, really just squinting at git
at guesstimating here :)

Will send a fix-patch in reply to top-level.

>
> > ---
> >   MAINTAINERS | 23 +++++++++++++++++++++++
> >   1 file changed, 23 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4015227645cc..85cd47a28a0a 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15563,6 +15563,29 @@ S:	Maintained
> >   F:	include/linux/secretmem.h
> >   F:	mm/secretmem.c
> > +MEMORY MANAGEMENT - THP (TRANSPARENT HUGE PAGE)
> > +M:	Andrew Morton <akpm@linux-foundation.org>
> > +M:	David Hildenbrand <david@redhat.com>
> > +R:	Zi Yan <ziy@nvidia.com>
> > +R:	Baolin Wang <baolin.wang@linux.alibaba.com>
> > +R:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > +R:	Liam R. Howlett <Liam.Howlett@oracle.com>
> > +R:	Nico Pache <npache@redhat.com>
> > +R:	Ryan Roberts <ryan.roberts@arm.com>
> > +L:	linux-mm@kvack.org
> > +S:	Maintained
> > +W:	http://www.linux-mm.org
> > +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:	Documentation/admin-guide/mm/transhuge.rst
> > +F:	include/linux/huge_mm.h
> > +F:	include/linux/khugepaged.h
> > +F:	include/trace/events/huge_memory.h
> > +F:	mm/huge_memory.c
> > +F:	mm/khugepaged.c
> > +F:	tools/testing/selftests/mm/khugepaged.c
> > +F:	tools/testing/selftests/mm/split_huge_page_test.c
> > +F:	tools/testing/selftests/mm/transhuge-stress.c
> > +
> >   MEMORY MANAGEMENT - USERFAULTFD
> >   M:	Andrew Morton <akpm@linux-foundation.org>
> >   R:	Peter Xu <peterx@redhat.com>
>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 11:16 [PATCH] MAINTAINERS: add mm THP section Lorenzo Stoakes
  2025-04-24 11:20 ` David Hildenbrand
  2025-04-24 11:28 ` Dev Jain
@ 2025-04-24 11:39 ` Lorenzo Stoakes
  2025-04-24 11:55 ` Ryan Roberts
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 12+ messages in thread
From: Lorenzo Stoakes @ 2025-04-24 11:39 UTC (permalink / raw)
  To: Andrew Morton
  Cc: David Hildenbrand, Zi Yan, Baolin Wang, Liam R . Howlett,
	Nico Pache, Ryan Roberts, linux-mm, linux-kernel

On Thu, Apr 24, 2025 at 12:16:32PM +0100, Lorenzo Stoakes wrote:
> As part of the ongoing efforts to sub-divide memory management
> maintainership and reviewership, establish a section for Transparent Huge
> Page support and add appropriate maintainers and reviewers.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
[snip]

Hi Andrew,

Could we update this to include Dev as a reviewer also? Fix patch included.

Thanks, Lorenzo

----8<----
From 5f141e0fbc0d177dd489484e5504f283ec206267 Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Date: Thu, 24 Apr 2025 12:33:35 +0100
Subject: [PATCH] MAINTAINERS: add Dev Jain as THP reviewer

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 85cd47a28a0a..596eff35762f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15572,6 +15572,7 @@ R:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
 R:	Liam R. Howlett <Liam.Howlett@oracle.com>
 R:	Nico Pache <npache@redhat.com>
 R:	Ryan Roberts <ryan.roberts@arm.com>
+R:	Dev Jain <dev.jain@arm.com>
 L:	linux-mm@kvack.org
 S:	Maintained
 W:	http://www.linux-mm.org
--
2.49.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 11:16 [PATCH] MAINTAINERS: add mm THP section Lorenzo Stoakes
                   ` (2 preceding siblings ...)
  2025-04-24 11:39 ` Lorenzo Stoakes
@ 2025-04-24 11:55 ` Ryan Roberts
  2025-04-24 12:23 ` Baolin Wang
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 12+ messages in thread
From: Ryan Roberts @ 2025-04-24 11:55 UTC (permalink / raw)
  To: Lorenzo Stoakes, Andrew Morton
  Cc: David Hildenbrand, Zi Yan, Baolin Wang, Liam R . Howlett,
	Nico Pache, linux-mm, linux-kernel

On 24/04/2025 12:16, Lorenzo Stoakes wrote:
> As part of the ongoing efforts to sub-divide memory management
> maintainership and reviewership, establish a section for Transparent Huge
> Page support and add appropriate maintainers and reviewers.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>

> ---
>  MAINTAINERS | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4015227645cc..85cd47a28a0a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15563,6 +15563,29 @@ S:	Maintained
>  F:	include/linux/secretmem.h
>  F:	mm/secretmem.c
>  
> +MEMORY MANAGEMENT - THP (TRANSPARENT HUGE PAGE)
> +M:	Andrew Morton <akpm@linux-foundation.org>
> +M:	David Hildenbrand <david@redhat.com>
> +R:	Zi Yan <ziy@nvidia.com>
> +R:	Baolin Wang <baolin.wang@linux.alibaba.com>
> +R:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> +R:	Liam R. Howlett <Liam.Howlett@oracle.com>
> +R:	Nico Pache <npache@redhat.com>
> +R:	Ryan Roberts <ryan.roberts@arm.com>
> +L:	linux-mm@kvack.org
> +S:	Maintained
> +W:	http://www.linux-mm.org
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	Documentation/admin-guide/mm/transhuge.rst
> +F:	include/linux/huge_mm.h
> +F:	include/linux/khugepaged.h
> +F:	include/trace/events/huge_memory.h
> +F:	mm/huge_memory.c
> +F:	mm/khugepaged.c
> +F:	tools/testing/selftests/mm/khugepaged.c
> +F:	tools/testing/selftests/mm/split_huge_page_test.c
> +F:	tools/testing/selftests/mm/transhuge-stress.c
> +
>  MEMORY MANAGEMENT - USERFAULTFD
>  M:	Andrew Morton <akpm@linux-foundation.org>
>  R:	Peter Xu <peterx@redhat.com>



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 11:16 [PATCH] MAINTAINERS: add mm THP section Lorenzo Stoakes
                   ` (3 preceding siblings ...)
  2025-04-24 11:55 ` Ryan Roberts
@ 2025-04-24 12:23 ` Baolin Wang
  2025-04-24 17:57 ` Matthew Wilcox
  2025-04-24 19:50 ` Zi Yan
  6 siblings, 0 replies; 12+ messages in thread
From: Baolin Wang @ 2025-04-24 12:23 UTC (permalink / raw)
  To: Lorenzo Stoakes, Andrew Morton
  Cc: David Hildenbrand, Zi Yan, Liam R . Howlett, Nico Pache,
	Ryan Roberts, linux-mm, linux-kernel



On 2025/4/24 19:16, Lorenzo Stoakes wrote:
> As part of the ongoing efforts to sub-divide memory management
> maintainership and reviewership, establish a section for Transparent Huge
> Page support and add appropriate maintainers and reviewers.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   MAINTAINERS | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4015227645cc..85cd47a28a0a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15563,6 +15563,29 @@ S:	Maintained
>   F:	include/linux/secretmem.h
>   F:	mm/secretmem.c
>   
> +MEMORY MANAGEMENT - THP (TRANSPARENT HUGE PAGE)
> +M:	Andrew Morton <akpm@linux-foundation.org>
> +M:	David Hildenbrand <david@redhat.com>
> +R:	Zi Yan <ziy@nvidia.com>
> +R:	Baolin Wang <baolin.wang@linux.alibaba.com>
> +R:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> +R:	Liam R. Howlett <Liam.Howlett@oracle.com>
> +R:	Nico Pache <npache@redhat.com>
> +R:	Ryan Roberts <ryan.roberts@arm.com>
> +L:	linux-mm@kvack.org
> +S:	Maintained
> +W:	http://www.linux-mm.org
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	Documentation/admin-guide/mm/transhuge.rst
> +F:	include/linux/huge_mm.h
> +F:	include/linux/khugepaged.h
> +F:	include/trace/events/huge_memory.h
> +F:	mm/huge_memory.c
> +F:	mm/khugepaged.c
> +F:	tools/testing/selftests/mm/khugepaged.c
> +F:	tools/testing/selftests/mm/split_huge_page_test.c
> +F:	tools/testing/selftests/mm/transhuge-stress.c
> +
>   MEMORY MANAGEMENT - USERFAULTFD
>   M:	Andrew Morton <akpm@linux-foundation.org>
>   R:	Peter Xu <peterx@redhat.com>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 11:16 [PATCH] MAINTAINERS: add mm THP section Lorenzo Stoakes
                   ` (4 preceding siblings ...)
  2025-04-24 12:23 ` Baolin Wang
@ 2025-04-24 17:57 ` Matthew Wilcox
  2025-04-24 18:11   ` Lorenzo Stoakes
  2025-04-24 19:50 ` Zi Yan
  6 siblings, 1 reply; 12+ messages in thread
From: Matthew Wilcox @ 2025-04-24 17:57 UTC (permalink / raw)
  To: Lorenzo Stoakes
  Cc: Andrew Morton, David Hildenbrand, Zi Yan, Baolin Wang,
	Liam R . Howlett, Nico Pache, Ryan Roberts, linux-mm,
	linux-kernel

On Thu, Apr 24, 2025 at 12:16:32PM +0100, Lorenzo Stoakes wrote:
> As part of the ongoing efforts to sub-divide memory management
> maintainership and reviewership, establish a section for Transparent Huge
> Page support and add appropriate maintainers and reviewers.

I'm quite queasy about this.  I'm doing my best to make "THP" disappear
as a concept.  How would you define what THP is?  Originally, it was
PMD-sized-and-aligned allocations, and some of the way we expose it to
userspace, that's still the interpretation.  But we also have folios which
are of some hardware-defined magic sizes, as well as (for filesystems,
at least) random other non-zero orders.

Memory is just managed in variously sized quantities.  There should be
nothing magic about "THP", and I'm still annoyed at the anon-mem people
for baking various magic sizes into user-visible APIs.


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 17:57 ` Matthew Wilcox
@ 2025-04-24 18:11   ` Lorenzo Stoakes
  2025-04-24 18:44     ` David Hildenbrand
  0 siblings, 1 reply; 12+ messages in thread
From: Lorenzo Stoakes @ 2025-04-24 18:11 UTC (permalink / raw)
  To: Matthew Wilcox
  Cc: Andrew Morton, David Hildenbrand, Zi Yan, Baolin Wang,
	Liam R . Howlett, Nico Pache, Ryan Roberts, linux-mm,
	linux-kernel

On Thu, Apr 24, 2025 at 06:57:22PM +0100, Matthew Wilcox wrote:
> On Thu, Apr 24, 2025 at 12:16:32PM +0100, Lorenzo Stoakes wrote:
> > As part of the ongoing efforts to sub-divide memory management
> > maintainership and reviewership, establish a section for Transparent Huge
> > Page support and add appropriate maintainers and reviewers.
>
> I'm quite queasy about this.  I'm doing my best to make "THP" disappear
> as a concept.  How would you define what THP is?  Originally, it was
> PMD-sized-and-aligned allocations, and some of the way we expose it to
> userspace, that's still the interpretation.  But we also have folios which
> are of some hardware-defined magic sizes, as well as (for filesystems,
> at least) random other non-zero orders.
>
> Memory is just managed in variously sized quantities.  There should be
> nothing magic about "THP", and I'm still annoyed at the anon-mem people
> for baking various magic sizes into user-visible APIs.

Right, but as it stands, we already separate out handling for a whole host
of different THP things by file, which get_maintainers.pl knows nothing
about.

For:

	include/linux/huge_mm.h
	include/linux/khugepaged.h
	include/trace/events/huge_memory.h
	mm/huge_memory.c
	mm/khugepaged.c
	tools/testing/selftests/mm/khugepaged.c
	tools/testing/selftests/mm/split_huge_page_test.c
	tools/testing/selftests/mm/transhuge-stress.c

This is not a philosophical position as to where we _might go_ in future,
or how we might decide to treat varying folio sizes going forward, but
rather a purely practical step so these files get seen by people and the
de-facto maintainer is ack'ed as such.

When we get to the point where we can simply treat all as the same, we can
reflect as much in MAINTAINERS too, this is not set in stone.


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 18:11   ` Lorenzo Stoakes
@ 2025-04-24 18:44     ` David Hildenbrand
  2025-04-24 19:38       ` Zi Yan
  0 siblings, 1 reply; 12+ messages in thread
From: David Hildenbrand @ 2025-04-24 18:44 UTC (permalink / raw)
  To: Lorenzo Stoakes, Matthew Wilcox
  Cc: Andrew Morton, Zi Yan, Baolin Wang, Liam R . Howlett, Nico Pache,
	Ryan Roberts, linux-mm, linux-kernel

On 24.04.25 20:11, Lorenzo Stoakes wrote:
> On Thu, Apr 24, 2025 at 06:57:22PM +0100, Matthew Wilcox wrote:
>> On Thu, Apr 24, 2025 at 12:16:32PM +0100, Lorenzo Stoakes wrote:
>>> As part of the ongoing efforts to sub-divide memory management
>>> maintainership and reviewership, establish a section for Transparent Huge
>>> Page support and add appropriate maintainers and reviewers.
>>
>> I'm quite queasy about this.  I'm doing my best to make "THP" disappear
>> as a concept.  How would you define what THP is?  Originally, it was
>> PMD-sized-and-aligned allocations, and some of the way we expose it to
>> userspace, that's still the interpretation.  But we also have folios which
>> are of some hardware-defined magic sizes, as well as (for filesystems,
>> at least) random other non-zero orders.
>>
>> Memory is just managed in variously sized quantities.  There should be
>> nothing magic about "THP", and I'm still annoyed at the anon-mem people
>> for baking various magic sizes into user-visible APIs.
> 
> Right, but as it stands, we already separate out handling for a whole host
> of different THP things by file, which get_maintainers.pl knows nothing
> about.
> 
> For:
> 
> 	include/linux/huge_mm.h
> 	include/linux/khugepaged.h
> 	include/trace/events/huge_memory.h
> 	mm/huge_memory.c
> 	mm/khugepaged.c
> 	tools/testing/selftests/mm/khugepaged.c
> 	tools/testing/selftests/mm/split_huge_page_test.c
> 	tools/testing/selftests/mm/transhuge-stress.c
> 
> This is not a philosophical position as to where we _might go_ in future,
> or how we might decide to treat varying folio sizes going forward, but
> rather a purely practical step so these files get seen by people and the
> de-facto maintainer is ack'ed as such.
> 
> When we get to the point where we can simply treat all as the same, we can
> reflect as much in MAINTAINERS too, this is not set in stone.

Yeah, I think we all share the same long-term goal of not even having 
huge_memory.c anymore; it's simply not going to be special anymore.

My hope is that with the planned "auto" mode for anon (m)THP we'd be 
able to switch in the future as default to a "let MM manage all that, 
it's now smart enough", to slowly phase manual control it out. We still 
have to deal with the legacy Huge/PMD-mapped stats that keep annoying me.

Personally, I wouldn't mind moving it under MM core already, but for now 
this might be better to find the right reviewers. As you say, we can 
always adjust -- especially once huge_memory.c goes away because it will 
simply be memory.c, or whatever that file will be called then.

-- 
Cheers,

David / dhildenb



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 18:44     ` David Hildenbrand
@ 2025-04-24 19:38       ` Zi Yan
  0 siblings, 0 replies; 12+ messages in thread
From: Zi Yan @ 2025-04-24 19:38 UTC (permalink / raw)
  To: David Hildenbrand, Lorenzo Stoakes, Matthew Wilcox
  Cc: Andrew Morton, Zi Yan, Baolin Wang, Liam R . Howlett, Nico Pache,
	Ryan Roberts, linux-mm, linux-kernel

On Thu Apr 24, 2025 at 2:44 PM EDT, David Hildenbrand wrote:
> On 24.04.25 20:11, Lorenzo Stoakes wrote:
>> On Thu, Apr 24, 2025 at 06:57:22PM +0100, Matthew Wilcox wrote:
>>> On Thu, Apr 24, 2025 at 12:16:32PM +0100, Lorenzo Stoakes wrote:
>>>> As part of the ongoing efforts to sub-divide memory management
>>>> maintainership and reviewership, establish a section for Transparent Huge
>>>> Page support and add appropriate maintainers and reviewers.
>>>
>>> I'm quite queasy about this.  I'm doing my best to make "THP" disappear
>>> as a concept.  How would you define what THP is?  Originally, it was
>>> PMD-sized-and-aligned allocations, and some of the way we expose it to
>>> userspace, that's still the interpretation.  But we also have folios which
>>> are of some hardware-defined magic sizes, as well as (for filesystems,
>>> at least) random other non-zero orders.
>>>
>>> Memory is just managed in variously sized quantities.  There should be
>>> nothing magic about "THP", and I'm still annoyed at the anon-mem people
>>> for baking various magic sizes into user-visible APIs.
>> 
>> Right, but as it stands, we already separate out handling for a whole host
>> of different THP things by file, which get_maintainers.pl knows nothing
>> about.
>> 
>> For:
>> 
>> 	include/linux/huge_mm.h
>> 	include/linux/khugepaged.h
>> 	include/trace/events/huge_memory.h
>> 	mm/huge_memory.c
>> 	mm/khugepaged.c
>> 	tools/testing/selftests/mm/khugepaged.c
>> 	tools/testing/selftests/mm/split_huge_page_test.c
>> 	tools/testing/selftests/mm/transhuge-stress.c
>> 
>> This is not a philosophical position as to where we _might go_ in future,
>> or how we might decide to treat varying folio sizes going forward, but
>> rather a purely practical step so these files get seen by people and the
>> de-facto maintainer is ack'ed as such.
>> 
>> When we get to the point where we can simply treat all as the same, we can
>> reflect as much in MAINTAINERS too, this is not set in stone.
>
> Yeah, I think we all share the same long-term goal of not even having 
> huge_memory.c anymore; it's simply not going to be special anymore.
>
> My hope is that with the planned "auto" mode for anon (m)THP we'd be 
> able to switch in the future as default to a "let MM manage all that, 
> it's now smart enough", to slowly phase manual control it out. We still 
> have to deal with the legacy Huge/PMD-mapped stats that keep annoying me.

I agree that we should not have per-order knobs like now, but letting
kernel to figure out everything might be a stretch since it might
requires a lot of profiling to get some information about user program
behaviors. Some hints like madvise(MADV_{NO}HUGEPAGE) could save a lot
of profilings. Maybe your auto mode includes such hints.

But pagecache does not have such hints, maybe file accesses gives good
hints already. Matthew, what is your take on this? Hints or no hints?
Or anon mem is different for this aspect?

>
> Personally, I wouldn't mind moving it under MM core already, but for now 
> this might be better to find the right reviewers. As you say, we can 
> always adjust -- especially once huge_memory.c goes away because it will 
> simply be memory.c, or whatever that file will be called then.

Yeah, I guess we want to be able to distribute patches to different
sets of experts, otherwise all patches will be sent to a large group
of the same people. That might be inefficient.


-- 
Best Regards,
Yan, Zi



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] MAINTAINERS: add mm THP section
  2025-04-24 11:16 [PATCH] MAINTAINERS: add mm THP section Lorenzo Stoakes
                   ` (5 preceding siblings ...)
  2025-04-24 17:57 ` Matthew Wilcox
@ 2025-04-24 19:50 ` Zi Yan
  6 siblings, 0 replies; 12+ messages in thread
From: Zi Yan @ 2025-04-24 19:50 UTC (permalink / raw)
  To: Lorenzo Stoakes, Andrew Morton
  Cc: David Hildenbrand, Zi Yan, Baolin Wang, Liam R . Howlett,
	Nico Pache, Ryan Roberts, linux-mm, linux-kernel

On Thu Apr 24, 2025 at 7:16 AM EDT, Lorenzo Stoakes wrote:
> As part of the ongoing efforts to sub-divide memory management
> maintainership and reviewership, establish a section for Transparent Huge
> Page support and add appropriate maintainers and reviewers.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
>  MAINTAINERS | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4015227645cc..85cd47a28a0a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15563,6 +15563,29 @@ S:	Maintained
>  F:	include/linux/secretmem.h
>  F:	mm/secretmem.c
>  
> +MEMORY MANAGEMENT - THP (TRANSPARENT HUGE PAGE)
> +M:	Andrew Morton <akpm@linux-foundation.org>
> +M:	David Hildenbrand <david@redhat.com>
> +R:	Zi Yan <ziy@nvidia.com>
Acked-by: Zi Yan <ziy@nvidia.com>

> +R:	Baolin Wang <baolin.wang@linux.alibaba.com>
> +R:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> +R:	Liam R. Howlett <Liam.Howlett@oracle.com>
> +R:	Nico Pache <npache@redhat.com>
> +R:	Ryan Roberts <ryan.roberts@arm.com>
> +L:	linux-mm@kvack.org
> +S:	Maintained
> +W:	http://www.linux-mm.org
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	Documentation/admin-guide/mm/transhuge.rst
> +F:	include/linux/huge_mm.h
> +F:	include/linux/khugepaged.h
> +F:	include/trace/events/huge_memory.h
> +F:	mm/huge_memory.c
> +F:	mm/khugepaged.c
> +F:	tools/testing/selftests/mm/khugepaged.c
> +F:	tools/testing/selftests/mm/split_huge_page_test.c
> +F:	tools/testing/selftests/mm/transhuge-stress.c
> +
>  MEMORY MANAGEMENT - USERFAULTFD
>  M:	Andrew Morton <akpm@linux-foundation.org>
>  R:	Peter Xu <peterx@redhat.com>




-- 
Best Regards,
Yan, Zi



^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2025-04-24 19:50 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-24 11:16 [PATCH] MAINTAINERS: add mm THP section Lorenzo Stoakes
2025-04-24 11:20 ` David Hildenbrand
2025-04-24 11:28 ` Dev Jain
2025-04-24 11:34   ` Lorenzo Stoakes
2025-04-24 11:39 ` Lorenzo Stoakes
2025-04-24 11:55 ` Ryan Roberts
2025-04-24 12:23 ` Baolin Wang
2025-04-24 17:57 ` Matthew Wilcox
2025-04-24 18:11   ` Lorenzo Stoakes
2025-04-24 18:44     ` David Hildenbrand
2025-04-24 19:38       ` Zi Yan
2025-04-24 19:50 ` Zi Yan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox