From: Catalin Marinas <catalin.marinas@arm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Denis Kirjanov <kda@linux-powerpc.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: kmemleak: Unable to handle kernel paging request
Date: Sat, 14 Jun 2014 13:05:18 +0100 [thread overview]
Message-ID: <D9560F26-D206-4423-ACA4-31342A73B5F9@arm.com> (raw)
In-Reply-To: <1402695853.20360.17.camel@pasglop>
On 13 Jun 2014, at 22:44, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Fri, 2014-06-13 at 09:56 +0100, Catalin Marinas wrote:
>
>> OK, so that's the DART table allocated via alloc_dart_table(). Is
>> dart_tablebase removed from the kernel linear mapping after allocation?
>
> Yes.
>
>> If that's the case, we need to tell kmemleak to ignore this block (see
>> patch below, untested). But I still can't explain how commit
>> d4c54919ed863020 causes this issue.
>>
>> (also cc'ing the powerpc list and maintainers)
>
> We remove the DART from the linear mapping because it has to be mapped
> non-cachable and having it in the linear mapping would cause cache
> paradoxes. We also can't just change the caching attributes in the
> linear mapping because we use 16M pages for it and 970 CPUs don't
> support cache-inhibited 16M pages :-( And due to the MMU segmentation
> model, we also can't mix & match page sizes in that area.
>
> So we just unmap it, and ioremap it elsewhere.
OK, thanks for the explanation. So the kmemleak annotation makes sense.
Would you please take the I patch earlier (I guess with Denis’ tested-
by). I can send it separately if more convenient.
Thanks,
Catalin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-06-14 12:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 12:13 Denis Kirjanov
2014-06-11 17:38 ` Catalin Marinas
2014-06-11 20:04 ` Denis Kirjanov
2014-06-11 22:00 ` Catalin Marinas
2014-06-12 7:39 ` Denis Kirjanov
2014-06-12 12:00 ` Denis Kirjanov
2014-06-12 13:29 ` Naoya Horiguchi
2014-06-12 14:39 ` Catalin Marinas
2014-06-13 7:12 ` Denis Kirjanov
2014-06-13 8:56 ` Catalin Marinas
2014-06-13 10:26 ` Denis Kirjanov
2014-06-16 2:40 ` Michael Ellerman
2014-06-13 21:44 ` Benjamin Herrenschmidt
2014-06-14 12:05 ` Catalin Marinas [this message]
[not found] ` <5399ab3b.4825e00a.60fd.5014SMTPIN_ADDED_BROKEN@mx.google.com>
2014-06-13 6:39 ` Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9560F26-D206-4423-ACA4-31342A73B5F9@arm.com \
--to=catalin.marinas@arm.com \
--cc=benh@kernel.crashing.org \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox