From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18744C3600B for ; Thu, 27 Mar 2025 17:22:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88DB428010D; Thu, 27 Mar 2025 13:22:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83D892800FF; Thu, 27 Mar 2025 13:22:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6906228010D; Thu, 27 Mar 2025 13:22:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 480432800FF for ; Thu, 27 Mar 2025 13:22:45 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D8013ABFB6 for ; Thu, 27 Mar 2025 17:22:45 +0000 (UTC) X-FDA: 83268000690.25.273BD91 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2078.outbound.protection.outlook.com [40.107.236.78]) by imf11.hostedemail.com (Postfix) with ESMTP id 096A24000E for ; Thu, 27 Mar 2025 17:22:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=rWxxyDDf; spf=pass (imf11.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.78 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743096163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKu6+hiNRdcNe+gZ4LY6PR0sPY4AQrPMHrp+LgXEiUA=; b=VSJdWnSq+NoInptp738eJ4GGn+3uakA48qSrgp6grq7NBP72qmGfxn/vic3ObK1tyKAwqJ CKH+8t3EL+s1E0OR9P2jJsDflbozWINZNIAcfIl+RxswaILDsYzjZy4yuxj56SFYYMtPN/ WP9V4sNjckG6qnTMG5ct4keyB0MwXhY= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=rWxxyDDf; spf=pass (imf11.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.78 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1743096163; a=rsa-sha256; cv=pass; b=OXfVYISz8JbgkOUR4OvPbQXExuiLUPuYRIlv3VCFK5jLb4y13koFtuJVPTJjk6VDIcJfcM icwvmgen1MKs8NCvfYSLOppSvwEdPh/QW7S82wvWRjyAtZ9yNZnIXhioDXBfUrmkCT2SuS hCbOJaCAYDc8+3sxcz7NftXbImqqu1A= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PERIzc1dWoqHf97lGROeqfwbe1HUhbe9bSQZa6vIsEM5TerNjEALJ8YO3Hwp+r0R46Jrlb5sm/p0nVq8Bp3NdNmfaWgIE0B0ayfX1tlm61P3QY8nr8FjoC3vtJedhdqcitUeI3JPMr1nN+LGCBCk4ZF/UqxmNxga9P8cwtFEhTCXsXkV8B1ojZhtK1Z36L6ibq/NVykVveSG3GFxcVieT8ZLZf3+59Ja4nXUoYxHZvivoSDW5vljTQ9Y0RXdyB4ANW16UNnQX/82kAsledtDKYUl8MVAOuLlXLxhRiQ/cqLvw4nFG5fSL48/qDwoR1wU6ZXPCwOiJXeMAf7n2OGBrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NKu6+hiNRdcNe+gZ4LY6PR0sPY4AQrPMHrp+LgXEiUA=; b=ujOl+jLd9cNWZiKcQD/FRRNwX/pW62fSjnYvJ1Irrc+I/ZX9ZaZAHCH+bsCrBQVrlyXUGoesq/jAzB8Vd5iXLymIdTDCmxtzbCYVy76o8QOtOJEP3tAaD+YzgtHjsgLCQmvFLO+h0eYU7Zu3e4v4s9s8P2aTSaL0isBouNPDanBGXfmX9r5Yl6IYvLwjLrqlZwnQgfKo5IroIO+KDx/radFs5cQElS9+FMV6w046RJOMaIURBaemMherRkhxnP3ofSaUDuHmMnlJiLkgLsOYTImzElKQavmR/pNIpABeFV0jEXziifHh/DyaPvJh1EMVryXng92NqRgkPHmwM0npeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NKu6+hiNRdcNe+gZ4LY6PR0sPY4AQrPMHrp+LgXEiUA=; b=rWxxyDDfD1mj3oof1F3Q6Op0c5sysm+XbelQMZjqbEvCE7tbdQB7D1qSIeXSoKNWdPrE471vl6hCS0lB9WXT+ejf6cRJmZAbfYUfPTlGJa85pN36onpjO7+niKY3OinMTOOHj6j7XnhRakq3VdEnxsvxZcjWI7vzyATDPUlOKB0UBtljDfcG0sftHyhFIEyaYNG2IIU35mqciVEDBHCG7kkczEQ32mj6+kynBqUz9t7tQozkCd9+pJ+SSCKfznIu3r+HUEMZeSEjuGJPNcz+Z2wghpizZtv9xKDQPLSuOWc8boaMzuaJb6esE0OG7aAR2Vr6rABYbo4JsjS192bwPw== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SA0PR12MB7073.namprd12.prod.outlook.com (2603:10b6:806:2d5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Thu, 27 Mar 2025 17:22:40 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%4]) with mapi id 15.20.8534.043; Thu, 27 Mar 2025 17:22:40 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 27 Mar 2025 13:22:38 -0400 Message-Id: To: "Matthew Wilcox" From: "Zi Yan" Subject: Re: [PATCH 06/11] migrate: Remove call to ->writepage Cc: , "David Hildenbrand" , "Joanne Koong" , , X-Mailer: aerc 0.20.0 References: <20250307135414.2987755-1-willy@infradead.org> <20250307135414.2987755-7-willy@infradead.org> In-Reply-To: X-ClientProxiedBy: BL6PEPF0001640C.NAMP222.PROD.OUTLOOK.COM (2603:10b6:22e:400:0:1004:0:13) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SA0PR12MB7073:EE_ X-MS-Office365-Filtering-Correlation-Id: ebde6af8-e2a7-4913-37e7-08dd6d53f9f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c1FXUU1taFQvWW9KWURHUVVNaW40VlJTUjVnWHFWSGlsSHdDK3RuVzhsNzE3?= =?utf-8?B?VFpoZTVKams5VHpjZ21wU3BZWTJGUExSdDlSc280Qzc4QlNudHJlQjEyeVE4?= =?utf-8?B?VCtJdzM3NEd4VndUSjBIMEhZRTlrMExRdVltUTBCcnFMamRQSEozaHVaYUhU?= =?utf-8?B?YUFIU3lCSEpCeEJ4TmlST2tzU3dlUzZEdGlqL2NiSC8reUhZRjkyUHRPSWti?= =?utf-8?B?M0NMK2NvM2htNi85eVhBNVdFM3h4QlZ6KzdpK1E2MW44clBaZWh3UTI4WEt6?= =?utf-8?B?c3UwU0VUM3I0cG5FeHcrSnMwTDZFN2ZuclNqS211RXhMTEgvMmpLR3AvdWtr?= =?utf-8?B?c3dBMDNwMzhnVVpjUWdwL2xMSmV0clJxMVU0SDgxSS9DY2pJaFJkdmlUQUdX?= =?utf-8?B?TDQ2S3ZKNUNlNU04SkovaFRCc1dkZVhMU1ZTQjF2SGp0YUcxRysvR3dDUTVv?= =?utf-8?B?VnFIQm5oV1hhbno4RGRlelFFYnBWSlFpdm1zdDN1K0tpSGZIT3lINmtHQ1pK?= =?utf-8?B?K3duZk9qcXFOc3BhTkxkS0lVM2NFdFBuZ0t6N0pEVHlZUXo4RU4ybmZ4ZHU4?= =?utf-8?B?Rkp6Z2hRc2paN28xTzJNRGRnMXMxcUh1SE5hTEFaUkNTMGpqQnBLbnoyVE1z?= =?utf-8?B?cEVXb21Hb1psNWJEaEVkTEVVcXFtM2tITVdvNlB6Z0FsY2Z2dXN0ODcvbkg1?= =?utf-8?B?eHA3U1R2V3o3Ykp2cWNoRU0yL3hQZWZva3FPYjFWUFdlUTk3enhzQUJBNm9V?= =?utf-8?B?dVFpSC9rM3Q1RnBFYmcvZnJHbWhQR00zdm45V1BFazFDT1krcVVpYlh6Yy9K?= =?utf-8?B?dWVsLytXVXllRzM4UHFlNEhGYjBVUUpRTzRjYzFDTlJrTlN1V1YwN1FxbEIv?= =?utf-8?B?Q01melhFdTk2NkJPZk1CQ3Q3dzNXcGhXL0VoNGI2bm44OTI1WUt6MzBtQ3Jt?= =?utf-8?B?VDJ1UGdPMlVMa1lIY2g2WHdNVjUrSEQvMXI1NVBVaERTQTlhOFlCNHRxTDAw?= =?utf-8?B?dmM0cjB0Ym1qK0xGaktvU1FyNENoSm43Z0t4bGZsT0JRbW13bldDYVZMOG1y?= =?utf-8?B?THRMK0Era2E2NUdiZVBVLzRSS29DQUlONXRGcG5nUFdDSUN5dkJWM2o1L1RI?= =?utf-8?B?UDBQTVRYaTZiMlExWFRmY0xFUDB1QlJYeUtWTktZWjZiVyt6akJzbjhDZ2VL?= =?utf-8?B?bVNvTFRIdGVVam13R1hUWWFHb0RxaHBtRk5KN2k1ZjVadHRuNjlaQW5tYzB5?= =?utf-8?B?WVQwVnprWFRVSTFmTHhNY2I0OGh6VHRiWi9VZ1dIVlVMOWRuTnZDTXN6SXBG?= =?utf-8?B?ejJJbWJQQmhHUmEwNkxleDlVRXlZa2s2TEhvSmkrQXpKb29pZzVZTHgyRGsy?= =?utf-8?B?SkE0RXVNbWhJVmhNMVNmaXBYT2ZTYWkvVTF0a080QjlUN3Vpb1lKS3ptZ2Zs?= =?utf-8?B?Zk5zWjdDTnBDUjB1eFRBbDZVUm1hdC9waEVaZzJ6Sm1wdEZ3dkNjazVwZUVD?= =?utf-8?B?bHVIUWRtbWZWWHcyc2ZPaVdEVUtSeG81clU5ZHBLSEJJaUF4YThmT0ZCK3NW?= =?utf-8?B?UFR0bWNBbWVaMjVtOE9La0VLM3BJd0o5Z0Fmc1pPczV2S2R2TkNoVlZWb0V1?= =?utf-8?B?aCtmaEhBOW9WZ2dwYjhSN1VNSzNYZWZDRXI5UHkvMVRvTC9XcTF5Q01kVHpq?= =?utf-8?B?WmJ4RzZMV3dPSzFCNmpmanFZb0w5Y09lZmlWaUFZMlR2cFNnNmhmTGNJM3Ux?= =?utf-8?B?TlpWSkw4d3VpL25wZmRIY1JPUU1ydkQ2L1lFUGRJaDNxNjRUSFFLRUtoY3JI?= =?utf-8?B?R2ZhVjdiVEJIOVl1d2ozYTNLQ205VWFmbHpGT042TTlZbWliQ3pQOEQ1NFhW?= =?utf-8?B?RUlTWkZ1eHZ0U0d6MjZ2Z2N5aC9XbkFWVCs3SWk5b1lxM2c9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjI5YzA4VjFqRjI2cFBrMUhlcXVBWk0xQkdFSVcyQUVPb3o4WGJxNDgrZGV5?= =?utf-8?B?Y0NkL0ZtSGpnY1BZQW02U2F2QXdKckV4b2dLb3lsK3UvVE9oai91VkJQOUF2?= =?utf-8?B?clFaM2ZWbW1oVEZWRm05R2RGbkRyYzBNdTVDZWN6cHhwd2dGN25xRVgrcndk?= =?utf-8?B?Y01nQlpFeWVsVjVvdHU2Y2lqaU5NTy9mazJzVVdScjFwM2hRNTNLaGRUelI4?= =?utf-8?B?TGNxSnJ2TTVkVE5zdVlTRy83SXZXaVFoaHczaC84T0ZkOHlDNmRBU2RHVXZK?= =?utf-8?B?VDFtVGdRS2lsTFJjVzlsemsrMFdibE1ORHRMcXg1cDI1YUVycHBnN3h0S3lh?= =?utf-8?B?YWd3U3BPdEF6b1o3S2srNDZHbVcwK0c1enpCOEwva1g1UE1tR09pQjVNT1JH?= =?utf-8?B?YnhaOTRuWUxzeER4alRzcUQxaGpYMFY5NjZMV2RGMU9vY2FCV0pQQUhSd2Qr?= =?utf-8?B?cWRKSjBnUUNEZkVvK1pWSktZbkYrOHBGakpUeDIwdFhDRlNlNmNHYXBLQWJH?= =?utf-8?B?NUYzeEFMSmJJbnREdldCaHFUMlBJanJqQXg2QjR0MkNYTGF6VnNWMnY1WDJY?= =?utf-8?B?eDBqelI1Tk50RjNsQWNxYUVTZDF3WEtoNUVvU3RsWCtwMDlWMFhMM0t5R0lw?= =?utf-8?B?djdoejRHbmJqSzBNcmE4R2xqTEk4cm8wbGI3ci9paDlCVkdWK3AvY21WRXdr?= =?utf-8?B?VzE0K2tEaStPTmFRTk5pUzVNY3kveDBRb2NJWjkwRTFDK0k0Z2FOV1FNSG9T?= =?utf-8?B?WEkvQW5NZGt6Z1pOZXhPMmZTMGhkcUF2a0dUdEFuMWs1akNVdW1zdURXQ3ZL?= =?utf-8?B?c0d2WlRRZTh4UXlzMjkrTjI4V05GcTk2YWUwTkwzMzVGTXNyNDNPeW1iMEpE?= =?utf-8?B?MlJ6V05YU2NKaDlvcG5uNTRsMDNGVUt3cEVlQU9VNEFiOXljM1E1eFI2eUs4?= =?utf-8?B?ckhGQ2dDUGJCRXd3NHJoZFdKbld0WG4xSTRGV3pHa0M5N25RNTJCUjdlVUw5?= =?utf-8?B?QUNGNnIwTmV1eGJUY1pzNnp1eFY3YjhTYVRBUlFiUUwzbFF1SGVRWXpvRzI3?= =?utf-8?B?TEJDd2tQOEp3c3hiZkhsd0FUZzBtVkQrZEtWRk5SbkFpS09YejNCMEEvMVZv?= =?utf-8?B?WGd6WDJXQjZOdzJaMDZpdGxrTmI4anZqWDI4U3U2L3NWMFVLNkx3ZDdCRUlW?= =?utf-8?B?TENnYnNTZlBXazJnRzlSSFVoNHE1MVlVWHF5MFcxZ3JLb0dYNzF4eVpRUkpW?= =?utf-8?B?dVY2aFJsMlYzTURnYzJOaVZJY2VhSEJGaFJwWVBKanhiWUh4K0pscXdMVkR6?= =?utf-8?B?RmlncmhlTncydDBwa0xnVlZrdVFlUEtCaVR0dTVuSWp0ZjcvVWI1eHo1ZC81?= =?utf-8?B?dzZPdHV0T2ZTREZsUW9yV0haZzlXTEwxZkd2MVZJYjRzRGZ3Zytzd2FmTG80?= =?utf-8?B?Z0sySFczUVFTdjBKQUpCUnFFQ0IxNWFvd3MrWUd3eFN3eGFPNWZTZlhaMDhL?= =?utf-8?B?UmtoQVJpSUwyNWJXRnYyWk1pbDJpS2RYSERGYk85VDUwUE52NzFtUzZWQXll?= =?utf-8?B?VjVVMkFYblk2S0thOXdFblMwSS9RWUY2S3ZGa3Vna2dPYndyN1hNM2ZXV3Rt?= =?utf-8?B?bmVjSUovNThIK0x3NTBlWHlwVmhkT0J5T0ZUR0xuMHRsdkRvVkZKV3lIeE1y?= =?utf-8?B?UE13MGNwVjU2dHo0MHpCQ1N0NWpPMzRUU1ltQjJKSGo2VnlRZzZzRXcwRzlz?= =?utf-8?B?ZFNzZnN5VDd0OXZ0RXVIQU5uZFlnRFA3em8zV0phNWJjYzdybXhrTzFOblhI?= =?utf-8?B?d0c5RzBEVnZwZTEyWDY4aXV0dmNlTFNRb01PQUtSK2dKZTFJQVpuRHpMS0lR?= =?utf-8?B?MHFURUxqTVkyeVdKL1p1MktRbGhsMEZUeG9VcjB6SEhOT0w5bUphRnRBZEFV?= =?utf-8?B?THR2aHRyN04wTE5XQnhNMWlKMGMrQ3BMa2d3Y2wwU3VXdUd2M0RTb3RORzVG?= =?utf-8?B?dDFoUDkrMUltRWlmZDlnbDdMYm9BTG5BOEJQSi90T2g4aUY5cXV0elhnYkZw?= =?utf-8?B?ZWt1aFBJaHhCS2pzeHpvcXpBdWJLNnExRjVMN0piMTlPL0lVVUtqR2U1Ykdp?= =?utf-8?Q?AMwStZV73G0whk3DZ9P6mkZwX?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebde6af8-e2a7-4913-37e7-08dd6d53f9f6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2025 17:22:40.1126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N+cTptnEarxi+sh/lrichjb6WCa0yhofq+vUo7j/DfGJKW2RB3IGL7ftzdbgIQ+t X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7073 X-Rspamd-Queue-Id: 096A24000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8yc9s1pe5n4prupdpy1i9ndqnyzw45zj X-HE-Tag: 1743096162-986406 X-HE-Meta: U2FsdGVkX19OCU5VYS2h+4yzMqoTqxNDxPg50ekD2UM4MQYKW0IK/lQs6XyVZvEMHGoINlzCBT0mOIzdFEhnyHNT2xcZigPZGhkGf7Kjk8DCziJKFcGYw4Qh08AE5aKfjXUZ2q0IrwuKpgNoQOq/f+tZX4Rqw0wZiIS5kpUwet9p+HOfZx706f95NiDFKnnY9j1/pTgqDwi+J8FHVd5J/kRsNAuDcBsVRC9TjirrDz4+G9p0E5N6DGSSSX+bdv7wDUt3bU1tz679TJRYrD1yxL6VraDQf7SeJ3xQHpXDTMUkd+tA3fDa71Djlo8Y7FZ7rIx5aSwAzHiTUM/nP3H49rYLQ744AV5nOcNMhPfjOfUULxyOK3E+ykTgiBPjHNvbdKrJ4rCXkd7P05zTsWwaFpzI7mzbfyBO/kDtKKCT+oE7I9IiIJk0TtMB35Yiv8h83z7IPtQhBsz8xVTExzCY79Wj2y15GNhlGiDOfEg/G3iBCZZ7HSdIArmGIT1Nn2+sAIXr9bxRC4MCJYaY6m2WYxVHn/itbcwhLtG1/kbF7QwGGh4e2rcxImVNHLdnfdo4NzCOubgs84X4uMX5Hi2lxv1HkKwThvFX8DjbLC97Y7LwbtYtpYqgHtN/X1mC1hiZV4v6yOBiai0ZZEspnb5SlhUT+hdxpT20FPXJpATjXoLtwTabPCrpldiFkR0IzoSrLwGksADV2qu0mKrX3TTrP5db6zFYCn0AeR5PvBD8vaNnLggkFV7MESloDB02Z8XsD7mt6ad13L+psJWHlEr92GgT+6cPQODDC071a5furPucABD/HLXz1v0QjD+/RWHlytRwm8gp/C3B7tD2QiZPyhGdUwatRW2gBeMmNKuHWh2Z5xBv76yoioKWvDDwB+QveRDzCJsfuayAgaFDJydqQRuoPmUVEmXxsS3hUw4rPtCHC7yfDoqJt1Tp82HuppYaak0QvOLso+yVuyBPRnN 7ZT4OkbC 1kRltPNSYNLOED4ex6C2/ZW2IE5Bvv4qJlpgWxILWATvExuSpDwBPOpjgwiNsxmuVdePm+++ddQg2W1E/JHETobtDK3w49hJ0FMFhfK8YlmQjZaMXquKeAk5WpkzkBlVlulEW80hRVIdrJAxAeVidqx85gHp8Ll+S16223AsiUv5Y/VUOsBL1CTnXC3d68FiJ94HLkolBtXTV9hPyqDpzhXlsQClczoW4OuMIeAyTzfWR6FNeUtt8AeYxa4qhdZu0UIAdF+geg8FP5DPIJ8UxJdw4OlskLHhoYMLs89HVg1AtyXBO5LxU+fgDeOaf+HxUfRl18lxR+Dxf43irAVQ89VE09Of3qWfW8CIkchUjPqsjsi4rKHymjEZ1lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu Mar 27, 2025 at 12:52 PM EDT, Matthew Wilcox wrote: > On Thu, Mar 27, 2025 at 11:04:57AM -0400, Zi Yan wrote: >> On Fri Mar 7, 2025 at 8:54 AM EST, Matthew Wilcox (Oracle) wrote: >> > The writepage callback is going away; filesystems must implement >> > migrate_folio or else dirty folios will not be migratable. >>=20 >> What is the impact of this? Are there any filesystem that has >> a_ops->writepage() without migrate_folio()? I wonder if it could make >> the un-migratable problem worse[1] when such FS exists. > > As Christoph and I have been going through filesystems removing their > ->writepage operations, we've been careful to add ->migrate_folio > callbacks at the same time. But we haven't fixed any out-of-tree > filesystems, and we can't fix the filesystems which will be written in > the future. > > So maybe what we should do is WARN_ON_ONCE() for filesystems which > have a ->writepages, but do not have a ->migrate_folio()? Sounds good to me. Oh, ->writepage is removed and there is still ->writepages. Presumably, it is possible to use ->writepages in place of ->writepage in the removed writeout(), but that is meaningless since ->migrate_folio should be used. > >> > static int fallback_migrate_folio(struct address_space *mapping, >> > struct folio *dst, struct folio *src, enum migrate_mode mode) >> > { >> > - if (folio_test_dirty(src)) { >> > - /* Only writeback folios in full synchronous migration */ >> > - switch (mode) { >> > - case MIGRATE_SYNC: >> > - break; >> > - default: >> > - return -EBUSY; >> > - } >> > - return writeout(mapping, src); >> > - } >>=20 >> Now fallback_migrate_folio() no longer writes out page for FS, so it is >> the responsibilty of migrate_folio()? > > ->migrate_folio() doesn't need to write out the page. It can migrate > dirty folios (just not folios currently under writeback, obviously) Got it. And I just noticed that Joanne's change is in migrate_folio_unmap() for folios under writeback and irrelevant to this change. --=20 Best Regards, Yan, Zi