From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2457FC35FFC for ; Sat, 22 Mar 2025 15:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEAB2280002; Sat, 22 Mar 2025 11:06:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9925280001; Sat, 22 Mar 2025 11:06:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B60E8280002; Sat, 22 Mar 2025 11:06:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 97C47280001 for ; Sat, 22 Mar 2025 11:06:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5E1931A156A for ; Sat, 22 Mar 2025 15:06:12 +0000 (UTC) X-FDA: 83249512584.16.D2095C1 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) by imf30.hostedemail.com (Postfix) with ESMTP id 8AC7B80006 for ; Sat, 22 Mar 2025 15:06:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=11JZPLUD; spf=pass (imf30.hostedemail.com: domain of 34NHeZwgKCEUqhjrthuinvvnsl.jvtspu14-ttr2hjr.vyn@flex--jackmanb.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=34NHeZwgKCEUqhjrthuinvvnsl.jvtspu14-ttr2hjr.vyn@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742655970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WmdhaeiU8DO1XvtGX03FzurHPZXlou0bXSnHIt4W5tk=; b=ex0zE3XKEBXz98/2xp4R+WJE3HjMa1sYX1GJtMWmtc3E75iCScP+K0EUJ+ZSr2qnNYxMhD mPk0KqQ5RoXq2CvTIjwUrN35VrRievr88xNreiWgR17lOmXVqfnaLmTFtls+RzLskf4Xgp zNXgqlE+cjgk6oQiHwbk+LXK9Lzp00E= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=11JZPLUD; spf=pass (imf30.hostedemail.com: domain of 34NHeZwgKCEUqhjrthuinvvnsl.jvtspu14-ttr2hjr.vyn@flex--jackmanb.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=34NHeZwgKCEUqhjrthuinvvnsl.jvtspu14-ttr2hjr.vyn@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742655970; a=rsa-sha256; cv=none; b=j9rtBaPeqPMPT5AuOq2OaOT+1EcD6OLQw7PLrojofbbanEh6rN9Ef1DprfrK+817SeLU8h F2iy3VF84TQXYHMTGXyxc/sozgEw26vknltopFUwrDJgYtq7Qf5okLA3/KViitOUXVWAY2 2XTtKe9Y6i2J+P8z7gVxPBUm6AYhqp0= Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-391492acb59so1799335f8f.3 for ; Sat, 22 Mar 2025 08:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742655969; x=1743260769; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=WmdhaeiU8DO1XvtGX03FzurHPZXlou0bXSnHIt4W5tk=; b=11JZPLUDzMK/pcXx+8xaAMMR2lVnTDLfawLoFsd2ScagOQMpDDFvZS0H0qTOBavjBC XkcoK3F9dDmg5BiK06igGeFVejwzVKk53Y8m/hEyILYBqpYK4hOkTcZjm2sR/k3qyaOr T+6na6qQIKFWflymU5F9JILOPBtIOrvSZtGngA6a412OHm4ZYh7NyHPwFpUKrJmUyWN7 v/xLx5rc78XVNHzhAJfsTWfKjVMfiAHen/8A6w0uYKwD+c4IZiLfg4ZKioDCO/BgZm/s qeTm0ViXEYCZoOIQpuTyCXb2gXOf7B8aRrWk88meYocZm4Iuhjfk3heiEtXYk8fba9q7 Liew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742655969; x=1743260769; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WmdhaeiU8DO1XvtGX03FzurHPZXlou0bXSnHIt4W5tk=; b=h1mU0N32NR/a371LIdPSwaOMqT/tWlZlFhxJuDmFjqcrbknQcZ+XK1ATjwjpOXt8/+ Li6gGvi38Z7sdJuH4wopiJI+DHLyDRAPStirxaodnELQvpcuvUuNVt3QWu9UnYXBy3uP +PCFzI+4xW33ItPQ9d42HYSkbgBsavF8yxY57VHekm5v/fpxbvlugNQ+xwFn7S6bqkb7 6SoYrUHnfybYWS3adgJEWdpPIy97/uqkZZ0Sx81wOhsgjy7xgL24tGOKSrHv7uCeYNKe NY/NMKLPNpipI2qjZKyrlXZkwJqui4mq+9u235Gcv5DJLzD049uLM8XQqMZMUHRjsERC /L4Q== X-Forwarded-Encrypted: i=1; AJvYcCUp3yXsq9WBhrxtrXDLtr9M4X+Q4woxRIvF1OMd+vt1165a8brcdyN77SDnV3eV3nmX3jQHmuf9vA==@kvack.org X-Gm-Message-State: AOJu0Yz4occbSpyLmUUWDXuWmveNG2lqk3KmNzEXX2U/SUt2SzciGAy/ W/emKzHSkYDi7uz8tYzLdEsviCvXhmwbG6kdtBOgNI25E3ZrjcBzX6+7sMCa0f1jfFThaibgtPv cSyovolX1mQ== X-Google-Smtp-Source: AGHT+IGYGAFhtCNj0YU2wWFdCY843FZd72YTV1czqL1fRfxBOIHzg+7aZyjjifKcFVoLbmpP+n7L81gyeqEt9g== X-Received: from wmgg15.prod.google.com ([2002:a05:600d:f:b0:43b:c450:ea70]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:1fa4:b0:391:952:c758 with SMTP id ffacd0b85a97d-3997f8f78a9mr5879907f8f.6.1742655968953; Sat, 22 Mar 2025 08:06:08 -0700 (PDT) Date: Sat, 22 Mar 2025 16:05:52 +0100 In-Reply-To: <20250313210647.1314586-4-hannes@cmpxchg.org> Mime-Version: 1.0 References: <20250313210647.1314586-1-hannes@cmpxchg.org> <20250313210647.1314586-4-hannes@cmpxchg.org> X-Mailer: aerc 0.18.2 Message-ID: Subject: Re: [PATCH 3/5] mm: page_alloc: defrag_mode From: Brendan Jackman To: Johannes Weiner , Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Zi Yan , , Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8AC7B80006 X-Stat-Signature: 8qgozo51sjis77r89zj7ckww8oeo8s7c X-HE-Tag: 1742655970-596356 X-HE-Meta: U2FsdGVkX1+gu17RXZqb2UqbVjh97kGVLdfr6/IXOzcvUbgIBtphiMg0zJs1FuU35rqEE1dXmTey9+w3KfE97bNffvNGHZZOA7Qi/P1QH9bvkTwu2tRyd9IF/9rxvoh2QDOnOD/hNACb74qt/gEH4s26c7V+PchhBvdSF6JgPsDo/fxbT8F/x7Cf1Wxoqv+ojpKzO1hvDbmevZAZrOnWeSJvvErsu2lZpjDrjDhX0EmX57niUMuiuZW1G/5KSkrkTWD/JVrj8N0b3D0MlsoaV1MBoBFYi3RBMICP1pokSBsg8PAicLbSSojPG8JNGvDb7wrSyjlkeuvGS3diLO6oXH47NdGsIpte38UOjqg41dqk7yp6+Igi+sSyHZAEpZYvVLOzJcb3KxtVwMl0QEe9JiEIFVEOtvTdD4+YhPUIqJfhTghTxZ16/uSit7etSh8rxa+TRyyawb1X35UlenaRsZIMFARNb5fNsGzuhIYchaqpAQMpAA+dM1E3Z8T576RL+I67Jf9AW9SnD41YCjN7Qpi7E93fOXy2c4Csq5lC1gpxTWayV+lYc+OwumGpJ8uwnfCqJ2D+qHNcjlsWUGiyHQ8tyK8v3yLbaUA4UtwVnZVoTG/bNwY4AYYVE/n33qwrgrFs69NgirbtIvIUO7KGZ8aLlWAqgn+0JIDb7vgnOBCAFjRvoXptKCnaoktVgr02u8+KBglzWnqlsLZ8YKZCsRkOEaE8agfbvQPZ4ZPjMnZdWieL0RpkcOnyRmF2UAtC4smBk02BgCAdsgqMDFjIxnrA9w69oEAmQlQx5OAVaePWHfWucaPtczOZG8d+6ARCutTHU7fl9yDvBCCsYf2sS6SaTDFQvV1bwU4+cONnjyBq7oQ8X3bQSgo/HwQoTMCfadozwKHotjKlv9LwXC3OWybJpcAIKBg+nitQSl8gbZ5+7jAAbRTkJOjEcYwK58vP0frtI+uRXWqjr9eYE08 sgFIlekQ f8Ko6oY7XygEIC8+sLJgT+jdRQmnCEiv/x38iOSrmvqp7T7EzWcvXSxy/t/VtZGGFVK8yBruWZ2evAMRt4hK/SFyWEv7snRxocsO8PToDjXcqJioENs7sMxzmWKj2QN4np2WN+syXBRj2uYQ4haNV0I6fTATO0TVTyvfjJMYeDDslk7SF3Po4Y6zZFvPCqZzU5LTLFfKgAe4tKnY858+ATrkmOUsjcsJgi11xO12qOm48pY7iFAjicnwQufbqaXQ4jM2NL5r4ivKNiwO/ks6+SIA7L27kZNT2MbcGjGEe5dARhG3sqDwySGWEEAR342vAwpg4E9sM1I9MGLhg/vSfCHXJ9B6PzFF9JvCsofBEWkQtLA3A31Wuf5dtMFONmkcnUXoIF4fI+BT8Iyp5GmWr8FtStG+bwXGvwde1nXFbuCOy6Bw7Sq4Y8w8M8ApPF9M8L8e9AenaNQaZasJHMPuO8P2/6JU7H9Ds2IynKILN0ddER/tVIlk/G9KBM3IuhPd/b+4+sdjuErqjPgutrqKnfwIVHsbwUtwjeglDnsHnQPK1/PL8dm2FsiLlX7Ik60DnXb/eZQMH8yYvs+CjlVaZIDJNIlJEkltaA192j4iBi6Yuzd5goZ17MfrCgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu Mar 13, 2025 at 10:05 PM CET, Johannes Weiner wrote: > + /* Reclaim/compaction failed to prevent the fallback */ > + if (defrag_mode) { > + alloc_flags &= ALLOC_NOFRAGMENT; > + goto retry; > + } I can't see where ALLOC_NOFRAGMENT gets cleared, is it supposed to be here (i.e. should this be ~ALLOC_NOFRAGMENT)?