From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0BCAC432C0 for ; Thu, 28 Nov 2019 17:23:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 81628216F4 for ; Thu, 28 Nov 2019 17:23:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="lwgkM95E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81628216F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3158B6B0551; Thu, 28 Nov 2019 12:23:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C53E6B0552; Thu, 28 Nov 2019 12:23:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B5426B0553; Thu, 28 Nov 2019 12:23:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 0474F6B0551 for ; Thu, 28 Nov 2019 12:23:01 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id B8EAC52AB for ; Thu, 28 Nov 2019 17:23:00 +0000 (UTC) X-FDA: 76206356520.17.root75_7190867dbb117 X-HE-Tag: root75_7190867dbb117 X-Filterd-Recvd-Size: 3666 Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Nov 2019 17:23:00 +0000 (UTC) Received: by mail-qv1-f66.google.com with SMTP id o18so3347270qvf.1 for ; Thu, 28 Nov 2019 09:23:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=dxY7m/07nwpEoPmFlWFEy/QedJrHJ2tQnhpGMIFFBPA=; b=lwgkM95EcPlajjkzOiW1CVT8SyikrffucLON3EJwUFlrJsyRMtR9+D5lB1ftY/W1Cz uV29sjkzC68x3BL0tvgjhO8SG6alfLg1F0kChIF7XXTKTBb2MLiyLGQjk1Pt33GZ5hts aa2JuCmLWsA6l3yEJlLCQbVj2vSO/BsXMeBZUxv81QYjPW1pDFPA6nsZNMVNR45ku2iW XXPKD82T0GJhc4pTQOhd7nVohud1azDF2SMVkUUii+nlqpp3NnWUPD1uAU/Q1F3QaE/0 vMQz1y3Aa2CahQl/BlfOjtenF+BvMEzQF8XBV1BHpoomeWVua4NPHAIckFG5I1DsoBm0 wwDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=dxY7m/07nwpEoPmFlWFEy/QedJrHJ2tQnhpGMIFFBPA=; b=J5fbWHV7NOC2mBgQubw1WecUj0tV4VV4UEfOUJTUQ85d1e0y0RgEE3JEcNwf/mY38f UhWAfWonuIjDgrkdr8O8F3sCN7CG6YxW1y5xnpkz2mZoeVWCYQeDsv6mPt0Cmu2dZrfP W/CYQI+EeT2n74ygofkMUGxoXP2baC4o5fQXMpIchXjrIngEcr4uBtFKHN00RX43q3uQ 1XhHcEVWdcCwJFYTpg5xFqiTyP1BGjmkcyNPodQNLGE+wdTff//7NR7+bCGvjFcxVUHv EKAchaJwkJE5qXAugpX6SbsB6pZ++uEsFvpff5vGCdqLKEzgcGkcN40zXXfmuSxQbAH0 ld7A== X-Gm-Message-State: APjAAAWrKbAMqJT22nIR8zQvisOsrCoBtg3171oNAnQ1zjZtVXPKtIq6 5B3zApKTmnecOIbiuJPBsQjARtOM3EDQaA== X-Google-Smtp-Source: APXvYqxYRuvBPE0xGFypF88YG98wllF0IIMgWOkACR+5JbFUpq8+rry1pXmFuFbS4CnE5DVnRHzT7Q== X-Received: by 2002:a0c:e90b:: with SMTP id a11mr11720436qvo.229.1574961779319; Thu, 28 Nov 2019 09:22:59 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id j7sm8823693qkd.46.2019.11.28.09.22.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2019 09:22:58 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn Date: Thu, 28 Nov 2019 12:22:57 -0500 Message-Id: References: <20191128154637.GO26807@dhcp22.suse.cz> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Oscar Salvador In-Reply-To: <20191128154637.GO26807@dhcp22.suse.cz> To: Michal Hocko X-Mailer: iPhone Mail (17A878) X-Bogosity: Ham, tests=bogofilter, spamicity=0.011876, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Nov 28, 2019, at 10:46 AM, Michal Hocko wrote: >=20 > I tend to push back on cleanups without a clear added value. In this > particular case it is not about aesthetic or a personal feeling about > the code though. Please read my comment with the ack. I can only encourage you to push back more in general especially for those m= icro-size cleanups. On the other hand, it could be arbitrary because once yo= u are gone for vacations or some other reasons, it will be inconsistent of r= eviewing. You are mostly of my first defense those days.=