From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7879CD31765 for ; Tue, 5 Nov 2024 16:56:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 128A86B0082; Tue, 5 Nov 2024 11:56:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D8E26B0098; Tue, 5 Nov 2024 11:56:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE3706B0099; Tue, 5 Nov 2024 11:56:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D0AB56B0096 for ; Tue, 5 Nov 2024 11:56:54 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7DBBA4075D for ; Tue, 5 Nov 2024 16:56:54 +0000 (UTC) X-FDA: 82752644436.08.F42DE7D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id E5668C0016 for ; Tue, 5 Nov 2024 16:56:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SwUKbSwb; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730825754; a=rsa-sha256; cv=none; b=qA1LST09P3XATKUhdkY8jMJThDIknp/aaOsy2Zh3XmC6GRDTcoaYj24JzKP4+uAyEu9o5e Zpba+BJSlLWDqIG5Otj35AeMBjk44SQNdvMd7/XhtNMqFEjEQXq4T4tpGhta5wyS2NkngS seM1ixvXy73gWP4w5IUnpuCkTW9EOfE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SwUKbSwb; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730825754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7oIwGTVY/I6JyMXum8SeZs4pN4WeEwrlyBBykfS/x9g=; b=LO/B1q9AInOaYVV4F/0gJkslqOLMrbPIvHLg4qckDpPbxjMOZQ5R2i1y3MAI48xKfvKx4Q 32GgGqrJbXm433dTcgU0SohQY9jqupAyxd3IcayW/O2zSA7AjfhxdkQ6irqYUCI0ldDEgT fRMi5v4BMZ8dY95D3Im6VknsuA6l4m8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E3FFC5C271E; Tue, 5 Nov 2024 16:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A80BDC4CECF; Tue, 5 Nov 2024 16:56:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730825811; bh=mxXdhn9082V/+eWc2UvTpidq1SQnQuFmuGGmGo46OTk=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=SwUKbSwbPVI5PWUq4M4pSnRYCfeNObfw/7OZuyjT578X7Y710ODIuBAGq2D88aIIp tTdYomg6iGsDc+0YiHMcnF4qKA/jJM7bHgqbhc5QWb/KRxYW2ct91YBUFz8T419RH8 tKM1JyxUajmkMsdUtb4v7dD3xPE4MmYhBH0Y1Kmpm2l61FR91luBcGhbrCGFQJV/W1 7LcsdWnp3s805zhZehYtsK3IENqXwBoSPyHlo96y/6w6V93qKmBjhc0gx6DSWgHFsA NkOpzmmqz/kyF/TWcWLUwDBPbse3LzzI/qNCzKLTdR49HL15V9E2dhH0TqrsgFhv0m RhmZb690dEkDg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 05 Nov 2024 18:56:47 +0200 Message-Id: Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v16 1/3] ACPI: APEI: send SIGBUS to current task if synchronous memory error not recovered From: "Jarkko Sakkinen" To: "Yazen Ghannam" , "Shuai Xue" X-Mailer: aerc 0.18.2 References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20241104015430.98599-2-xueshuai@linux.alibaba.com> <20241105150945.GE916505@yaz-khff2.amd.com> In-Reply-To: <20241105150945.GE916505@yaz-khff2.amd.com> X-Rspam-User: X-Rspamd-Queue-Id: E5668C0016 X-Rspamd-Server: rspam01 X-Stat-Signature: oohqsihipyaz84btkfura9hkk4tbgyo8 X-HE-Tag: 1730825778-446493 X-HE-Meta: U2FsdGVkX1/JlCf72tNgmbPPQm8cQmFtxhY+IhvHVg7hbGnLqODjR5vHROhB+jsUzBa49q0SdQr2JArPgM1jWl1Nqxp6hlcPfiE9K+1vb4lo/lXQSQMaAmw1odypY25c8SJTav5QNEFqSLUvU2FVyn9N01M5WSHfRLmeBo74pVcJ2/OakDEIM7CJZZMKe0wpOO+N2dHdqKSr8rxjzbJ22sryyJTDCzbXdjV0aIPvQzm/n+ImoV/GNTk7Yv4EPMPkr/EYC7E785Ob4JwLJvxx8KCdYns53yBb2IoDvFyaTaMc7028gGCZ1sckJCA2A22geD9v0ArU9p+aohIwYOiwv71ekdRvYnQWx4lQrsKmsZVvlb2AEL+nTSPs8k+XQYCj4ipYsgzcq06BnHvclvKudXI1i3t0lqK7U9SIJrcLFou4xNj3Tj3NdSD3/CHcoLEUkSMTtzRBoYIBPwsSlTl4PDihW8Q8WQSGFoGHeEhWsd+tLUHNr8w2AJMBTZ+z4jV0OaLc7Us3m2h1svatEhOUZ7Z5pA1/zu0LkcueN1p77RabX5q8an/voq9mSo8PqGj7LVI0ul5avykHQn/J6X2ipRs38gZULTuIY8E6hsljjYXJMk5/76yR5p3c/5oqqTBhXzwiMxdG+ea08Asq/pUgnwIAH5IXbGCCzDkZeRMTevTHn9km4F/jnYjCcLumjQ2/om+K9mU5qgOe3Tw6FiNXDWHK2e+lVPcUDQGgwPBCDu/Cvnjfef4mtgVB7x3Bf5U33STyCsRSWSpI/eripTlJ+9/3KaX4fbznPrDfDmnn9mB2T0oPLe4gAmpSshpRJaUGMugPFgL3vrsfKmgYJgKViyESAwzaeLKR3jO8+u4wMaEOtBvb6FX9OVCFxekHX4k0bRPfrCjXOoWIvHezrZG3Yo5hsVeNqjGdW9GB3HNDFelzvIKnWRGd2aT8gIch2O55BQ1uQJ2IVerWPq0fBLb JaKXv0CB 9F3e+nPj8JwCckSbXwSCoXRyWipxHvZpjdTynXa+xhmvnIYlQiv9LsqnW7EdixQFg3RsAMKziwbgBKGBfE8Tw1f8C51iBVFEtTS10gQv7zlH716pwYvPTOgkrowxvEOBNKP8eXBaiRiU00N95eiR3NJB1zIzl/sl4cI2kpx7IH9ERioUDNgQwzhjgnMxAfJFrSmLIN0yshzqX0WhqM+Rk0PRfzuiQPLJX2GY7qXXtRYyxCjXW5TWHx2f8eXl2cM92YdbAdyE5m5vd7/0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue Nov 5, 2024 at 5:09 PM EET, Yazen Ghannam wrote: > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > > index ada93cfde9ba..af3339dd3817 100644 > > --- a/drivers/acpi/apei/ghes.c > > +++ b/drivers/acpi/apei/ghes.c > > @@ -801,6 +801,16 @@ static bool ghes_do_proc(struct ghes *ghes, > > } > > } > > =20 > > + /* > > + * If no memory failure work is queued for abnormal synchronous > > + * errors, do a force kill. > > + */ > > + if (sync && !queued) { > > + pr_err(HW_ERR GHES_PFX "%s:%d: hardware memory corruption (SIGBUS)\n= ", > > Is this always a memory error? The code flow above implies that an > unrecoverable ARM processor error can all be !queued. So should the > message be more generic like "synchronous unrecoverable error" or > similar? > > In any case, this is just a minor nit if this is not an issue in > practice. One minor thing that came to mind after reading your response: wouldn't it be a better idea to use dev_err() against ghes->dev, rather than raw pr_err()? That would better context information and also I just (re-)checked the file and also ghes_remove() is using dev_err(). > > Reviewed-by: Yazen Ghannam > > Thanks, > Yazen BR, Jarkko