RE: [PATCH] nommu: remap_pfn_range: fix addr parameter check

[Bhupesh SHARMA <bhupesh.sharma@st.com>]

> -----Original Message-----
> From: Scott Jiang [mailto:scott.jiang.linux@gmail.com]
> Sent: Friday, September 14, 2012 2:53 PM
> To: Andrew Morton
> Cc: Bob Liu; linux-mm@kvack.org; Bhupesh SHARMA;
> laurent.pinchart@ideasonboard.com; uclinux-dist-
> devel@blackfin.uclinux.org; linux-media@vger.kernel.org;
> dhowells@redhat.com; geert@linux-m68k.org; gerg@uclinux.org;
> stable@kernel.org; gregkh@linuxfoundation.org; Hugh Dickins
> Subject: Re: [PATCH] nommu: remap_pfn_range: fix addr parameter check
> 
> > Yes, the MMU version of remap_pfn_range() does permit non-page-
> aligned
> > `addr' (at least, if the userspace maaping is a non-COW one).  But I
> > suspect that was an implementation accident - it is a nonsensical
> > thing to do, isn't it?  The MMU cannot map a bunch of kernel pages
> > onto a non-page-aligned userspace address.
> >
> > So I'm thinking that we should declare ((addr & ~PAGE_MASK) != 0) to
> > be a caller bug, and fix up this regrettably unidentified v4l driver?
> 
> I agree. This should be fixed in videobuf.
> 
> Hi sharma, what's your kernel version? It seems videobuf2 already fixed this
> bug in 3.5.

Hi Scott,

I was using 3.3 linux kernel. I will again check if videobuf2 in 3.5 has already fixed this issue.

Regards,
Bhupesh


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>