From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F763C52D6F for ; Tue, 20 Aug 2024 02:37:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8091F6B0083; Mon, 19 Aug 2024 22:37:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B91A6B0085; Mon, 19 Aug 2024 22:37:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A8486B0088; Mon, 19 Aug 2024 22:37:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 493BC6B0083 for ; Mon, 19 Aug 2024 22:37:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2432A177C for ; Tue, 20 Aug 2024 02:37:56 +0000 (UTC) X-FDA: 82471063752.28.5203BA9 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf18.hostedemail.com (Postfix) with ESMTP id C134E1C0010 for ; Tue, 20 Aug 2024 02:37:54 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CMjjkQ5J; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724121417; a=rsa-sha256; cv=none; b=qeDC3NItzLlecAJnko6FAVw5ibBscoqpX7jMre01A9hRVMIHsgPmDCVMFWxNOXBFcwt8k+ GURyjgmT/Z3GmHWVI9nDM383AoeAbJzpmwkAroY+1tEsqVehPq2NOKV6afBizjyWwFC7nf P2Po020xk+goYGTwzAffbRySIgshk+M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CMjjkQ5J; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724121417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YswQe8pDVgtxcv4I7cGkqok1RAga6VHIduWtMUdKToQ=; b=JkQUnHwmrzYMsqAuDBauYCmPK3gjtnPHWImxZDzi1C5uMcnYcNg/S309aqniF5BNNZY77o NgDOETYyn23dOlVGZAyB9afbkhXnfWS18XKJZRMIiyYsjXloUXVsRk7oHBo0W2hYa4Zugy 27HKKDjLY4kJY/uAOyFA5KOOcqZPOjA= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724121472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YswQe8pDVgtxcv4I7cGkqok1RAga6VHIduWtMUdKToQ=; b=CMjjkQ5Jpn/xysHdkNs8bPNCe+t1ermXgSMEq/Ub0O9ed0ZtFSPJctwnoc0lg3f657VsEr WQ32d8QFoo6pm9b8SBy9E0PzY6ShZzjBuFUg9/Ff+NBfAd9wvBZAQBbF9jctE+K8oEau3s aIgtL4aNLa06/61f2uNIP/6WOkfsrDQ= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: [PATCH] mm: kmem: fix split_page_memcg() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Tue, 20 Aug 2024 10:37:12 +0800 Cc: Muchun Song , Johannes Weiner , Michal Hocko , Roman Gushchin , Andrew Morton , cgroups@vger.kernel.org, Linux Memory Management List , Linux Kernel Mailing List , syzbot Content-Transfer-Encoding: 7bit Message-Id: References: <20240819080415.44964-1-songmuchun@bytedance.com> To: Shakeel Butt X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: C134E1C0010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5m88o7skjiumhpi86i9wjsrckq8pqz3r X-HE-Tag: 1724121474-155209 X-HE-Meta: U2FsdGVkX1+n8m2w9eV6M3Tg+q0+W/AG1pYzeRK7VZiSxfkVsdDnvcQxRB4YDwyoN1S3/apSRr7PZceWMrRTzuDCrNZO3XLJQXhPzKvNd4iMMF9McqSXXZs71mkZxmxefm6CzKUjTyBxZDn+0ftHVLwwa1USngCwBilDSFb1H3TA8Qon+hhCSdgpbTb0h/ZTIxS0gN67FnTKNQA9lzrnJ13xhWdrZ0+totSxGxUkRrMrRWtO20AvibPFBHS+jHaYGdEFtfEGM6aQcVTciqH4qHUuy2EFjqp5NtpSAHr1ktI42Y9+iTDeyuwBwRFfFFCp0Xk7T7feKH6bnVAd04YQOOJzeXyhT/qxDB6T6t4i8ZcDmo+V7jFrzMyboRNUdmHpVPgHfW5C+2MT6uJ1y6H0A717ANrlGDZIi/ey+iC6lhkkIamy9HSBYjqCR4JzWR9v0ae6v6MnXzGW0jlRO3T1/YPinZpAyo98FPOOXOWEK6vB66RaXY7Xnrkf9GZNdBUsQIlYfTrWk6sduOYBW0KyN/C0LdoGJ9aY+6/nzjoWI2hWvRJ1I+M2wRFqqEkV/I7pZChcaPCD/Ts8KhUQtlP3u4T2gxGUC64Iq2iF4Ud3IRE8v/EpXNAWuNtv3tddo70vee/TmGENTgRioUY1tX9y2Loxf9ibWdN4jipST7gkNZlXnozKkLqaBIFNxw+0MwaSqGK1anPatlgcFyz5V9j0w+nPS3z3Fonrcw7KOKIX+1PAlPB75RXrvAzpojlYfCIUVdIh0cvCeaA3FT8Up85l76F274LP9y+1oGivvAF8h/0A9fbB2Wv8qa0v1Z5y7uWPRYR7HY7NDnAYgh8bUwgfqGb3pnZgbWMJvd90Kt9FPWWwBnKdt+VROH8SwiZuh7wSKeI+zjnGY1jDUDzSHFDD7Ui13fxQXLzYci4D9+oGuxkHdyiBWnVUy7biFFfNTfwZ0uLLFKy8iOUU1o9PLYg mmUebFgB +3UXQgJNWQapRHVxaFDntsIBwcnL9zVktondfkOd6icMZCGNOs7h+4E1ecC6fHMpyhPEnk+X11SoNcEsB2E1dg4fCP6vb+17YbmTubtvMQjaFV6jpTiWJegDp0YdnVPpoXkj451sUCmSRtVevE4XQkj1h0rQY/iyjXuU9HjFBTiydIWQHnLExfT6LQpdGrzvnZN5hmhb2pPwRh7RL/wFH+xldffmPfANmU1ETd92jBEjFuYDCQFQXCEXLxx4dBUo2Ij6tIKL5lu+U+xvMO85yt0bhWh62soVGyYtDinMcw7MtAcihj/EGK+k4Qr+YWz9tbRyiw5zwL7equfCNgZhEgjtEp04FWohtPHBcJHM6PxlB9V2SdXF1lmvG56gkbzTUhEsy/ibwiHAYTCn2k3NIpWAHxykValBw7ylhAvtXBVvG/IEAjIvFbfOLz4+tp5SUC6IQG2v+ZSv17oXm9TlkdWTWuw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Aug 19, 2024, at 23:37, Shakeel Butt wrote: > > On Mon, Aug 19, 2024 at 04:04:15PM GMT, Muchun Song wrote: >> split_page_memcg() does not care about the returned memcg for kmem >> pages, so folio_memcg_charged() should be used, otherwise obj_cgroup_memcg >> will complain about this. > > Basically avoid calling folio_memcg() for folio_memcg_kmem(folio), > correct? Yes. Unless you hold rcu lock. > >> >> Reported-by: syzbot+ef4ecf7b6bdc4157bfa4@syzkaller.appspotmail.com >> Signed-off-by: Muchun Song > > Acked-by: Shakeel Butt > Thanks.